Skip to content

src: use string_view in WriteReport() - #60201

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:node-report-string-conversions
Oct 12, 2025
Merged

src: use string_view in WriteReport()#60201
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:node-report-string-conversions

Conversation

@addaleax

Copy link
Copy Markdown
Member

Since 075936b, TriggerNodeReport() takes std::string_view arguments directly.

Since 075936b, `TriggerNodeReport()` takes `std::string_view`
arguments directly.
@addaleaxaddaleax added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Oct 10, 2025
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. labels Oct 10, 2025
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2025
@codecov

codecovBot commented Oct 10, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (e105e82) to head (ad00d97).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60201 +/- ##
==========================================
+ Coverage 88.53% 88.56% +0.03% 
==========================================
Files 704 704 Lines 208087 208087 Branches 40006 40017 +11 ==========================================
+ Hits 184223 184288 +65 + Misses 15869 15815 -54 + Partials 7995 7984 -11 
Files with missing linesCoverage Δ
src/node_report_module.cc87.70% <100.00%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlaurichardlau added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 10, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 3ac88a7 into nodejs:mainOct 12, 2025
89 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 3ac88a7

@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.needs-ciPRs that need a full CI run.reportIssues and PRs related to process.report.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax@nodejs-github-bot@lpinca@anonrig@cjihrig@richardlau@daeyeon@RaisinTen