Uh oh!
There was an error while loading. Please reload this page.
deps: V8: cherry-pick 1e190bbb0396 - #60206
Merged
Merged
Conversation
nodejs-github-bot
commented
Oct 10, 2025
Collaborator
Review requested:
|
richardlau
commented
Oct 10, 2025
Uh oh!
There was an error while loading. Please reload this page.
targos
approved these changes
Oct 10, 2025
9 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Oct 10, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Original commit message: [segmented-table] Disable segments pool if pages can be too large The segments pool can only be used if we have 16Kb allocation granularity. On OSs where the page size can be configured larger we have to disable it, since it is currently not runtime configurabe. Fixed: 425634685 Change-Id: If77e46b034fc2e324d7eabf19eff54958ea6f7cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6973467 Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Olivier Flückiger <olivf@chromium.org> Commit-Queue: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#102700} Refs: v8/v8@1e190bb
This comment was marked as outdated.
This comment was marked as outdated.
targos
approved these changes
Oct 11, 2025
nodejs-github-bot
commented
Oct 11, 2025
Collaborator
nodejs-github-bot
commented
Oct 11, 2025
Collaborator
nodejs-github-bot
commented
Oct 11, 2025
Collaborator
lpinca
approved these changes
Oct 11, 2025
nodejs-github-bot
commented
Oct 11, 2025
Collaborator
RafaelGSS
approved these changes
Oct 12, 2025
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Oct 12, 2025
Collaborator
Landed in 2216a3b |
RafaelGSS pushed a commit
that referenced
this pull request
Oct 13, 2025
Original commit message: [segmented-table] Disable segments pool if pages can be too large The segments pool can only be used if we have 16Kb allocation granularity. On OSs where the page size can be configured larger we have to disable it, since it is currently not runtime configurabe. Fixed: 425634685 Change-Id: If77e46b034fc2e324d7eabf19eff54958ea6f7cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6973467 Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Olivier Flückiger <olivf@chromium.org> Commit-Queue: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#102700} Refs: v8/v8@1e190bb PR-URL: #60206Fixes: nodejs/build#4172 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@1e190bb
Fixes: nodejs/build#4172
The Linux arm64 builds on the release CI have been failing since the V8 14.1 update. If unaddressed this will block Node.js 25.0.0 as Linux on arm64 is a Tier 1 supported platform.
After a long investigation, I have identified https://issues.chromium.org/issues/425634685 as likely to be the issue we are hitting and this PR cherry-picks the fix from v8/v8@1e190bb.
I haven't been able to confirm that this actually fixes the builds on the release CI,but there is enough circumstantial evidence to point to the reference upstream V8 issues and fix.Update Confirmed that his cherry-pick fixes the build on the release machine.