test_runner: add classname hierarchy for JUnit reporter - #60220

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mag123c:feature/junit-classname-hierarchy
Aug 20, 2026
Merged

test_runner: add classname hierarchy for JUnit reporter#60220
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mag123c:feature/junit-classname-hierarchy

Conversation

@mag123c

@mag123cmag123c commented Oct 12, 2025

Copy link
Copy Markdown
Contributor

Fixes: #59417

Implements classname hierarchy for the JUnit XML reporter.
Previously, all tests had classname="test".
Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).

@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 12, 2025
@codecov

codecovBot commented Oct 12, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (7bee754) to head (b8c6928).
⚠️ Report is 431 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60220 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 741 743 +2 Lines 242246 242429 +183 Branches 45628 45664 +36 ========================================
+ Hits 218350 218538 +188 + Misses 15397 15392 -5 
Partials 8499 8499
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js97.93% <100.00%> (+0.01%)⬆️
lib/internal/test_runner/tests_stream.js93.02% <100.00%> (+0.06%)⬆️

... and 64 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mag123c
mag123cforce-pushed the feature/junit-classname-hierarchy branch from f738875 to 5e2a5d3CompareOctober 13, 2025 00:26
@CuriousStork

CuriousStork commented Nov 24, 2025

Copy link
Copy Markdown

Hello @MoLow@pmarchini

Could you take a look? Thank you.

@mag123cmag123c mentioned this pull request Dec 28, 2025
Open
mcollina
mcollina approved these changes Jan 20, 2026
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70930/

@nodejs-github-bot

nodejs-github-bot commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71009/

@mag123c
mag123cforce-pushed the feature/junit-classname-hierarchy branch from 5e2a5d3 to 175d312CompareJanuary 26, 2026 00:48
@CuriousStork

CuriousStork commented Feb 27, 2026

Copy link
Copy Markdown

Hello @MoLow

Could you take a look? Thank you.

@mag123c
mag123cforce-pushed the feature/junit-classname-hierarchy branch from 175d312 to e245584CompareApril 4, 2026 03:59
@MoLowMoLow added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Apr 5, 2026
@MoLow

MoLow commented Apr 5, 2026

Copy link
Copy Markdown
Member

@mag123c, please avoid pushing new commits if unnececary as it requires an entire CI cycle every time

@github-actionsgithub-actionsBot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 5, 2026
@github-actions

github-actionsBot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002251583

@MoLowMoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Apr 5, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2026
@github-actions

github-actionsBot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002689464

@github-actionsgithub-actionsBot added the request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. label Apr 5, 2026
@CuriousStorkCuriousStork mentioned this pull request May 14, 2026
Closed
@avivkeller

avivkeller commented Jul 24, 2026

Copy link
Copy Markdown
Member

@mag123c Please rebase

@mag123c
mag123cforce-pushed the feature/junit-classname-hierarchy branch from e245584 to ddab7feCompareJuly 24, 2026 06:33
@mag123c

mag123c commented Jul 24, 2026

Copy link
Copy Markdown
ContributorAuthor

Rebased onto main, thanks @avivkeller.

@avivkeller

avivkeller commented Jul 24, 2026

Copy link
Copy Markdown
Member

Can you amend your first commit, it must have a "Signed-off-by" trailer.

@mag123c
test_runner: add classname hierarchy for JUnit reporter
b8c6928
Signed-off-by: mag123c <diehreo@gmail.com>
@mag123c
mag123cforce-pushed the feature/junit-classname-hierarchy branch from ddab7fe to b8c6928CompareJuly 26, 2026 05:56
@mag123c

mag123c commented Jul 26, 2026

Copy link
Copy Markdown
ContributorAuthor

Done, added the sign-off. Thanks @avivkeller!

@atlowChemiatlowChemi added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Jul 26, 2026
@github-actionsgithub-actionsBot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 26, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75163/

@atlowChemiatlowChemi removed the request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. label Jul 26, 2026
@CuriousStork

CuriousStork commented Aug 20, 2026

Copy link
Copy Markdown

Hi everyone! As the author of the original issue (#59417), I just wanted to say thank you to @mag123c and all the reviewers for working on this. Since it has all the necessary approvals and the CI has run, is there anything else needed to get this merged? @avivkeller@atlowChemi

@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76052/

@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76062/

@atlowChemiatlowChemi added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot merged commit e2cb91d into nodejs:mainAug 20, 2026
70 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Landed in e2cb91d

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 20, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
cace9e0
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
400d598
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
90c1323
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@MoLowMoLowMoLow approved these changes
@avivkelleravivkelleravivkeller approved these changes
@pmarchinipmarchinipmarchini approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't set classname for testcase element in JUnit XML when using node:test

8 participants

@mag123c@nodejs-github-bot@CuriousStork@MoLow@avivkeller@mcollina@pmarchini@atlowChemi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test_runner: add classname hierarchy for JUnit reporter - #60220
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Aug 20, 2026
Merged
test_runner: add classname hierarchy for JUnit reporter#60220
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Conversation
@mag123c
@mag123cmag123c
commented
Oct 12, 2025

Copy link


Copy Markdown

Contributor
Fixes: #59417
Implements classname hierarchy for the JUnit XML reporter.

Previously, all tests had classname="test".

Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).
@nodejs-github-bot
nodejs-github-bot
commented
Oct 12, 2025

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/test_runner
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
labels
Oct 12, 2025
@codecov
codecovBot
commented
Oct 12, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (7bee754) to head (b8c6928).
⚠️ Report is 431 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #60220 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 741 743 +2 Lines 242246 242429 +183 Branches 45628 45664 +36 ========================================
+ Hits 218350 218538 +188 + Misses 15397 15392 -5 
Partials 8499 8499 
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js97.93% <100.00%> (+0.01%)⬆️
lib/internal/test_runner/tests_stream.js93.02% <100.00%> (+0.06%)⬆️
... and 64 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
f738875 to
5e2a5d3CompareOctober 13, 2025 00:26
@CuriousStork
CuriousStork
commented
Nov 24, 2025

Copy link


Copy Markdown

Hello @MoLow@pmarchini
Could you take a look? Thank you.
@mag123cmag123c
mentioned this pull request
Dec 28, 2025

Open

mcollina
mcollina
approved these changes
Jan 20, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@mcollinamcollina
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jan 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/70930/
@nodejs-github-bot
nodejs-github-bot
commented
Jan 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/71009/
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
5e2a5d3 to
175d312CompareJanuary 26, 2026 00:48
@CuriousStork
CuriousStork
commented
Feb 27, 2026

Copy link


Copy Markdown

Hello @MoLow
Could you take a look? Thank you.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
175d312 to
e245584CompareApril 4, 2026 03:59
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Apr 5, 2026
@MoLow
MoLow
commented
Apr 5, 2026

Copy link


Copy Markdown

Member
@mag123c, please avoid pushing new commits if unnececary as it requires an entire CI cycle every time
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002251583
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Apr 5, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002689464
@github-actionsgithub-actionsBot
added
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Apr 5, 2026
@CuriousStorkCuriousStork
mentioned this pull request
May 14, 2026

Closed

@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
@mag123c Please rebase
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
e245584 to
ddab7feCompareJuly 24, 2026 06:33
@mag123c
mag123c
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto main, thanks @avivkeller.
@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
Can you amend your first commit, it must have a "Signed-off-by" trailer.
@mag123c
test_runner: add classname hierarchy for JUnit reporter
b8c6928
Signed-off-by: mag123c <diehreo@gmail.com>
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
ddab7fe to
b8c6928CompareJuly 26, 2026 05:56
@mag123c
mag123c
commented
Jul 26, 2026

Copy link


Copy Markdown

ContributorAuthor
Done, added the sign-off. Thanks @avivkeller!
@atlowChemiatlowChemi
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 26, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 26, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 26, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75163/
@atlowChemiatlowChemi
removed
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Jul 26, 2026
@CuriousStork
CuriousStork
commented
Aug 20, 2026

Copy link


Copy Markdown

Hi everyone! As the author of the original issue (#59417), I just wanted to say thank you to @mag123c and all the reviewers for working on this. Since it has all the necessary approvals and the CI has run, is there anything else needed to get this merged? @avivkeller@atlowChemi
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76052/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76062/
@atlowChemiatlowChemi
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e2cb91d
into
nodejs:mainAug 20, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in e2cb91d
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
cace9e0
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
400d598
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
90c1323
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@MoLowMoLowMoLow approved these changes
@avivkelleravivkelleravivkeller approved these changes
@pmarchinipmarchinipmarchini approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Can't set classname for testcase element in JUnit XML when using node:test

8 participants

@mag123c@nodejs-github-bot@CuriousStork@MoLow@avivkeller@mcollina@pmarchini@atlowChemi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test_runner: add classname hierarchy for JUnit reporter - #60220
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Aug 20, 2026
Merged
test_runner: add classname hierarchy for JUnit reporter#60220
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Conversation
@mag123c
@mag123cmag123c
commented
Oct 12, 2025

Copy link


Copy Markdown

Contributor
Fixes: #59417
Implements classname hierarchy for the JUnit XML reporter.

Previously, all tests had classname="test".

Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).
@nodejs-github-bot
nodejs-github-bot
commented
Oct 12, 2025

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/test_runner
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
labels
Oct 12, 2025
@codecov
codecovBot
commented
Oct 12, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (7bee754) to head (b8c6928).
⚠️ Report is 431 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #60220 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 741 743 +2 Lines 242246 242429 +183 Branches 45628 45664 +36 ========================================
+ Hits 218350 218538 +188 + Misses 15397 15392 -5 
Partials 8499 8499 
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js97.93% <100.00%> (+0.01%)⬆️
lib/internal/test_runner/tests_stream.js93.02% <100.00%> (+0.06%)⬆️
... and 64 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
f738875 to
5e2a5d3CompareOctober 13, 2025 00:26
@CuriousStork
CuriousStork
commented
Nov 24, 2025

Copy link


Copy Markdown

Hello @MoLow@pmarchini
Could you take a look? Thank you.
@mag123cmag123c
mentioned this pull request
Dec 28, 2025

Open

mcollina
mcollina
approved these changes
Jan 20, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@mcollinamcollina
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jan 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/70930/
@nodejs-github-bot
nodejs-github-bot
commented
Jan 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/71009/
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
5e2a5d3 to
175d312CompareJanuary 26, 2026 00:48
@CuriousStork
CuriousStork
commented
Feb 27, 2026

Copy link


Copy Markdown

Hello @MoLow
Could you take a look? Thank you.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
175d312 to
e245584CompareApril 4, 2026 03:59
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Apr 5, 2026
@MoLow
MoLow
commented
Apr 5, 2026

Copy link


Copy Markdown

Member
@mag123c, please avoid pushing new commits if unnececary as it requires an entire CI cycle every time
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002251583
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Apr 5, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002689464
@github-actionsgithub-actionsBot
added
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Apr 5, 2026
@CuriousStorkCuriousStork
mentioned this pull request
May 14, 2026

Closed

@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
@mag123c Please rebase
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
e245584 to
ddab7feCompareJuly 24, 2026 06:33
@mag123c
mag123c
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto main, thanks @avivkeller.
@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
Can you amend your first commit, it must have a "Signed-off-by" trailer.
@mag123c
test_runner: add classname hierarchy for JUnit reporter
b8c6928
Signed-off-by: mag123c <diehreo@gmail.com>
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
ddab7fe to
b8c6928CompareJuly 26, 2026 05:56
@mag123c
mag123c
commented
Jul 26, 2026

Copy link


Copy Markdown

ContributorAuthor
Done, added the sign-off. Thanks @avivkeller!
@atlowChemiatlowChemi
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 26, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 26, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 26, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75163/
@atlowChemiatlowChemi
removed
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Jul 26, 2026
@CuriousStork
CuriousStork
commented
Aug 20, 2026

Copy link


Copy Markdown

Hi everyone! As the author of the original issue (#59417), I just wanted to say thank you to @mag123c and all the reviewers for working on this. Since it has all the necessary approvals and the CI has run, is there anything else needed to get this merged? @avivkeller@atlowChemi
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76052/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76062/
@atlowChemiatlowChemi
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e2cb91d
into
nodejs:mainAug 20, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in e2cb91d
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
cace9e0
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
400d598
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
90c1323
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@MoLowMoLowMoLow approved these changes
@avivkelleravivkelleravivkeller approved these changes
@pmarchinipmarchinipmarchini approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Can't set classname for testcase element in JUnit XML when using node:test

8 participants

@mag123c@nodejs-github-bot@CuriousStork@MoLow@avivkeller@mcollina@pmarchini@atlowChemi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test_runner: add classname hierarchy for JUnit reporter - #60220
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Aug 20, 2026
Merged
test_runner: add classname hierarchy for JUnit reporter#60220
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Conversation
@mag123c
@mag123cmag123c
commented
Oct 12, 2025

Copy link


Copy Markdown

Contributor
Fixes: #59417
Implements classname hierarchy for the JUnit XML reporter.

Previously, all tests had classname="test".

Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).
@nodejs-github-bot
nodejs-github-bot
commented
Oct 12, 2025

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/test_runner
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
labels
Oct 12, 2025
@codecov
codecovBot
commented
Oct 12, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (7bee754) to head (b8c6928).
⚠️ Report is 431 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #60220 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 741 743 +2 Lines 242246 242429 +183 Branches 45628 45664 +36 ========================================
+ Hits 218350 218538 +188 + Misses 15397 15392 -5 
Partials 8499 8499 
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js97.93% <100.00%> (+0.01%)⬆️
lib/internal/test_runner/tests_stream.js93.02% <100.00%> (+0.06%)⬆️
... and 64 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
f738875 to
5e2a5d3CompareOctober 13, 2025 00:26
@CuriousStork
CuriousStork
commented
Nov 24, 2025

Copy link


Copy Markdown

Hello @MoLow@pmarchini
Could you take a look? Thank you.
@mag123cmag123c
mentioned this pull request
Dec 28, 2025

Open

mcollina
mcollina
approved these changes
Jan 20, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@mcollinamcollina
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jan 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/70930/
@nodejs-github-bot
nodejs-github-bot
commented
Jan 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/71009/
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
5e2a5d3 to
175d312CompareJanuary 26, 2026 00:48
@CuriousStork
CuriousStork
commented
Feb 27, 2026

Copy link


Copy Markdown

Hello @MoLow
Could you take a look? Thank you.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
175d312 to
e245584CompareApril 4, 2026 03:59
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Apr 5, 2026
@MoLow
MoLow
commented
Apr 5, 2026

Copy link


Copy Markdown

Member
@mag123c, please avoid pushing new commits if unnececary as it requires an entire CI cycle every time
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002251583
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Apr 5, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002689464
@github-actionsgithub-actionsBot
added
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Apr 5, 2026
@CuriousStorkCuriousStork
mentioned this pull request
May 14, 2026

Closed

@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
@mag123c Please rebase
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
e245584 to
ddab7feCompareJuly 24, 2026 06:33
@mag123c
mag123c
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto main, thanks @avivkeller.
@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
Can you amend your first commit, it must have a "Signed-off-by" trailer.
@mag123c
test_runner: add classname hierarchy for JUnit reporter
b8c6928
Signed-off-by: mag123c <diehreo@gmail.com>
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
ddab7fe to
b8c6928CompareJuly 26, 2026 05:56
@mag123c
mag123c
commented
Jul 26, 2026

Copy link


Copy Markdown

ContributorAuthor
Done, added the sign-off. Thanks @avivkeller!
@atlowChemiatlowChemi
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 26, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 26, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 26, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75163/
@atlowChemiatlowChemi
removed
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Jul 26, 2026
@CuriousStork
CuriousStork
commented
Aug 20, 2026

Copy link


Copy Markdown

Hi everyone! As the author of the original issue (#59417), I just wanted to say thank you to @mag123c and all the reviewers for working on this. Since it has all the necessary approvals and the CI has run, is there anything else needed to get this merged? @avivkeller@atlowChemi
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76052/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76062/
@atlowChemiatlowChemi
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e2cb91d
into
nodejs:mainAug 20, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in e2cb91d
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
cace9e0
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
400d598
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
90c1323
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@MoLowMoLowMoLow approved these changes
@avivkelleravivkelleravivkeller approved these changes
@pmarchinipmarchinipmarchini approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Can't set classname for testcase element in JUnit XML when using node:test

8 participants

@mag123c@nodejs-github-bot@CuriousStork@MoLow@avivkeller@mcollina@pmarchini@atlowChemi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test_runner: add classname hierarchy for JUnit reporter - #60220
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Aug 20, 2026
Merged
test_runner: add classname hierarchy for JUnit reporter#60220
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Conversation
@mag123c
@mag123cmag123c
commented
Oct 12, 2025

Copy link


Copy Markdown

Contributor
Fixes: #59417
Implements classname hierarchy for the JUnit XML reporter.

Previously, all tests had classname="test".

Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).
@nodejs-github-bot
nodejs-github-bot
commented
Oct 12, 2025

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/test_runner
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
labels
Oct 12, 2025
@codecov
codecovBot
commented
Oct 12, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (7bee754) to head (b8c6928).
⚠️ Report is 431 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #60220 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 741 743 +2 Lines 242246 242429 +183 Branches 45628 45664 +36 ========================================
+ Hits 218350 218538 +188 + Misses 15397 15392 -5 
Partials 8499 8499 
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js97.93% <100.00%> (+0.01%)⬆️
lib/internal/test_runner/tests_stream.js93.02% <100.00%> (+0.06%)⬆️
... and 64 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
f738875 to
5e2a5d3CompareOctober 13, 2025 00:26
@CuriousStork
CuriousStork
commented
Nov 24, 2025

Copy link


Copy Markdown

Hello @MoLow@pmarchini
Could you take a look? Thank you.
@mag123cmag123c
mentioned this pull request
Dec 28, 2025

Open

mcollina
mcollina
approved these changes
Jan 20, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@mcollinamcollina
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jan 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/70930/
@nodejs-github-bot
nodejs-github-bot
commented
Jan 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/71009/
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
5e2a5d3 to
175d312CompareJanuary 26, 2026 00:48
@CuriousStork
CuriousStork
commented
Feb 27, 2026

Copy link


Copy Markdown

Hello @MoLow
Could you take a look? Thank you.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
175d312 to
e245584CompareApril 4, 2026 03:59
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Apr 5, 2026
@MoLow
MoLow
commented
Apr 5, 2026

Copy link


Copy Markdown

Member
@mag123c, please avoid pushing new commits if unnececary as it requires an entire CI cycle every time
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002251583
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Apr 5, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002689464
@github-actionsgithub-actionsBot
added
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Apr 5, 2026
@CuriousStorkCuriousStork
mentioned this pull request
May 14, 2026

Closed

@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
@mag123c Please rebase
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
e245584 to
ddab7feCompareJuly 24, 2026 06:33
@mag123c
mag123c
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto main, thanks @avivkeller.
@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
Can you amend your first commit, it must have a "Signed-off-by" trailer.
@mag123c
test_runner: add classname hierarchy for JUnit reporter
b8c6928
Signed-off-by: mag123c <diehreo@gmail.com>
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
ddab7fe to
b8c6928CompareJuly 26, 2026 05:56
@mag123c
mag123c
commented
Jul 26, 2026

Copy link


Copy Markdown

ContributorAuthor
Done, added the sign-off. Thanks @avivkeller!
@atlowChemiatlowChemi
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 26, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 26, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 26, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75163/
@atlowChemiatlowChemi
removed
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Jul 26, 2026
@CuriousStork
CuriousStork
commented
Aug 20, 2026

Copy link


Copy Markdown

Hi everyone! As the author of the original issue (#59417), I just wanted to say thank you to @mag123c and all the reviewers for working on this. Since it has all the necessary approvals and the CI has run, is there anything else needed to get this merged? @avivkeller@atlowChemi
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76052/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76062/
@atlowChemiatlowChemi
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e2cb91d
into
nodejs:mainAug 20, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in e2cb91d
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
cace9e0
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
400d598
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
90c1323
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@MoLowMoLowMoLow approved these changes
@avivkelleravivkelleravivkeller approved these changes
@pmarchinipmarchinipmarchini approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Can't set classname for testcase element in JUnit XML when using node:test

8 participants

@mag123c@nodejs-github-bot@CuriousStork@MoLow@avivkeller@mcollina@pmarchini@atlowChemi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test_runner: add classname hierarchy for JUnit reporter - #60220
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Aug 20, 2026
Merged
test_runner: add classname hierarchy for JUnit reporter#60220
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Conversation
@mag123c
@mag123cmag123c
commented
Oct 12, 2025

Copy link


Copy Markdown

Contributor
Fixes: #59417
Implements classname hierarchy for the JUnit XML reporter.

Previously, all tests had classname="test".

Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).
@nodejs-github-bot
nodejs-github-bot
commented
Oct 12, 2025

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/test_runner
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
labels
Oct 12, 2025
@codecov
codecovBot
commented
Oct 12, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (7bee754) to head (b8c6928).
⚠️ Report is 431 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #60220 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 741 743 +2 Lines 242246 242429 +183 Branches 45628 45664 +36 ========================================
+ Hits 218350 218538 +188 + Misses 15397 15392 -5 
Partials 8499 8499 
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js97.93% <100.00%> (+0.01%)⬆️
lib/internal/test_runner/tests_stream.js93.02% <100.00%> (+0.06%)⬆️
... and 64 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
f738875 to
5e2a5d3CompareOctober 13, 2025 00:26
@CuriousStork
CuriousStork
commented
Nov 24, 2025

Copy link


Copy Markdown

Hello @MoLow@pmarchini
Could you take a look? Thank you.
@mag123cmag123c
mentioned this pull request
Dec 28, 2025

Open

mcollina
mcollina
approved these changes
Jan 20, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@mcollinamcollina
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jan 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/70930/
@nodejs-github-bot
nodejs-github-bot
commented
Jan 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/71009/
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
5e2a5d3 to
175d312CompareJanuary 26, 2026 00:48
@CuriousStork
CuriousStork
commented
Feb 27, 2026

Copy link


Copy Markdown

Hello @MoLow
Could you take a look? Thank you.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
175d312 to
e245584CompareApril 4, 2026 03:59
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Apr 5, 2026
@MoLow
MoLow
commented
Apr 5, 2026

Copy link


Copy Markdown

Member
@mag123c, please avoid pushing new commits if unnececary as it requires an entire CI cycle every time
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002251583
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Apr 5, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002689464
@github-actionsgithub-actionsBot
added
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Apr 5, 2026
@CuriousStorkCuriousStork
mentioned this pull request
May 14, 2026

Closed

@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
@mag123c Please rebase
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
e245584 to
ddab7feCompareJuly 24, 2026 06:33
@mag123c
mag123c
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto main, thanks @avivkeller.
@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
Can you amend your first commit, it must have a "Signed-off-by" trailer.
@mag123c
test_runner: add classname hierarchy for JUnit reporter
b8c6928
Signed-off-by: mag123c <diehreo@gmail.com>
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
ddab7fe to
b8c6928CompareJuly 26, 2026 05:56
@mag123c
mag123c
commented
Jul 26, 2026

Copy link


Copy Markdown

ContributorAuthor
Done, added the sign-off. Thanks @avivkeller!
@atlowChemiatlowChemi
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 26, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 26, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 26, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75163/
@atlowChemiatlowChemi
removed
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Jul 26, 2026
@CuriousStork
CuriousStork
commented
Aug 20, 2026

Copy link


Copy Markdown

Hi everyone! As the author of the original issue (#59417), I just wanted to say thank you to @mag123c and all the reviewers for working on this. Since it has all the necessary approvals and the CI has run, is there anything else needed to get this merged? @avivkeller@atlowChemi
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76052/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76062/
@atlowChemiatlowChemi
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e2cb91d
into
nodejs:mainAug 20, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in e2cb91d
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
cace9e0
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
400d598
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
90c1323
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@MoLowMoLowMoLow approved these changes
@avivkelleravivkelleravivkeller approved these changes
@pmarchinipmarchinipmarchini approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Can't set classname for testcase element in JUnit XML when using node:test

8 participants

@mag123c@nodejs-github-bot@CuriousStork@MoLow@avivkeller@mcollina@pmarchini@atlowChemi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test_runner: add classname hierarchy for JUnit reporter - #60220
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Aug 20, 2026
Merged
test_runner: add classname hierarchy for JUnit reporter#60220
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Conversation
@mag123c
@mag123cmag123c
commented
Oct 12, 2025

Copy link


Copy Markdown

Contributor
Fixes: #59417
Implements classname hierarchy for the JUnit XML reporter.

Previously, all tests had classname="test".

Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).
@nodejs-github-bot
nodejs-github-bot
commented
Oct 12, 2025

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/test_runner
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
labels
Oct 12, 2025
@codecov
codecovBot
commented
Oct 12, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (7bee754) to head (b8c6928).
⚠️ Report is 431 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #60220 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 741 743 +2 Lines 242246 242429 +183 Branches 45628 45664 +36 ========================================
+ Hits 218350 218538 +188 + Misses 15397 15392 -5 
Partials 8499 8499 
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js97.93% <100.00%> (+0.01%)⬆️
lib/internal/test_runner/tests_stream.js93.02% <100.00%> (+0.06%)⬆️
... and 64 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
f738875 to
5e2a5d3CompareOctober 13, 2025 00:26
@CuriousStork
CuriousStork
commented
Nov 24, 2025

Copy link


Copy Markdown

Hello @MoLow@pmarchini
Could you take a look? Thank you.
@mag123cmag123c
mentioned this pull request
Dec 28, 2025

Open

mcollina
mcollina
approved these changes
Jan 20, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@mcollinamcollina
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jan 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/70930/
@nodejs-github-bot
nodejs-github-bot
commented
Jan 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/71009/
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
5e2a5d3 to
175d312CompareJanuary 26, 2026 00:48
@CuriousStork
CuriousStork
commented
Feb 27, 2026

Copy link


Copy Markdown

Hello @MoLow
Could you take a look? Thank you.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
175d312 to
e245584CompareApril 4, 2026 03:59
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Apr 5, 2026
@MoLow
MoLow
commented
Apr 5, 2026

Copy link


Copy Markdown

Member
@mag123c, please avoid pushing new commits if unnececary as it requires an entire CI cycle every time
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002251583
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Apr 5, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002689464
@github-actionsgithub-actionsBot
added
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Apr 5, 2026
@CuriousStorkCuriousStork
mentioned this pull request
May 14, 2026

Closed

@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
@mag123c Please rebase
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
e245584 to
ddab7feCompareJuly 24, 2026 06:33
@mag123c
mag123c
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto main, thanks @avivkeller.
@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
Can you amend your first commit, it must have a "Signed-off-by" trailer.
@mag123c
test_runner: add classname hierarchy for JUnit reporter
b8c6928
Signed-off-by: mag123c <diehreo@gmail.com>
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
ddab7fe to
b8c6928CompareJuly 26, 2026 05:56
@mag123c
mag123c
commented
Jul 26, 2026

Copy link


Copy Markdown

ContributorAuthor
Done, added the sign-off. Thanks @avivkeller!
@atlowChemiatlowChemi
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 26, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 26, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 26, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75163/
@atlowChemiatlowChemi
removed
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Jul 26, 2026
@CuriousStork
CuriousStork
commented
Aug 20, 2026

Copy link


Copy Markdown

Hi everyone! As the author of the original issue (#59417), I just wanted to say thank you to @mag123c and all the reviewers for working on this. Since it has all the necessary approvals and the CI has run, is there anything else needed to get this merged? @avivkeller@atlowChemi
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76052/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76062/
@atlowChemiatlowChemi
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e2cb91d
into
nodejs:mainAug 20, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in e2cb91d
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
cace9e0
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
400d598
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
90c1323
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@MoLowMoLowMoLow approved these changes
@avivkelleravivkelleravivkeller approved these changes
@pmarchinipmarchinipmarchini approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Can't set classname for testcase element in JUnit XML when using node:test

8 participants

@mag123c@nodejs-github-bot@CuriousStork@MoLow@avivkeller@mcollina@pmarchini@atlowChemi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test_runner: add classname hierarchy for JUnit reporter - #60220
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Aug 20, 2026
Merged
test_runner: add classname hierarchy for JUnit reporter#60220
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mag123c:feature/junit-classname-hierarchy
Conversation
@mag123c
@mag123cmag123c
commented
Oct 12, 2025

Copy link


Copy Markdown

Contributor
Fixes: #59417
Implements classname hierarchy for the JUnit XML reporter.

Previously, all tests had classname="test".

Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).
@nodejs-github-bot
nodejs-github-bot
commented
Oct 12, 2025

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/test_runner
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
labels
Oct 12, 2025
@codecov
codecovBot
commented
Oct 12, 2025•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (7bee754) to head (b8c6928).
⚠️ Report is 431 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #60220 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 741 743 +2 Lines 242246 242429 +183 Branches 45628 45664 +36 ========================================
+ Hits 218350 218538 +188 + Misses 15397 15392 -5 
Partials 8499 8499 
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js97.93% <100.00%> (+0.01%)⬆️
lib/internal/test_runner/tests_stream.js93.02% <100.00%> (+0.06%)⬆️
... and 64 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
f738875 to
5e2a5d3CompareOctober 13, 2025 00:26
@CuriousStork
CuriousStork
commented
Nov 24, 2025

Copy link


Copy Markdown

Hello @MoLow@pmarchini
Could you take a look? Thank you.
@mag123cmag123c
mentioned this pull request
Dec 28, 2025

Open

mcollina
mcollina
approved these changes
Jan 20, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@mcollinamcollina
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jan 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/70930/
@nodejs-github-bot
nodejs-github-bot
commented
Jan 24, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/71009/
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
5e2a5d3 to
175d312CompareJanuary 26, 2026 00:48
@CuriousStork
CuriousStork
commented
Feb 27, 2026

Copy link


Copy Markdown

Hello @MoLow
Could you take a look? Thank you.
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
175d312 to
e245584CompareApril 4, 2026 03:59
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Apr 5, 2026
@MoLow
MoLow
commented
Apr 5, 2026

Copy link


Copy Markdown

Member
@mag123c, please avoid pushing new commits if unnececary as it requires an entire CI cycle every time
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002251583
@MoLowMoLow
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Apr 5, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 5, 2026
@github-actions
github-actionsBot
commented
Apr 5, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002689464
@github-actionsgithub-actionsBot
added
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Apr 5, 2026
@CuriousStorkCuriousStork
mentioned this pull request
May 14, 2026

Closed

@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
@mag123c Please rebase
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
e245584 to
ddab7feCompareJuly 24, 2026 06:33
@mag123c
mag123c
commented
Jul 24, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto main, thanks @avivkeller.
@avivkeller
avivkeller
commented
Jul 24, 2026

Copy link


Copy Markdown

Member
Can you amend your first commit, it must have a "Signed-off-by" trailer.
@mag123c
test_runner: add classname hierarchy for JUnit reporter
b8c6928
Signed-off-by: mag123c <diehreo@gmail.com>
@mag123c
mag123cforce-pushed
the
feature/junit-classname-hierarchy
branch
from
ddab7fe to
b8c6928CompareJuly 26, 2026 05:56
@mag123c
mag123c
commented
Jul 26, 2026

Copy link


Copy Markdown

ContributorAuthor
Done, added the sign-off. Thanks @avivkeller!
@atlowChemiatlowChemi
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 26, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 26, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 26, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75163/
@atlowChemiatlowChemi
removed
the 
request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
label
Jul 26, 2026
@CuriousStork
CuriousStork
commented
Aug 20, 2026

Copy link


Copy Markdown

Hi everyone! As the author of the original issue (#59417), I just wanted to say thank you to @mag123c and all the reviewers for working on this. Since it has all the necessary approvals and the CI has run, is there anything else needed to get this merged? @avivkeller@atlowChemi
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76052/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76062/
@atlowChemiatlowChemi
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit e2cb91d
into
nodejs:mainAug 20, 2026

70 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in e2cb91d
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
cace9e0
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
400d598
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mag123c@aduh95
test_runner: add classname hierarchy for JUnit reporter
90c1323
Signed-off-by: mag123c <diehreo@gmail.com>
PR-URL: #60220Fixes: #59417
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@MoLowMoLowMoLow approved these changes
@avivkelleravivkelleravivkeller approved these changes
@pmarchinipmarchinipmarchini approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Can't set classname for testcase element in JUnit XML when using node:test

8 participants

@mag123c@nodejs-github-bot@CuriousStork@MoLow@avivkeller@mcollina@pmarchini@atlowChemi