Skip to content

doc: clarification for maxBuffer and Unicode output - #6030

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:child_process_max_buffer
Closed

doc: clarification for maxBuffer and Unicode output#6030
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:child_process_max_buffer

Conversation

@jasnell

@jasnelljasnell commented Apr 3, 2016

Copy link
Copy Markdown
Member

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

doc

Description of change

Clarify caveats on maxBuffer with regards to Unicode output.

Refs: #1901

@jasnelljasnell added child_process Issues and PRs related to the child_process subsystem. semver-minor PRs that contain new features and should be released in the next minor version. labels Apr 3, 2016
@bnoordhuis

bnoordhuis commented Apr 4, 2016

Copy link
Copy Markdown
Member

TBH, it seems kind of pointless to me - most child processes will simply ignore it - and it's already perfectly possible to set an environment variable. I don't really see why this should be in core.

@jasnell

jasnell commented Apr 4, 2016

Copy link
Copy Markdown
MemberAuthor

Fair enough. What do you think about the docs change, however?

@bnoordhuis

bnoordhuis commented Apr 5, 2016

Copy link
Copy Markdown
Member

The change to the documentation LGTM if you remove the reference to NODE_CHILD_MAX_BUFFER.

@jasnell
jasnellforce-pushed the child_process_max_buffer branch from ba28b95 to b693babCompareApril 9, 2016 03:26
@jasnelljasnell changed the title child_process: add NODE_CHILD_MAX_BUFFER env variabledoc: clarification for maxBuffer and Unicode outputApr 9, 2016
@jasnelljasnell added doc Issues and PRs related to the documentations. and removed semver-minor PRs that contain new features and should be released in the next minor version. labels Apr 9, 2016
@jasnell
jasnellforce-pushed the child_process_max_buffer branch from b693bab to 1f02970CompareApril 9, 2016 03:33
@jasnell

jasnell commented Apr 9, 2016

Copy link
Copy Markdown
MemberAuthor

@bnoordhuis ... updated so that it's just the documentation changes. Also cleaned up some errant line-wrapping issues and end-of-line-whitespace. PTAL

@bnoordhuis

bnoordhuis commented Apr 9, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment
@benjamingr

benjamingr commented Apr 10, 2016

Copy link
Copy Markdown
Member

LGTM

@jasnell
doc: clarification for maxBuffer and Unicode output
b968cc3
Clarify caveats on `maxBuffer` with regards to Unicode output.
Refs: nodejs#1901
@jasnell
jasnellforce-pushed the child_process_max_buffer branch from 1f02970 to b968cc3CompareApril 10, 2016 23:16
jasnell added a commit that referenced this pull request Apr 10, 2016
@jasnell
doc: clarification for maxBuffer and Unicode output
ad2df3a
Clarify caveats on `maxBuffer` with regards to Unicode output.
Refs: #1901
PR-URL: #6030
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@jasnell

jasnell commented Apr 10, 2016

Copy link
Copy Markdown
MemberAuthor

Landed in ad2df3a

@jasnelljasnell closed this Apr 10, 2016
@MylesBorinsMylesBorins mentioned this pull request Apr 11, 2016
Closed
@MylesBorins

MylesBorins commented Apr 11, 2016

Copy link
Copy Markdown
Contributor

@jasnell lts?

MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@jasnellMyles Borins
doc: clarification for maxBuffer and Unicode output
660de1d
Clarify caveats on `maxBuffer` with regards to Unicode output.
Refs: #1901
PR-URL: #6030
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@jasnellMyles Borins
doc: clarification for maxBuffer and Unicode output
79d612f
Clarify caveats on `maxBuffer` with regards to Unicode output.
Refs: #1901
PR-URL: #6030
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@jasnellMyles Borins
doc: clarification for maxBuffer and Unicode output
daaad47
Clarify caveats on `maxBuffer` with regards to Unicode output.
Refs: #1901
PR-URL: #6030
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
@MylesBorins

MylesBorins commented Apr 21, 2016

Copy link
Copy Markdown
Contributor

@jasnell lts?

@jasnell

jasnell commented Apr 21, 2016

Copy link
Copy Markdown
MemberAuthor

+1
On Apr 20, 2016 11:33 PM, "Myles Borins" notifications@github.com wrote:

@jasnellhttps://github.com/jasnell lts?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6030 (comment)

jasnell added a commit that referenced this pull request Apr 26, 2016
@jasnell
doc: clarification for maxBuffer and Unicode output
aa1220d
Clarify caveats on `maxBuffer` with regards to Unicode output.
Refs: #1901
PR-URL: #6030
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MylesBorins

MylesBorins commented May 17, 2016

Copy link
Copy Markdown
Contributor

@jasnell not landing cleanly, would you like to backport?

@jasnell

jasnell commented May 17, 2016

Copy link
Copy Markdown
MemberAuthor

will do

@MylesBorins

MylesBorins commented Aug 30, 2016

Copy link
Copy Markdown
Contributor

ping @jasnell

@jasnell

jasnell commented Aug 30, 2016

Copy link
Copy Markdown
MemberAuthor

Thanks for the reminder, will do this week.

@jasnelljasnell self-assigned this Aug 30, 2016
@MylesBorins

MylesBorins commented Nov 18, 2016

Copy link
Copy Markdown
Contributor

@jasnell added don't land. Feel free to still open a backport PR

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jasnelljasnell

Labels

child_processIssues and PRs related to the child_process subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell@bnoordhuis@benjamingr@MylesBorins