Skip to content

test: ensure win32.isAbsolute() is consistent - #6043

Closed
MylesBorins wants to merge 1 commit into
nodejs:v4.x-stagingfrom
MylesBorins:path-win32
Closed

test: ensure win32.isAbsolute() is consistent#6043
MylesBorins wants to merge 1 commit into
nodejs:v4.x-stagingfrom
MylesBorins:path-win32

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Apr 4, 2016

Copy link
Copy Markdown
Contributor

Adds test cases to ensure win32.isAbsolute is consistent.

This is a backport from 3072546

ref: #6028

@mscdexMyles Borins
test: ensure win32.isAbsolute() is consistent
809f930
Adds test cases to ensure win32.isAbsolute is consistent.
This is a backport from 3072546
ref: nodejs#6028
@mscdexmscdex added test Issues and PRs related to the tests. path Issues and PRs related to the path subsystem. v4.x labels Apr 4, 2016
@MylesBorins

MylesBorins commented Apr 4, 2016

Copy link
Copy Markdown
ContributorAuthor

ci: https://ci.nodejs.org/job/node-test-pull-request/2156/

@MylesBorins

MylesBorins commented Apr 4, 2016

Copy link
Copy Markdown
ContributorAuthor

@mscdex I kept you as the author of the commit although I have completely rewritten the commit title / message. Please let me know if you would like anything changed, including your authorship.

@jasnell

jasnell commented Apr 4, 2016

Copy link
Copy Markdown
Member

LGTM if CI is green

@mscdex

mscdex commented Apr 4, 2016

Copy link
Copy Markdown
Contributor

LGTM

@mscdexmscdex removed their assignment Apr 4, 2016
@silverwind

silverwind commented Apr 8, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Apr 8, 2016
@mscdex@jasnell
test: ensure win32.isAbsolute() is consistent
ea83c38
Adds test cases to ensure win32.isAbsolute is consistent.
This is a backport from 3072546
Refs: #6028
PR-URL: #6043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Roman Reiss <me@silverwind.io>
@jasnell

jasnell commented Apr 8, 2016

Copy link
Copy Markdown
Member

Landed in v4.x-staging in ea83c38

@jasnelljasnell closed this Apr 8, 2016
@MylesBorins

MylesBorins commented Apr 8, 2016

Copy link
Copy Markdown
ContributorAuthor

thanks @jasnell

@MylesBorinsMylesBorins mentioned this pull request Apr 11, 2016
Merged
@MylesBorins
MylesBorins deleted the path-win32 branch April 16, 2016 18:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pathIssues and PRs related to the path subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MylesBorins@jasnell@mscdex@silverwind