Skip to content

http2: add diagnostics channels for client stream request body - #60480

Merged
RaisinTen merged 1 commit into
nodejs:mainfrom
RaisinTen:dc-http2-client-stream-body-chunk
Nov 1, 2025
Merged

http2: add diagnostics channels for client stream request body#60480
RaisinTen merged 1 commit into
nodejs:mainfrom
RaisinTen:dc-http2-client-stream-body-chunk

Conversation

@RaisinTen

@RaisinTenRaisinTen commented Oct 29, 2025•
edited
Loading

Copy link
Copy Markdown
Member

These would allow inspection of HTTP/2 client stream request bodies.

This is needed for #60483.

@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Oct 29, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

codecovBot commented Oct 29, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.58%. Comparing base (ba7cdf4) to head (be4f77d).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60480 +/- ##
==========================================
+ Coverage 88.56% 88.58% +0.02% 
==========================================
Files 704 704 Lines 207774 207873 +99 Branches 40027 40063 +36 ==========================================
+ Hits 184020 184153 +133 + Misses 15800 15761 -39 - Partials 7954 7959 +5
Files with missing linesCoverage Δ
lib/internal/http2/core.js95.22% <100.00%> (+0.01%)⬆️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTenRaisinTen mentioned this pull request Oct 29, 2025
Merged
IlyasShabi
IlyasShabi reviewed Oct 29, 2025
View reviewed changes
Comment threadlib/internal/http2/core.js Outdated
IlyasShabi
IlyasShabi approved these changes Oct 31, 2025
View reviewed changes

@IlyasShabiIlyasShabi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Qard
Qard reviewed Oct 31, 2025
View reviewed changes

@QardQard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one concern about this breaking API surface, but otherwise LGTM.

Comment threadlib/internal/http2/core.js Outdated
@RaisinTen
RaisinTen requested a review from QardNovember 1, 2025 07:05
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTenRaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 1, 2025
Qard
Qard approved these changes Nov 1, 2025
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69990/

@RaisinTen
http2: add diagnostics channels for client stream request body
f46152f
These would allow inspection of HTTP/2 client stream request bodies.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#60480
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@RaisinTen
RaisinTenforce-pushed the dc-http2-client-stream-body-chunk branch from be4f77d to f46152fCompareNovember 1, 2025 14:30
@RaisinTen
RaisinTen merged commit f46152f into nodejs:mainNov 1, 2025
0 checks passed
@RaisinTen

RaisinTen commented Nov 1, 2025

Copy link
Copy Markdown
MemberAuthor

Landed in f46152f

@RaisinTen
RaisinTen deleted the dc-http2-client-stream-body-chunk branch November 1, 2025 14:31
@github-actionsgithub-actionsBot mentioned this pull request Nov 11, 2025
Merged
@github-actionsgithub-actionsBot mentioned this pull request Dec 9, 2025
Merged
@aduh95aduh95 mentioned this pull request Feb 22, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes
@IlyasShabiIlyasShabiIlyasShabi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.http2Issues or PRs related to the http2 subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RaisinTen@nodejs-github-bot@Qard@IlyasShabi