Uh oh!
There was an error while loading. Please reload this page.
[v24.x backport] deps: V8: backport e5dbbbadcbff - #60524
Closed
RaisinTen wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Nov 1, 2025
Collaborator
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Nov 1, 2025
Collaborator
nodejs-github-bot
commented
Nov 1, 2025
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Nov 4, 2025
Collaborator
nodejs-github-bot
commented
Nov 4, 2025
Collaborator
targos
commented
Dec 5, 2025
Member
@RaisinTen This needs a rebase. |
Original commit message:
Enable --perf-prof flag on MacOS
MacOS actually can share the implementation of {PerfJitLogger} with
Linux. From the issue 40112126, only Fuzzer tests on Windows ran
into UNREACHABLE/FATAL because of the unimplemented {PerfJitLogger}.
This CL enables the flag --perf-prof on MacOS.
Bug: 403765219
Change-Id: I97871fbcc0cb9890c51ca14fd7a6e65bd0e3c0d2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6385655
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
Auto-Submit: 杨文明 <yangwenming@bytedance.com>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#99885}
Refs: v8/v8@e5dbbba
Co-authored-by: Darshan Sen <raisinten@gmail.com>targosforce-pushed
the
backport-58010-to-v24.x
branch
from
December 5, 2025 14:30
639c0a5 to
d5f9bb6Comparetargos
commented
Dec 5, 2025
Member
Rebased |
targos
approved these changes
Dec 6, 2025
nodejs-github-bot
commented
Dec 6, 2025
Collaborator
nodejs-github-bot
commented
Dec 6, 2025
Collaborator
nodejs-github-bot
commented
Dec 6, 2025
Collaborator
targos pushed a commit
that referenced
this pull request
Dec 6, 2025
Original commit message:
Enable --perf-prof flag on MacOS
MacOS actually can share the implementation of {PerfJitLogger} with
Linux. From the issue 40112126, only Fuzzer tests on Windows ran
into UNREACHABLE/FATAL because of the unimplemented {PerfJitLogger}.
This CL enables the flag --perf-prof on MacOS.
Bug: 403765219
Change-Id: I97871fbcc0cb9890c51ca14fd7a6e65bd0e3c0d2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6385655
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
Auto-Submit: 杨文明 <yangwenming@bytedance.com>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#99885}
Refs: v8/v8@e5dbbba
Co-authored-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #60524
Refs: v8/v8@e5dbbba
Reviewed-By: Michaël Zasso <targos@protonmail.com>targos
commented
Dec 6, 2025
Member
Landed in 0bf45a8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport for v24.x of the changes in #58010.
Original commit message:
Refs: v8/v8@e5dbbba