tools: add workflow to add author ready

[aduh95]

The number of PRs keeps creeping up, one of the reason is that we have PRs that have been approved and just forgotten about. By having the author ready added automatically, it can help with that as I for one will often check out https://github.com/nodejs/node/pulls?q=is:pr+is:open+label:%22author+ready%22+-label:commit-queue e.g. when preparing a release.

Not that this won't add the label to all PRs that deserve it, won't remove it automatically, and might add to some that do not deserve it, so there will still be triagging work to do.

[nodejs-github-bot]

Review requested:

• @nodejs/actions

[legendecas]

Does this recognize "open comment threads"? I personally usually use "comment" instead of "request for changes", so that the review won't be incorrectly interpreted as aggressiveness.

Though the collaborator guide does not require the author to address all the open comments, an automated process to add author ready label may incorrectly give contributor an impression that they can ignore the open comments and the PR is ready to land.

[legendecas]

Oh, actually the guide does mention the PR should address outstanding review comments before marking it as author ready:

https://github.com/nodejs/node/blob/601208b671e0b4816ff5ebc601290569a6cdddd7/doc/contributing/collaborator-guide.md?plain=1#author-ready-pull-requests#L75

[aduh95]

It might make sense to change the definition of author ready to PR that might be ready: IMO a PR that has author readyPRs that have at least one approval, no pending requests for changes, and a CI started. should not be blindly added to the CQ.

Anyway, I don't mind adding more heuristics to decrease the chance of mislabelling, if you have more suggestions bring them on!

[aduh95]

FWIW, https://github.com/nodejs/node/pulls?q=is:pr+is:open+-label:%22author+ready%22+-label:commit-queue+-label:needs-ci+review:approved+ shows there are about 40 PRs that are likely mergeable; https://github.com/nodejs/node/pulls?q=is:pr+is:open+-label:%22author+ready%22+-label:commit-queue+label:needs-ci+review:approved+ lists 85 that would likely need a CI run before being merged. It's probably too much work for any individual, though if the triaging was done on a more frequent basis, it would be much easier, and my hope is that author readyPRs that have at least one approval, no pending requests for changes, and a CI started. would be part of the solution.

[avivkeller]

If my understanding of https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#workflows-in-forked-repositories-1 is correct, the pull_request_review event doesn’t have the needed permissions for this to work?

[avivkeller]

Bump on this!

[github-actions]

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.