Uh oh!
There was an error while loading. Please reload this page.
lib: remove bootstrap global context indirection - #6062
Closed
Fishrock123 wants to merge 1 commit into
Closed
Conversation
ContributorAuthor
There was a problem hiding this comment.
Ok but that was what the original patch was...
As far as I understand, it's not wrong in this case? Also, won't your PR be back-porting ontop of this?
Member
There was a problem hiding this comment.
It's up for debate whether something that works by accident is wrong or not but if you're back-porting this anyway, I'd recommend changing it to something that's obviously correct. I'll update my back-port PR accordingly, I can simply drop the commit that fixes up this line.
PR-URL: nodejs#5881 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Conflicts: lib/internal/bootstrap_node.js src/node.cc
Fishrock123force-pushed
the
less-context-indirection-v5.x
branch
from
April 7, 2016 15:02
498a47c to
daa191fCompareFishrock123
commented
Apr 7, 2016
ContributorAuthor
jasnell
commented
Apr 7, 2016
Member
LGTM |
MylesBorins
commented
Apr 15, 2016
Contributor
landed in v5.x as d4abca5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
Affected core subsystem(s)
lib
Description of change
Refs: #5881 (comment)
@thealphanerd