Skip to content

src: tag more v8 aligned pointer slots - #60666

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:v8-embedder-tag
Nov 13, 2025
Merged

src: tag more v8 aligned pointer slots#60666
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:v8-embedder-tag

Conversation

@legendecas

Copy link
Copy Markdown
Member

Fixes: #60589

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 10, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecovBot commented Nov 10, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (bd3a202) to head (d176a07).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60666 +/- ##
==========================================
- Coverage 88.55% 88.53% -0.02% 
==========================================
Files 703 703 Lines 208077 208077 Branches 40083 40088 +5 ==========================================
- Hits 184254 184225 -29 - Misses 15841 15884 +43 + Partials 7982 7968 -14 
Files with missing linesCoverage Δ
src/stream_base-inl.h89.33% <ø> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@legendecaslegendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 11, 2025
@targostargos added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Nov 13, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2025
@nodejs-github-bot
nodejs-github-bot merged commit d546e7f into nodejs:mainNov 13, 2025
91 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in d546e7f

@legendecas
legendecas deleted the v8-embedder-tag branch November 13, 2025 14:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V8's aligned pointer APIs are deprecated

4 participants

@legendecas@nodejs-github-bot@targos@cjihrig