Skip to content

deps: V8: cherry-pick highway@989a498fdf3 - #60682

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:backport-highway-fix-gcc15
Nov 13, 2025
Merged

deps: V8: cherry-pick highway@989a498fdf3#60682
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:backport-highway-fix-gcc15

Conversation

@richardlau

@richardlaurichardlau commented Nov 11, 2025

Copy link
Copy Markdown
Member

Original commit message:

GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
Fixes: #60566

cc @nodejs/v8-update

This hasn't landed in upstream V8 yet, so the usual @node-core/utils V8 backport tooling can't be used. I've tried to replicate the commit message format. Hopefully V8 will roll the highway dependency forward to pick up the fix so we won't have to float the patch forever.

@richardlaurichardlau added v8 engine Issues and PRs related to the V8 dependency. dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Nov 11, 2025
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Nov 11, 2025
@richardlaurichardlau mentioned this pull request Nov 11, 2025
Closed
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2025
@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70151/

@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6850/

@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6850/

@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6850/

@richardlaurichardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 12, 2025
@richardlau

richardlau commented Nov 13, 2025

Copy link
Copy Markdown
MemberAuthor

@targos Should I block this and rebase once #60488 lands? I think otherwise the embedder string will end up being incorrect.

@richardlaurichardlau removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2025
@targos

targos commented Nov 13, 2025

Copy link
Copy Markdown
Member

@richardlau thanks, I just landed the V8 update.

@richardlau
deps: V8: cherry-pick highway@989a498fdf3
5c19834
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
@richardlau
richardlauforce-pushed the backport-highway-fix-gcc15 branch from a10eaa3 to 5c19834CompareNovember 13, 2025 14:29
@richardlau

richardlau commented Nov 13, 2025

Copy link
Copy Markdown
MemberAuthor

Rebased and renumbered the embedder string.

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2025
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6856/

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2025
@nodejs-github-bot
nodejs-github-bot merged commit da71ab6 into nodejs:mainNov 13, 2025
64 checks passed
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator

Landed in da71ab6

@richardlau
richardlau deleted the backport-highway-fix-gcc15 branch November 13, 2025 19:50
targos pushed a commit to targos/node that referenced this pull request Dec 9, 2025
@richardlau@targos
deps: V8: cherry-pick highway@989a498fdf3
03d2922
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: nodejs#60682Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Dec 22, 2025
@richardlau@targos
deps: V8: cherry-pick highway@989a498fdf3
27a85c6
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: nodejs#60682Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Feb 4, 2026
@richardlau@targos
deps: V8: cherry-pick highway@989a498fdf3
dc308b6
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: nodejs#60682Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Feb 11, 2026
@richardlau@targos
deps: V8: cherry-pick highway@989a498fdf3
d5239d7
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: nodejs#60682Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit that referenced this pull request Mar 18, 2026
@richardlau@targos
deps: V8: cherry-pick highway@989a498fdf3
b0a1824
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: #60682Fixes: #60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 3, 2026
@richardlau@targos
deps: V8: cherry-pick highway@989a498fdf3
1c30378
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: nodejs#60682Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Apr 3, 2026
@richardlau@joyeecheung
deps: V8: cherry-pick highway@989a498fdf3
7fe6057
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: nodejs#60682Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Renegade334 pushed a commit to Renegade334/node that referenced this pull request Apr 11, 2026
@richardlau@Renegade334
deps: V8: cherry-pick highway@989a498fdf3
a50f729
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: nodejs#60682Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit that referenced this pull request Apr 15, 2026
@richardlau@targos
deps: V8: cherry-pick highway@989a498fdf3
e8ef7b6
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: #60682Fixes: #60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 17, 2026
@richardlau@targos
deps: V8: cherry-pick highway@989a498fdf3
40e0d8b
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: nodejs#60682Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 24, 2026
@richardlau@targos
deps: V8: cherry-pick highway@989a498fdf3
21cf280
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: nodejs#60682Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@meixgmeixgmeixg approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.needs-ciPRs that need a full CI run.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

main fails to compile with gcc 15

6 participants

@richardlau@nodejs-github-bot@targos@lpinca@cjihrig@meixg