Uh oh!
There was an error while loading. Please reload this page.
doc: clarifies http.serverResponse implementation - #6072
Closed
AllenSH12 wants to merge 1 commit into
Closed
Conversation
claudiorodriguez
commented
Apr 6, 2016
Contributor
LGTM. A tiny bit of semantic ambiguity, but I wouldn't know how to make it clearer without also making it less readable, and the point gets across perfectly anyway. |
jasnell
commented
Apr 7, 2016
Member
/cc @indutny |
jasnell
commented
Apr 18, 2016
Member
ping @indutny @nodejs/http |
jasnell
commented
Apr 21, 2016
Member
this will need a rebase. |
Since http.serverResponse does not inherit from Stream.writable it does not pass the test `serverResponse instanceof stream.Writable`. This commit clarifies that serverResponse does not inherit from stream.Writable and therefore should not be expected to pass the above test - fixes node/node.js#6046
AllenSH12force-pushed
the
server-response-inheritance
branch
from
April 21, 2016 22:36
8713746 to
f590549CompareAllenSH12
commented
Apr 21, 2016
ContributorAuthor
@jasnell thanks for helping out, rebased 👍 |
jasnell
commented
Apr 21, 2016
Member
@nodejs/documentation |
eljefedelrodeodeljefe
commented
Apr 22, 2016
Contributor
Good. LGTM. |
estliberitasforce-pushed
the
master
branch
2 times, most recently
from
April 26, 2016 05:23
7da4fd4 to
c7066fbComparestevemao
commented
Apr 28, 2016
Contributor
If this must be very terse then LGTM, but I'd add more information. |
indutny
commented
Apr 28, 2016
Member
LGTM, will try to fix it eventually. |
stevemao
commented
Apr 28, 2016
Contributor
Fix what? |
indutny
commented
Apr 28, 2016
Member
@stevemao it should inherit from |
jasnell
commented
Apr 28, 2016
Member
LGTM |
jasnell pushed a commit
that referenced
this pull request
May 1, 2016
Since http.serverResponse does not inherit from Stream.writable it does not pass the test `serverResponse instanceof stream.Writable`. This commit clarifies that serverResponse does not inherit from stream.Writable and therefore should not be expected to pass the above test Fixes: #6046 PR-URL: #6072 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
May 1, 2016
Member
Landed in a45ab97. Fixed up a minor line wrapping issue on landing. |
MylesBorins pushed a commit
that referenced
this pull request
May 3, 2016
Since http.serverResponse does not inherit from Stream.writable it does not pass the test `serverResponse instanceof stream.Writable`. This commit clarifies that serverResponse does not inherit from stream.Writable and therefore should not be expected to pass the above test Fixes: #6046 PR-URL: #6072 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit
that referenced
this pull request
May 4, 2016
Since http.serverResponse does not inherit from Stream.writable it does not pass the test `serverResponse instanceof stream.Writable`. This commit clarifies that serverResponse does not inherit from stream.Writable and therefore should not be expected to pass the above test Fixes: #6046 PR-URL: #6072 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 4, 2016
joelostrowski pushed a commit
to joelostrowski/node
that referenced
this pull request
May 4, 2016
Since http.serverResponse does not inherit from Stream.writable it does not pass the test `serverResponse instanceof stream.Writable`. This commit clarifies that serverResponse does not inherit from stream.Writable and therefore should not be expected to pass the above test Fixes: nodejs#6046 PR-URL: nodejs#6072 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 6, 2016
Since http.serverResponse does not inherit from Stream.writable it does not pass the test `serverResponse instanceof stream.Writable`. This commit clarifies that serverResponse does not inherit from stream.Writable and therefore should not be expected to pass the above test Fixes: #6046 PR-URL: #6072 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 18, 2016
Since http.serverResponse does not inherit from Stream.writable it does not pass the test `serverResponse instanceof stream.Writable`. This commit clarifies that serverResponse does not inherit from stream.Writable and therefore should not be expected to pass the above test Fixes: #6046 PR-URL: #6072 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Since http.serverResponse does not inherit from Stream.writable
it does not pass the test
serverResponse instanceof stream.Writable.This commit clarifies that serverResponse does not inherit from
stream.Writable and therefore should not be expected to pass the above
test