Skip to content

build: add temporal to linux GHA build - #60942

Closed
legendecas wants to merge 3 commits into
nodejs:mainfrom
legendecas:temporal-ci-pr
Closed

build: add temporal to linux GHA build#60942
legendecas wants to merge 3 commits into
nodejs:mainfrom
legendecas:temporal-ci-pr

Conversation

@legendecas

@legendecaslegendecas commented Dec 3, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Ensure that the V8 temporal build is good. GitHub Action is easier to install rust toolchains, so we can start with GHA to test temporal builds.

This includes builds on ubuntu x64 and arm64.

Use rustc v1.82.0 as https://doc.rust-lang.org/beta/releases.html#version-1820-2024-10-17 noted that this is the oldest version support of llvm v19.

Refs: #60897
Refs: #58730

@nodejs-github-bot

nodejs-github-bot commented Dec 3, 2025•
edited by legendecas
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/build

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 3, 2025
@legendecas
legendecas marked this pull request as ready for review December 3, 2025 11:13
@legendecas
legendecas marked this pull request as draft December 3, 2025 11:13
@legendecas
legendecas marked this pull request as ready for review December 3, 2025 13:52
@legendecas
legendecasforce-pushed the temporal-ci-pr branch 2 times, most recently from be7436f to 2544f16CompareDecember 3, 2025 14:11
@legendecaslegendecas added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v20.x build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Dec 3, 2025
aduh95
aduh95 reviewed Dec 3, 2025
View reviewed changes
Comment thread.github/workflows/test-linux.yml Outdated
@aduh95

aduh95 commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Shouldn't we add https://github.com/nodejs/node/labels/dont-land-on-v25%2ex as well?

@legendecas@aduh95
fixup! build: add temporal to linux GHA build
39b0108
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@legendecas

legendecas commented Dec 3, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Shouldn't we add dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. as well?

temporal_capi is already in the V8 of v25.x branch: https://github.com/nodejs/node/blob/v25.x/deps/v8/BUILD.gn#L2326

node/deps/v8/BUILD.gn

Line 2326 in fc996fd

public_deps= [ "//third_party/rust/temporal_capi" ]

And #60703 didn't mark with https://github.com/nodejs/node/labels/dont-land-on-v25%2ex.

So this should be able to land on v25.x

@legendecaslegendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 4, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2025
@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2025

Copy link
Copy Markdown
Collaborator

Landed in e776946...253b16f

nodejs-github-bot pushed a commit that referenced this pull request Dec 5, 2025
@legendecas@nodejs-github-bot
build: add temporal to linux GHA build
a004535
PR-URL: #60942
Refs: #60897
Refs: #58730
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 5, 2025
@legendecas@nodejs-github-bot
doc: add note about rust toolchain version requirement
253b16f
PR-URL: #60942
Refs: #60897
Refs: #58730
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@legendecas
legendecas deleted the temporal-ci-pr branch December 5, 2025 11:44
@targos

targos commented Dec 5, 2025

Copy link
Copy Markdown
Member

I pushed v25.x-staging with this commit today and it failed: https://github.com/nodejs/node/actions/runs/19964374188/job/57252255440

@legendecas

legendecas commented Dec 5, 2025

Copy link
Copy Markdown
MemberAuthor

I pushed v25.x-staging with this commit today and it failed: https://github.com/nodejs/node/actions/runs/19964374188/job/57252255440

Ah so temporal v0.1.0 requires https://chromium-review.googlesource.com/c/v8/v8/+/6944922, and it depends on #60111.

@richardlaurichardlau mentioned this pull request Jan 22, 2026
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jan 24, 2026
@richardlau
build: add cargo and rustc checks for Temporal
159ae48
If opting into building Node.js with statically linked Temporal
(`configure --v8-enable-temporal-support`), check for the presence
of `cargo` and `rustc` and compare the detected versions against the
documented toolchain versions in `BUILDING.md`.
PR-URL: #61467
Refs: #60942
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@legendecaslegendecas mentioned this pull request Feb 5, 2026
Merged
nodejs-github-bot pushed a commit that referenced this pull request Feb 7, 2026
@legendecas
build: enable temporal on GHA macOS build
f212aee
PR-URL: #61691
Refs: #60942
Refs: #58730
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legendecas@nodejs-github-bot@aduh95@targos@cjihrig