Uh oh!
There was an error while loading. Please reload this page.
[v24.x backport] src: move import.meta initializer to native land - #61048
Closed
targos wants to merge 1 commit into
Closed
[v24.x backport] src: move import.meta initializer to native land#61048targos wants to merge 1 commit into
targos wants to merge 1 commit into
Conversation
nodejs-github-bot
commented
Dec 13, 2025
Collaborator
Review requested:
|
aduh95
approved these changes
Dec 13, 2025
nodejs-github-bot
commented
Jan 1, 2026
Collaborator
marco-ippolitoforce-pushed
the
v24.x-staging
branch
from
January 13, 2026 13:27
d4dceb9 to
2358296CompareWhen the source text module is compiled without custom callbacks, instead of calling into JS land from the per-isolate import.meta initializer and then back to C++ land to set up lazy data properties, just do the initialization all in C++ land. Only import.meta.resolve initialization will call back into JS land to generate a closure that call the cascaded loader for resolution. In addition, simplify the loader structure by merging allowImportMetaResolve into isForAsyncLoaderHookWorker - the two are essentially equivalent, as import.meta.resolve is only allowed in a non-loader-hook worker thread's loader. PR-URL: nodejs#60603 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
targosforce-pushed
the
backport-import-meta-v24
branch
from
January 23, 2026 13:56
12610e1 to
a90d936Comparetargos
commented
Jan 23, 2026
MemberAuthor
Simple rebase without conflicts. I'll land if GitHub CI is green. |
targos pushed a commit
that referenced
this pull request
Jan 28, 2026
When the source text module is compiled without custom callbacks, instead of calling into JS land from the per-isolate import.meta initializer and then back to C++ land to set up lazy data properties, just do the initialization all in C++ land. Only import.meta.resolve initialization will call back into JS land to generate a closure that call the cascaded loader for resolution. In addition, simplify the loader structure by merging allowImportMetaResolve into isForAsyncLoaderHookWorker - the two are essentially equivalent, as import.meta.resolve is only allowed in a non-loader-hook worker thread's loader. PR-URL: #60603 Backport-PR-URL: #61048 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
targos
commented
Jan 28, 2026
MemberAuthor
Landed in 0b31d9b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #60603
Changed
v8::Maybe<bool>::IsEmptycalls toIsNothing(they are aliases in newer V8).