Skip to content

[v24.x backport] util: fix nested proxy inspection - #61154

Closed
LiviaMedeiros wants to merge 1 commit into
nodejs:v24.x-stagingfrom
LiviaMedeiros:backport-61077-to-24
Closed

[v24.x backport] util: fix nested proxy inspection#61154
LiviaMedeiros wants to merge 1 commit into
nodejs:v24.x-stagingfrom
LiviaMedeiros:backport-61077-to-24

Conversation

@LiviaMedeiros

Copy link
Copy Markdown
Member

util: fix nested proxy inspection
Fixes: #61061
PR-URL: #61077
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: LiviaMedeiros livia@cirno.name
Reviewed-By: Juan José Arboleda soyjuanarbol@gmail.com
Reviewed-By: Gürgün Dayıoğlu hey@gurgun.day

Manual backport was required due to semver-majorPRs that contain breaking changes and should be released in the next major version. change on main that adjusted formatting for proxies.

This version should be cleanly cherrypickable for v22.x if considered important for LTS; LMK if PRs to older release lines are needed.

@LiviaMedeirosLiviaMedeiros added util Issues and PRs related to the built-in util module. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Dec 23, 2025

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a suggestion

Comment threadlib/internal/util/inspect.js Outdated
Fixes: nodejs#61061
PR-URL: nodejs#61077
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@targos

Copy link
Copy Markdown
Member

Is this backport different from #61152?

@LiviaMedeiros

Copy link
Copy Markdown
MemberAuthor

@targos same, either can be cleanly landed on either v24.x or v25.x

@targos

Copy link
Copy Markdown
Member

Then I think we can close this PR. At least my method of updating LTS is to use the current release branch as a reference (and commits must live on a current release before being cherry-picked to LTS)

@LiviaMedeiros

Copy link
Copy Markdown
MemberAuthor

Sure, closing in favour of #61152.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.v24.xIssues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LiviaMedeiros@targos@BridgeAR