util: use primordials consistently in comparisons.js by Ayoub-Mabrouk · Pull Request #61198 · nodejs/node

Ayoub-Mabrouk · 2025-12-29T01:40:45Z

Replace native array.push() with ArrayPrototypePush in lib/internal/util/comparisons.js for consistency and security.

This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.

codecov · 2025-12-29T09:54:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (05d6b9b) to head (2413d7a).
⚠️ Report is 454 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #61198 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.01% 
==========================================
Files 703 703 Lines 208599 208613 +14 Branches 40229 40243 +14 ==========================================
+ Hits 184685 184728 +43 + Misses 15939 15894 -45 - Partials 7975 7991 +16

Files with missing lines	Coverage Δ
lib/internal/util/comparisons.js	`99.71% <100.00%> (+<0.01%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Replace native methods with primordials.

nodejs-github-bot · 2026-03-02T23:03:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71532/

trivikr · 2026-06-22T04:25:42Z

The benchmarks can be run with CATEGORY=assert and FILTER=deepequal once the CI is fixed in nodejs/build#4374

aduh95 · 2026-08-17T08:44:18Z

Landed in cc60845

PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>

Ayoub-Mabrouk · 2025-12-29T01:40:45Z

Replace native array.push() with ArrayPrototypePush in lib/internal/util/comparisons.js for consistency and security.

This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.

codecov · 2025-12-29T09:54:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (05d6b9b) to head (2413d7a).
⚠️ Report is 454 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #61198 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.01% 
==========================================
Files 703 703 Lines 208599 208613 +14 Branches 40229 40243 +14 ==========================================
+ Hits 184685 184728 +43 + Misses 15939 15894 -45 - Partials 7975 7991 +16

Files with missing lines	Coverage Δ
lib/internal/util/comparisons.js	`99.71% <100.00%> (+<0.01%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Replace native methods with primordials.

nodejs-github-bot · 2026-03-02T23:03:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71532/

trivikr · 2026-06-22T04:25:42Z

The benchmarks can be run with CATEGORY=assert and FILTER=deepequal once the CI is fixed in nodejs/build#4374

aduh95 · 2026-08-17T08:44:18Z

Landed in cc60845

PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>

Ayoub-Mabrouk · 2025-12-29T01:40:45Z

Replace native array.push() with ArrayPrototypePush in lib/internal/util/comparisons.js for consistency and security.

This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.

codecov · 2025-12-29T09:54:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (05d6b9b) to head (2413d7a).
⚠️ Report is 454 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #61198 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.01% 
==========================================
Files 703 703 Lines 208599 208613 +14 Branches 40229 40243 +14 ==========================================
+ Hits 184685 184728 +43 + Misses 15939 15894 -45 - Partials 7975 7991 +16

Files with missing lines	Coverage Δ
lib/internal/util/comparisons.js	`99.71% <100.00%> (+<0.01%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Replace native methods with primordials.

nodejs-github-bot · 2026-03-02T23:03:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71532/

trivikr · 2026-06-22T04:25:42Z

The benchmarks can be run with CATEGORY=assert and FILTER=deepequal once the CI is fixed in nodejs/build#4374

aduh95 · 2026-08-17T08:44:18Z

Landed in cc60845

PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>

Ayoub-Mabrouk · 2025-12-29T01:40:45Z

Replace native array.push() with ArrayPrototypePush in lib/internal/util/comparisons.js for consistency and security.

This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.

codecov · 2025-12-29T09:54:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (05d6b9b) to head (2413d7a).
⚠️ Report is 454 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #61198 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.01% 
==========================================
Files 703 703 Lines 208599 208613 +14 Branches 40229 40243 +14 ==========================================
+ Hits 184685 184728 +43 + Misses 15939 15894 -45 - Partials 7975 7991 +16

Files with missing lines	Coverage Δ
lib/internal/util/comparisons.js	`99.71% <100.00%> (+<0.01%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Replace native methods with primordials.

nodejs-github-bot · 2026-03-02T23:03:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71532/

trivikr · 2026-06-22T04:25:42Z

The benchmarks can be run with CATEGORY=assert and FILTER=deepequal once the CI is fixed in nodejs/build#4374

aduh95 · 2026-08-17T08:44:18Z

Landed in cc60845

PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>

Ayoub-Mabrouk · 2025-12-29T01:40:45Z

Replace native array.push() with ArrayPrototypePush in lib/internal/util/comparisons.js for consistency and security.

This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.

codecov · 2025-12-29T09:54:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (05d6b9b) to head (2413d7a).
⚠️ Report is 454 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #61198 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.01% 
==========================================
Files 703 703 Lines 208599 208613 +14 Branches 40229 40243 +14 ==========================================
+ Hits 184685 184728 +43 + Misses 15939 15894 -45 - Partials 7975 7991 +16

Files with missing lines	Coverage Δ
lib/internal/util/comparisons.js	`99.71% <100.00%> (+<0.01%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Replace native methods with primordials.

nodejs-github-bot · 2026-03-02T23:03:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71532/

trivikr · 2026-06-22T04:25:42Z

The benchmarks can be run with CATEGORY=assert and FILTER=deepequal once the CI is fixed in nodejs/build#4374

aduh95 · 2026-08-17T08:44:18Z

Landed in cc60845

PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>

Ayoub-Mabrouk · 2025-12-29T01:40:45Z

Replace native array.push() with ArrayPrototypePush in lib/internal/util/comparisons.js for consistency and security.

This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.

codecov · 2025-12-29T09:54:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (05d6b9b) to head (2413d7a).
⚠️ Report is 454 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #61198 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.01% 
==========================================
Files 703 703 Lines 208599 208613 +14 Branches 40229 40243 +14 ==========================================
+ Hits 184685 184728 +43 + Misses 15939 15894 -45 - Partials 7975 7991 +16

Files with missing lines	Coverage Δ
lib/internal/util/comparisons.js	`99.71% <100.00%> (+<0.01%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Replace native methods with primordials.

nodejs-github-bot · 2026-03-02T23:03:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71532/

trivikr · 2026-06-22T04:25:42Z

The benchmarks can be run with CATEGORY=assert and FILTER=deepequal once the CI is fixed in nodejs/build#4374

aduh95 · 2026-08-17T08:44:18Z

Landed in cc60845

PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>

Ayoub-Mabrouk · 2025-12-29T01:40:45Z

Replace native array.push() with ArrayPrototypePush in lib/internal/util/comparisons.js for consistency and security.

This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.

codecov · 2025-12-29T09:54:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (05d6b9b) to head (2413d7a).
⚠️ Report is 454 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #61198 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.01% 
==========================================
Files 703 703 Lines 208599 208613 +14 Branches 40229 40243 +14 ==========================================
+ Hits 184685 184728 +43 + Misses 15939 15894 -45 - Partials 7975 7991 +16

Files with missing lines	Coverage Δ
lib/internal/util/comparisons.js	`99.71% <100.00%> (+<0.01%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Replace native methods with primordials.

nodejs-github-bot · 2026-03-02T23:03:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71532/

trivikr · 2026-06-22T04:25:42Z

The benchmarks can be run with CATEGORY=assert and FILTER=deepequal once the CI is fixed in nodejs/build#4374

aduh95 · 2026-08-17T08:44:18Z

Landed in cc60845

PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>

Ayoub-Mabrouk · 2025-12-29T01:40:45Z

Replace native array.push() with ArrayPrototypePush in lib/internal/util/comparisons.js for consistency and security.

This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.

codecov · 2025-12-29T09:54:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (05d6b9b) to head (2413d7a).
⚠️ Report is 454 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #61198 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.01% 
==========================================
Files 703 703 Lines 208599 208613 +14 Branches 40229 40243 +14 ==========================================
+ Hits 184685 184728 +43 + Misses 15939 15894 -45 - Partials 7975 7991 +16

Files with missing lines	Coverage Δ
lib/internal/util/comparisons.js	`99.71% <100.00%> (+<0.01%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Replace native methods with primordials.

nodejs-github-bot · 2026-03-02T23:03:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71532/

trivikr · 2026-06-22T04:25:42Z

The benchmarks can be run with CATEGORY=assert and FILTER=deepequal once the CI is fixed in nodejs/build#4374

aduh95 · 2026-08-17T08:44:18Z

Landed in cc60845

PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Dec 29, 2025

avivkeller approved these changes Dec 29, 2025
View reviewed changes

avivkeller added the needs-benchmark-ci PRs that need a benchmark CI run. label Dec 29, 2025

Ayoub-Mabrouk force-pushed the util-use-primordials-comparisons branch from 9b5d7b1 to 10b4d8dCompare December 29, 2025 16:46

util: replace native methods with primordials
2413d7a
Replace native methods with primordials.

Ayoub-Mabrouk force-pushed the util-use-primordials-comparisons branch from 10b4d8d to 2413d7aCompare December 29, 2025 17:47

VoltrexKeyva approved these changes Dec 30, 2025
View reviewed changes

aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 17, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2026

This comment was marked as outdated.
Sign in to view

ljharb approved these changes Feb 19, 2026
View reviewed changes

aduh95 merged commit cc60845 into nodejs:mainAug 17, 2026
66 checks passed

aduh95 pushed a commit that referenced this pull request Aug 25, 2026
util: use more primordials in comparisons.js
1924ea5
PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>

aduh95 pushed a commit that referenced this pull request Aug 25, 2026
util: use more primordials in comparisons.js
f373dab
PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>

aduh95 mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

aduh95 pushed a commit that referenced this pull request Aug 27, 2026
util: use more primordials in comparisons.js
64c20b4
PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>