Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions lib/internal/child_process.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ const {
const EventEmitter = require('events');
const net = require('net');
const dgram = require('dgram');
const fs = require('fs');
const path = require('path');
const inspect = require('internal/util/inspect').inspect;
const assert = require('internal/assert');

Expand DownExpand Up@@ -73,6 +75,32 @@ const {
UV_ESRCH,
} = internalBinding('uv');

function verifyENOENT(file, envPairs) {
if (file === '.' || file.includes(path.sep)) return false;
let envPath;
if (envPairs) {
for (let i = 0; i < envPairs.length; i++) {
const pair = envPairs[i];
if (pair.startsWith('PATH=')) {
envPath = pair.slice(5);
break;
}
}
}
envPath ||= process.env.PATH;
if (!envPath) return false;
const paths = envPath.split(path.delimiter);
for (let i = 0; i < paths.length; i++) {
const p = paths[i];
if (!p) continue;
const fullPath = path.resolve(p, file);
if (fs.existsSync(fullPath)) {
return false;
}
}
return true;
}

const { SocketListSend, SocketListReceive } = SocketList;

// Lazy loaded for startup performance and to allow monkey patching of
Expand DownExpand Up@@ -394,8 +422,9 @@ ChildProcess.prototype.spawn = function spawn(options) {

const err = this._handle.spawn(options);

// Run-time errors should emit an error, not throw an exception.
if (err === UV_EACCES ||
if (err === UV_EACCES && verifyENOENT(this.spawnfile, options.envPairs)) {
process.nextTick(onErrorNT, this, UV_ENOENT);
} else if (err === UV_EACCES ||
err === UV_EAGAIN ||
err === UV_EMFILE ||
err === UV_ENFILE ||
Expand DownExpand Up@@ -1088,6 +1117,10 @@ function maybeClose(subprocess) {
function spawnSync(options) {
const result = spawn_sync.spawn(options);

if (result.error === UV_EACCES && verifyENOENT(options.file, options.envPairs)) {
result.error = UV_ENOENT;
}

if (result.output && options.encoding && options.encoding !== 'buffer') {
for (let i = 0; i < result.output.length; i++) {
if (!result.output[i])
Expand Down
105 changes: 105 additions & 0 deletions test/parallel/test-child-process-spawn-path-access.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const fs = require('fs');
const path = require('path');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

// Scenario: PATH contains directories that are inaccessible or are actually files.
// The system spawn (execvp) might return EACCES in these cases on some platforms.
// We want to ensure Node.js consistently reports ENOENT if the command is truly missing.

const noPermDir = path.join(tmpdir.path, 'no-perm-dir');
fs.mkdirSync(noPermDir);

const fileInPath = path.join(tmpdir.path, 'file-in-path');
fs.writeFileSync(fileInPath, '');

if (!common.isWindows) {
try {
fs.chmodSync(noPermDir, '000');
} catch (e) {
// If we can't chmod (e.g. root or weird fs), skip the permission part of the test
// but keep the structure.
console.log('# Skipped chmod 000 on no-perm-dir due to error:', e.message);
}
}

// Ensure cleanup restores permissions so tmpdir can be removed
process.prependListener('exit', () => {
if (!common.isWindows && fs.existsSync(noPermDir)) {
try {
fs.chmodSync(noPermDir, '777');
} catch {
// Ignore cleanup errors during exit
}
}
});

const env = { ...process.env };
const sep = path.delimiter;

// Prepend the problematic entries to PATH
env.PATH = `${noPermDir}${sep}${fileInPath}${sep}${env.PATH}`;

const command = 'command-that-does-not-exist-at-all-' + Date.now();

const child = cp.spawn(command, { env });

child.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
assert.strictEqual(err.syscall, `spawn ${command}`);
}));

// Also test sync
try {
cp.spawnSync(command, { env });
} catch (err) {
assert.strictEqual(err.code, 'ENOENT');
}

// Case: File exists but is not executable. Should NOT be normalized to ENOENT.
if (!common.isWindows) {
const nonExecFile = path.join(tmpdir.path, 'non-executable');
fs.writeFileSync(nonExecFile, 'echo "should not run"');
fs.chmodSync(nonExecFile, '644');

const env2 = { ...process.env, PATH: tmpdir.path };
const child2 = cp.spawn('non-executable', { env: env2 });
child2.on('error', common.mustCall((err) => {
// It should stay EACCES because the file actually exists
assert.strictEqual(err.code, 'EACCES');
}));

// Also test empty PATH entry
const env3 = { ...process.env, PATH: `${path.delimiter}${env.PATH}` };
const child3 = cp.spawn(command, { env: env3 });
child3.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
}

// Case: No PATH in envPairs
const env4 = { ...process.env };
delete env4.PATH;
const child4 = cp.spawn(command, { env: env4 });
child4.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));

// Case: envPath ||= process.env.PATH (no env passed)
if (!common.isWindows) {
const oldPath = process.env.PATH;
process.env.PATH = `${noPermDir}${path.delimiter}${oldPath}`;
try {
const child5 = cp.spawn(command);
child5.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
} finally {
process.env.PATH = oldPath;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions lib/internal/child_process.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ const {
const EventEmitter = require('events');
const net = require('net');
const dgram = require('dgram');
const fs = require('fs');
const path = require('path');
const inspect = require('internal/util/inspect').inspect;
const assert = require('internal/assert');

Expand DownExpand Up@@ -73,6 +75,32 @@ const {
UV_ESRCH,
} = internalBinding('uv');

function verifyENOENT(file, envPairs) {
if (file === '.' || file.includes(path.sep)) return false;
let envPath;
if (envPairs) {
for (let i = 0; i < envPairs.length; i++) {
const pair = envPairs[i];
if (pair.startsWith('PATH=')) {
envPath = pair.slice(5);
break;
}
}
}
envPath ||= process.env.PATH;
if (!envPath) return false;
const paths = envPath.split(path.delimiter);
for (let i = 0; i < paths.length; i++) {
const p = paths[i];
if (!p) continue;
const fullPath = path.resolve(p, file);
if (fs.existsSync(fullPath)) {
return false;
}
}
return true;
}

const { SocketListSend, SocketListReceive } = SocketList;

// Lazy loaded for startup performance and to allow monkey patching of
Expand DownExpand Up@@ -394,8 +422,9 @@ ChildProcess.prototype.spawn = function spawn(options) {

const err = this._handle.spawn(options);

// Run-time errors should emit an error, not throw an exception.
if (err === UV_EACCES ||
if (err === UV_EACCES && verifyENOENT(this.spawnfile, options.envPairs)) {
process.nextTick(onErrorNT, this, UV_ENOENT);
} else if (err === UV_EACCES ||
err === UV_EAGAIN ||
err === UV_EMFILE ||
err === UV_ENFILE ||
Expand DownExpand Up@@ -1088,6 +1117,10 @@ function maybeClose(subprocess) {
function spawnSync(options) {
const result = spawn_sync.spawn(options);

if (result.error === UV_EACCES && verifyENOENT(options.file, options.envPairs)) {
result.error = UV_ENOENT;
}

if (result.output && options.encoding && options.encoding !== 'buffer') {
for (let i = 0; i < result.output.length; i++) {
if (!result.output[i])
Expand Down
105 changes: 105 additions & 0 deletions test/parallel/test-child-process-spawn-path-access.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const fs = require('fs');
const path = require('path');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

// Scenario: PATH contains directories that are inaccessible or are actually files.
// The system spawn (execvp) might return EACCES in these cases on some platforms.
// We want to ensure Node.js consistently reports ENOENT if the command is truly missing.

const noPermDir = path.join(tmpdir.path, 'no-perm-dir');
fs.mkdirSync(noPermDir);

const fileInPath = path.join(tmpdir.path, 'file-in-path');
fs.writeFileSync(fileInPath, '');

if (!common.isWindows) {
try {
fs.chmodSync(noPermDir, '000');
} catch (e) {
// If we can't chmod (e.g. root or weird fs), skip the permission part of the test
// but keep the structure.
console.log('# Skipped chmod 000 on no-perm-dir due to error:', e.message);
}
}

// Ensure cleanup restores permissions so tmpdir can be removed
process.prependListener('exit', () => {
if (!common.isWindows && fs.existsSync(noPermDir)) {
try {
fs.chmodSync(noPermDir, '777');
} catch {
// Ignore cleanup errors during exit
}
}
});

const env = { ...process.env };
const sep = path.delimiter;

// Prepend the problematic entries to PATH
env.PATH = `${noPermDir}${sep}${fileInPath}${sep}${env.PATH}`;

const command = 'command-that-does-not-exist-at-all-' + Date.now();

const child = cp.spawn(command, { env });

child.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
assert.strictEqual(err.syscall, `spawn ${command}`);
}));

// Also test sync
try {
cp.spawnSync(command, { env });
} catch (err) {
assert.strictEqual(err.code, 'ENOENT');
}

// Case: File exists but is not executable. Should NOT be normalized to ENOENT.
if (!common.isWindows) {
const nonExecFile = path.join(tmpdir.path, 'non-executable');
fs.writeFileSync(nonExecFile, 'echo "should not run"');
fs.chmodSync(nonExecFile, '644');

const env2 = { ...process.env, PATH: tmpdir.path };
const child2 = cp.spawn('non-executable', { env: env2 });
child2.on('error', common.mustCall((err) => {
// It should stay EACCES because the file actually exists
assert.strictEqual(err.code, 'EACCES');
}));

// Also test empty PATH entry
const env3 = { ...process.env, PATH: `${path.delimiter}${env.PATH}` };
const child3 = cp.spawn(command, { env: env3 });
child3.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
}

// Case: No PATH in envPairs
const env4 = { ...process.env };
delete env4.PATH;
const child4 = cp.spawn(command, { env: env4 });
child4.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));

// Case: envPath ||= process.env.PATH (no env passed)
if (!common.isWindows) {
const oldPath = process.env.PATH;
process.env.PATH = `${noPermDir}${path.delimiter}${oldPath}`;
try {
const child5 = cp.spawn(command);
child5.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
} finally {
process.env.PATH = oldPath;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions lib/internal/child_process.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ const {
const EventEmitter = require('events');
const net = require('net');
const dgram = require('dgram');
const fs = require('fs');
const path = require('path');
const inspect = require('internal/util/inspect').inspect;
const assert = require('internal/assert');

Expand DownExpand Up@@ -73,6 +75,32 @@ const {
UV_ESRCH,
} = internalBinding('uv');

function verifyENOENT(file, envPairs) {
if (file === '.' || file.includes(path.sep)) return false;
let envPath;
if (envPairs) {
for (let i = 0; i < envPairs.length; i++) {
const pair = envPairs[i];
if (pair.startsWith('PATH=')) {
envPath = pair.slice(5);
break;
}
}
}
envPath ||= process.env.PATH;
if (!envPath) return false;
const paths = envPath.split(path.delimiter);
for (let i = 0; i < paths.length; i++) {
const p = paths[i];
if (!p) continue;
const fullPath = path.resolve(p, file);
if (fs.existsSync(fullPath)) {
return false;
}
}
return true;
}

const { SocketListSend, SocketListReceive } = SocketList;

// Lazy loaded for startup performance and to allow monkey patching of
Expand DownExpand Up@@ -394,8 +422,9 @@ ChildProcess.prototype.spawn = function spawn(options) {

const err = this._handle.spawn(options);

// Run-time errors should emit an error, not throw an exception.
if (err === UV_EACCES ||
if (err === UV_EACCES && verifyENOENT(this.spawnfile, options.envPairs)) {
process.nextTick(onErrorNT, this, UV_ENOENT);
} else if (err === UV_EACCES ||
err === UV_EAGAIN ||
err === UV_EMFILE ||
err === UV_ENFILE ||
Expand DownExpand Up@@ -1088,6 +1117,10 @@ function maybeClose(subprocess) {
function spawnSync(options) {
const result = spawn_sync.spawn(options);

if (result.error === UV_EACCES && verifyENOENT(options.file, options.envPairs)) {
result.error = UV_ENOENT;
}

if (result.output && options.encoding && options.encoding !== 'buffer') {
for (let i = 0; i < result.output.length; i++) {
if (!result.output[i])
Expand Down
105 changes: 105 additions & 0 deletions test/parallel/test-child-process-spawn-path-access.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const fs = require('fs');
const path = require('path');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

// Scenario: PATH contains directories that are inaccessible or are actually files.
// The system spawn (execvp) might return EACCES in these cases on some platforms.
// We want to ensure Node.js consistently reports ENOENT if the command is truly missing.

const noPermDir = path.join(tmpdir.path, 'no-perm-dir');
fs.mkdirSync(noPermDir);

const fileInPath = path.join(tmpdir.path, 'file-in-path');
fs.writeFileSync(fileInPath, '');

if (!common.isWindows) {
try {
fs.chmodSync(noPermDir, '000');
} catch (e) {
// If we can't chmod (e.g. root or weird fs), skip the permission part of the test
// but keep the structure.
console.log('# Skipped chmod 000 on no-perm-dir due to error:', e.message);
}
}

// Ensure cleanup restores permissions so tmpdir can be removed
process.prependListener('exit', () => {
if (!common.isWindows && fs.existsSync(noPermDir)) {
try {
fs.chmodSync(noPermDir, '777');
} catch {
// Ignore cleanup errors during exit
}
}
});

const env = { ...process.env };
const sep = path.delimiter;

// Prepend the problematic entries to PATH
env.PATH = `${noPermDir}${sep}${fileInPath}${sep}${env.PATH}`;

const command = 'command-that-does-not-exist-at-all-' + Date.now();

const child = cp.spawn(command, { env });

child.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
assert.strictEqual(err.syscall, `spawn ${command}`);
}));

// Also test sync
try {
cp.spawnSync(command, { env });
} catch (err) {
assert.strictEqual(err.code, 'ENOENT');
}

// Case: File exists but is not executable. Should NOT be normalized to ENOENT.
if (!common.isWindows) {
const nonExecFile = path.join(tmpdir.path, 'non-executable');
fs.writeFileSync(nonExecFile, 'echo "should not run"');
fs.chmodSync(nonExecFile, '644');

const env2 = { ...process.env, PATH: tmpdir.path };
const child2 = cp.spawn('non-executable', { env: env2 });
child2.on('error', common.mustCall((err) => {
// It should stay EACCES because the file actually exists
assert.strictEqual(err.code, 'EACCES');
}));

// Also test empty PATH entry
const env3 = { ...process.env, PATH: `${path.delimiter}${env.PATH}` };
const child3 = cp.spawn(command, { env: env3 });
child3.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
}

// Case: No PATH in envPairs
const env4 = { ...process.env };
delete env4.PATH;
const child4 = cp.spawn(command, { env: env4 });
child4.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));

// Case: envPath ||= process.env.PATH (no env passed)
if (!common.isWindows) {
const oldPath = process.env.PATH;
process.env.PATH = `${noPermDir}${path.delimiter}${oldPath}`;
try {
const child5 = cp.spawn(command);
child5.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
} finally {
process.env.PATH = oldPath;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions lib/internal/child_process.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ const {
const EventEmitter = require('events');
const net = require('net');
const dgram = require('dgram');
const fs = require('fs');
const path = require('path');
const inspect = require('internal/util/inspect').inspect;
const assert = require('internal/assert');

Expand DownExpand Up@@ -73,6 +75,32 @@ const {
UV_ESRCH,
} = internalBinding('uv');

function verifyENOENT(file, envPairs) {
if (file === '.' || file.includes(path.sep)) return false;
let envPath;
if (envPairs) {
for (let i = 0; i < envPairs.length; i++) {
const pair = envPairs[i];
if (pair.startsWith('PATH=')) {
envPath = pair.slice(5);
break;
}
}
}
envPath ||= process.env.PATH;
if (!envPath) return false;
const paths = envPath.split(path.delimiter);
for (let i = 0; i < paths.length; i++) {
const p = paths[i];
if (!p) continue;
const fullPath = path.resolve(p, file);
if (fs.existsSync(fullPath)) {
return false;
}
}
return true;
}

const { SocketListSend, SocketListReceive } = SocketList;

// Lazy loaded for startup performance and to allow monkey patching of
Expand DownExpand Up@@ -394,8 +422,9 @@ ChildProcess.prototype.spawn = function spawn(options) {

const err = this._handle.spawn(options);

// Run-time errors should emit an error, not throw an exception.
if (err === UV_EACCES ||
if (err === UV_EACCES && verifyENOENT(this.spawnfile, options.envPairs)) {
process.nextTick(onErrorNT, this, UV_ENOENT);
} else if (err === UV_EACCES ||
err === UV_EAGAIN ||
err === UV_EMFILE ||
err === UV_ENFILE ||
Expand DownExpand Up@@ -1088,6 +1117,10 @@ function maybeClose(subprocess) {
function spawnSync(options) {
const result = spawn_sync.spawn(options);

if (result.error === UV_EACCES && verifyENOENT(options.file, options.envPairs)) {
result.error = UV_ENOENT;
}

if (result.output && options.encoding && options.encoding !== 'buffer') {
for (let i = 0; i < result.output.length; i++) {
if (!result.output[i])
Expand Down
105 changes: 105 additions & 0 deletions test/parallel/test-child-process-spawn-path-access.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const fs = require('fs');
const path = require('path');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

// Scenario: PATH contains directories that are inaccessible or are actually files.
// The system spawn (execvp) might return EACCES in these cases on some platforms.
// We want to ensure Node.js consistently reports ENOENT if the command is truly missing.

const noPermDir = path.join(tmpdir.path, 'no-perm-dir');
fs.mkdirSync(noPermDir);

const fileInPath = path.join(tmpdir.path, 'file-in-path');
fs.writeFileSync(fileInPath, '');

if (!common.isWindows) {
try {
fs.chmodSync(noPermDir, '000');
} catch (e) {
// If we can't chmod (e.g. root or weird fs), skip the permission part of the test
// but keep the structure.
console.log('# Skipped chmod 000 on no-perm-dir due to error:', e.message);
}
}

// Ensure cleanup restores permissions so tmpdir can be removed
process.prependListener('exit', () => {
if (!common.isWindows && fs.existsSync(noPermDir)) {
try {
fs.chmodSync(noPermDir, '777');
} catch {
// Ignore cleanup errors during exit
}
}
});

const env = { ...process.env };
const sep = path.delimiter;

// Prepend the problematic entries to PATH
env.PATH = `${noPermDir}${sep}${fileInPath}${sep}${env.PATH}`;

const command = 'command-that-does-not-exist-at-all-' + Date.now();

const child = cp.spawn(command, { env });

child.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
assert.strictEqual(err.syscall, `spawn ${command}`);
}));

// Also test sync
try {
cp.spawnSync(command, { env });
} catch (err) {
assert.strictEqual(err.code, 'ENOENT');
}

// Case: File exists but is not executable. Should NOT be normalized to ENOENT.
if (!common.isWindows) {
const nonExecFile = path.join(tmpdir.path, 'non-executable');
fs.writeFileSync(nonExecFile, 'echo "should not run"');
fs.chmodSync(nonExecFile, '644');

const env2 = { ...process.env, PATH: tmpdir.path };
const child2 = cp.spawn('non-executable', { env: env2 });
child2.on('error', common.mustCall((err) => {
// It should stay EACCES because the file actually exists
assert.strictEqual(err.code, 'EACCES');
}));

// Also test empty PATH entry
const env3 = { ...process.env, PATH: `${path.delimiter}${env.PATH}` };
const child3 = cp.spawn(command, { env: env3 });
child3.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
}

// Case: No PATH in envPairs
const env4 = { ...process.env };
delete env4.PATH;
const child4 = cp.spawn(command, { env: env4 });
child4.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));

// Case: envPath ||= process.env.PATH (no env passed)
if (!common.isWindows) {
const oldPath = process.env.PATH;
process.env.PATH = `${noPermDir}${path.delimiter}${oldPath}`;
try {
const child5 = cp.spawn(command);
child5.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
} finally {
process.env.PATH = oldPath;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions lib/internal/child_process.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ const {
const EventEmitter = require('events');
const net = require('net');
const dgram = require('dgram');
const fs = require('fs');
const path = require('path');
const inspect = require('internal/util/inspect').inspect;
const assert = require('internal/assert');

Expand DownExpand Up@@ -73,6 +75,32 @@ const {
UV_ESRCH,
} = internalBinding('uv');

function verifyENOENT(file, envPairs) {
if (file === '.' || file.includes(path.sep)) return false;
let envPath;
if (envPairs) {
for (let i = 0; i < envPairs.length; i++) {
const pair = envPairs[i];
if (pair.startsWith('PATH=')) {
envPath = pair.slice(5);
break;
}
}
}
envPath ||= process.env.PATH;
if (!envPath) return false;
const paths = envPath.split(path.delimiter);
for (let i = 0; i < paths.length; i++) {
const p = paths[i];
if (!p) continue;
const fullPath = path.resolve(p, file);
if (fs.existsSync(fullPath)) {
return false;
}
}
return true;
}

const { SocketListSend, SocketListReceive } = SocketList;

// Lazy loaded for startup performance and to allow monkey patching of
Expand DownExpand Up@@ -394,8 +422,9 @@ ChildProcess.prototype.spawn = function spawn(options) {

const err = this._handle.spawn(options);

// Run-time errors should emit an error, not throw an exception.
if (err === UV_EACCES ||
if (err === UV_EACCES && verifyENOENT(this.spawnfile, options.envPairs)) {
process.nextTick(onErrorNT, this, UV_ENOENT);
} else if (err === UV_EACCES ||
err === UV_EAGAIN ||
err === UV_EMFILE ||
err === UV_ENFILE ||
Expand DownExpand Up@@ -1088,6 +1117,10 @@ function maybeClose(subprocess) {
function spawnSync(options) {
const result = spawn_sync.spawn(options);

if (result.error === UV_EACCES && verifyENOENT(options.file, options.envPairs)) {
result.error = UV_ENOENT;
}

if (result.output && options.encoding && options.encoding !== 'buffer') {
for (let i = 0; i < result.output.length; i++) {
if (!result.output[i])
Expand Down
105 changes: 105 additions & 0 deletions test/parallel/test-child-process-spawn-path-access.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const fs = require('fs');
const path = require('path');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

// Scenario: PATH contains directories that are inaccessible or are actually files.
// The system spawn (execvp) might return EACCES in these cases on some platforms.
// We want to ensure Node.js consistently reports ENOENT if the command is truly missing.

const noPermDir = path.join(tmpdir.path, 'no-perm-dir');
fs.mkdirSync(noPermDir);

const fileInPath = path.join(tmpdir.path, 'file-in-path');
fs.writeFileSync(fileInPath, '');

if (!common.isWindows) {
try {
fs.chmodSync(noPermDir, '000');
} catch (e) {
// If we can't chmod (e.g. root or weird fs), skip the permission part of the test
// but keep the structure.
console.log('# Skipped chmod 000 on no-perm-dir due to error:', e.message);
}
}

// Ensure cleanup restores permissions so tmpdir can be removed
process.prependListener('exit', () => {
if (!common.isWindows && fs.existsSync(noPermDir)) {
try {
fs.chmodSync(noPermDir, '777');
} catch {
// Ignore cleanup errors during exit
}
}
});

const env = { ...process.env };
const sep = path.delimiter;

// Prepend the problematic entries to PATH
env.PATH = `${noPermDir}${sep}${fileInPath}${sep}${env.PATH}`;

const command = 'command-that-does-not-exist-at-all-' + Date.now();

const child = cp.spawn(command, { env });

child.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
assert.strictEqual(err.syscall, `spawn ${command}`);
}));

// Also test sync
try {
cp.spawnSync(command, { env });
} catch (err) {
assert.strictEqual(err.code, 'ENOENT');
}

// Case: File exists but is not executable. Should NOT be normalized to ENOENT.
if (!common.isWindows) {
const nonExecFile = path.join(tmpdir.path, 'non-executable');
fs.writeFileSync(nonExecFile, 'echo "should not run"');
fs.chmodSync(nonExecFile, '644');

const env2 = { ...process.env, PATH: tmpdir.path };
const child2 = cp.spawn('non-executable', { env: env2 });
child2.on('error', common.mustCall((err) => {
// It should stay EACCES because the file actually exists
assert.strictEqual(err.code, 'EACCES');
}));

// Also test empty PATH entry
const env3 = { ...process.env, PATH: `${path.delimiter}${env.PATH}` };
const child3 = cp.spawn(command, { env: env3 });
child3.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
}

// Case: No PATH in envPairs
const env4 = { ...process.env };
delete env4.PATH;
const child4 = cp.spawn(command, { env: env4 });
child4.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));

// Case: envPath ||= process.env.PATH (no env passed)
if (!common.isWindows) {
const oldPath = process.env.PATH;
process.env.PATH = `${noPermDir}${path.delimiter}${oldPath}`;
try {
const child5 = cp.spawn(command);
child5.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
} finally {
process.env.PATH = oldPath;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions lib/internal/child_process.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ const {
const EventEmitter = require('events');
const net = require('net');
const dgram = require('dgram');
const fs = require('fs');
const path = require('path');
const inspect = require('internal/util/inspect').inspect;
const assert = require('internal/assert');

Expand DownExpand Up@@ -73,6 +75,32 @@ const {
UV_ESRCH,
} = internalBinding('uv');

function verifyENOENT(file, envPairs) {
if (file === '.' || file.includes(path.sep)) return false;
let envPath;
if (envPairs) {
for (let i = 0; i < envPairs.length; i++) {
const pair = envPairs[i];
if (pair.startsWith('PATH=')) {
envPath = pair.slice(5);
break;
}
}
}
envPath ||= process.env.PATH;
if (!envPath) return false;
const paths = envPath.split(path.delimiter);
for (let i = 0; i < paths.length; i++) {
const p = paths[i];
if (!p) continue;
const fullPath = path.resolve(p, file);
if (fs.existsSync(fullPath)) {
return false;
}
}
return true;
}

const { SocketListSend, SocketListReceive } = SocketList;

// Lazy loaded for startup performance and to allow monkey patching of
Expand DownExpand Up@@ -394,8 +422,9 @@ ChildProcess.prototype.spawn = function spawn(options) {

const err = this._handle.spawn(options);

// Run-time errors should emit an error, not throw an exception.
if (err === UV_EACCES ||
if (err === UV_EACCES && verifyENOENT(this.spawnfile, options.envPairs)) {
process.nextTick(onErrorNT, this, UV_ENOENT);
} else if (err === UV_EACCES ||
err === UV_EAGAIN ||
err === UV_EMFILE ||
err === UV_ENFILE ||
Expand DownExpand Up@@ -1088,6 +1117,10 @@ function maybeClose(subprocess) {
function spawnSync(options) {
const result = spawn_sync.spawn(options);

if (result.error === UV_EACCES && verifyENOENT(options.file, options.envPairs)) {
result.error = UV_ENOENT;
}

if (result.output && options.encoding && options.encoding !== 'buffer') {
for (let i = 0; i < result.output.length; i++) {
if (!result.output[i])
Expand Down
105 changes: 105 additions & 0 deletions test/parallel/test-child-process-spawn-path-access.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const fs = require('fs');
const path = require('path');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

// Scenario: PATH contains directories that are inaccessible or are actually files.
// The system spawn (execvp) might return EACCES in these cases on some platforms.
// We want to ensure Node.js consistently reports ENOENT if the command is truly missing.

const noPermDir = path.join(tmpdir.path, 'no-perm-dir');
fs.mkdirSync(noPermDir);

const fileInPath = path.join(tmpdir.path, 'file-in-path');
fs.writeFileSync(fileInPath, '');

if (!common.isWindows) {
try {
fs.chmodSync(noPermDir, '000');
} catch (e) {
// If we can't chmod (e.g. root or weird fs), skip the permission part of the test
// but keep the structure.
console.log('# Skipped chmod 000 on no-perm-dir due to error:', e.message);
}
}

// Ensure cleanup restores permissions so tmpdir can be removed
process.prependListener('exit', () => {
if (!common.isWindows && fs.existsSync(noPermDir)) {
try {
fs.chmodSync(noPermDir, '777');
} catch {
// Ignore cleanup errors during exit
}
}
});

const env = { ...process.env };
const sep = path.delimiter;

// Prepend the problematic entries to PATH
env.PATH = `${noPermDir}${sep}${fileInPath}${sep}${env.PATH}`;

const command = 'command-that-does-not-exist-at-all-' + Date.now();

const child = cp.spawn(command, { env });

child.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
assert.strictEqual(err.syscall, `spawn ${command}`);
}));

// Also test sync
try {
cp.spawnSync(command, { env });
} catch (err) {
assert.strictEqual(err.code, 'ENOENT');
}

// Case: File exists but is not executable. Should NOT be normalized to ENOENT.
if (!common.isWindows) {
const nonExecFile = path.join(tmpdir.path, 'non-executable');
fs.writeFileSync(nonExecFile, 'echo "should not run"');
fs.chmodSync(nonExecFile, '644');

const env2 = { ...process.env, PATH: tmpdir.path };
const child2 = cp.spawn('non-executable', { env: env2 });
child2.on('error', common.mustCall((err) => {
// It should stay EACCES because the file actually exists
assert.strictEqual(err.code, 'EACCES');
}));

// Also test empty PATH entry
const env3 = { ...process.env, PATH: `${path.delimiter}${env.PATH}` };
const child3 = cp.spawn(command, { env: env3 });
child3.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
}

// Case: No PATH in envPairs
const env4 = { ...process.env };
delete env4.PATH;
const child4 = cp.spawn(command, { env: env4 });
child4.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));

// Case: envPath ||= process.env.PATH (no env passed)
if (!common.isWindows) {
const oldPath = process.env.PATH;
process.env.PATH = `${noPermDir}${path.delimiter}${oldPath}`;
try {
const child5 = cp.spawn(command);
child5.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
} finally {
process.env.PATH = oldPath;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions lib/internal/child_process.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ const {
const EventEmitter = require('events');
const net = require('net');
const dgram = require('dgram');
const fs = require('fs');
const path = require('path');
const inspect = require('internal/util/inspect').inspect;
const assert = require('internal/assert');

Expand DownExpand Up@@ -73,6 +75,32 @@ const {
UV_ESRCH,
} = internalBinding('uv');

function verifyENOENT(file, envPairs) {
if (file === '.' || file.includes(path.sep)) return false;
let envPath;
if (envPairs) {
for (let i = 0; i < envPairs.length; i++) {
const pair = envPairs[i];
if (pair.startsWith('PATH=')) {
envPath = pair.slice(5);
break;
}
}
}
envPath ||= process.env.PATH;
if (!envPath) return false;
const paths = envPath.split(path.delimiter);
for (let i = 0; i < paths.length; i++) {
const p = paths[i];
if (!p) continue;
const fullPath = path.resolve(p, file);
if (fs.existsSync(fullPath)) {
return false;
}
}
return true;
}

const { SocketListSend, SocketListReceive } = SocketList;

// Lazy loaded for startup performance and to allow monkey patching of
Expand DownExpand Up@@ -394,8 +422,9 @@ ChildProcess.prototype.spawn = function spawn(options) {

const err = this._handle.spawn(options);

// Run-time errors should emit an error, not throw an exception.
if (err === UV_EACCES ||
if (err === UV_EACCES && verifyENOENT(this.spawnfile, options.envPairs)) {
process.nextTick(onErrorNT, this, UV_ENOENT);
} else if (err === UV_EACCES ||
err === UV_EAGAIN ||
err === UV_EMFILE ||
err === UV_ENFILE ||
Expand DownExpand Up@@ -1088,6 +1117,10 @@ function maybeClose(subprocess) {
function spawnSync(options) {
const result = spawn_sync.spawn(options);

if (result.error === UV_EACCES && verifyENOENT(options.file, options.envPairs)) {
result.error = UV_ENOENT;
}

if (result.output && options.encoding && options.encoding !== 'buffer') {
for (let i = 0; i < result.output.length; i++) {
if (!result.output[i])
Expand Down
105 changes: 105 additions & 0 deletions test/parallel/test-child-process-spawn-path-access.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const fs = require('fs');
const path = require('path');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

// Scenario: PATH contains directories that are inaccessible or are actually files.
// The system spawn (execvp) might return EACCES in these cases on some platforms.
// We want to ensure Node.js consistently reports ENOENT if the command is truly missing.

const noPermDir = path.join(tmpdir.path, 'no-perm-dir');
fs.mkdirSync(noPermDir);

const fileInPath = path.join(tmpdir.path, 'file-in-path');
fs.writeFileSync(fileInPath, '');

if (!common.isWindows) {
try {
fs.chmodSync(noPermDir, '000');
} catch (e) {
// If we can't chmod (e.g. root or weird fs), skip the permission part of the test
// but keep the structure.
console.log('# Skipped chmod 000 on no-perm-dir due to error:', e.message);
}
}

// Ensure cleanup restores permissions so tmpdir can be removed
process.prependListener('exit', () => {
if (!common.isWindows && fs.existsSync(noPermDir)) {
try {
fs.chmodSync(noPermDir, '777');
} catch {
// Ignore cleanup errors during exit
}
}
});

const env = { ...process.env };
const sep = path.delimiter;

// Prepend the problematic entries to PATH
env.PATH = `${noPermDir}${sep}${fileInPath}${sep}${env.PATH}`;

const command = 'command-that-does-not-exist-at-all-' + Date.now();

const child = cp.spawn(command, { env });

child.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
assert.strictEqual(err.syscall, `spawn ${command}`);
}));

// Also test sync
try {
cp.spawnSync(command, { env });
} catch (err) {
assert.strictEqual(err.code, 'ENOENT');
}

// Case: File exists but is not executable. Should NOT be normalized to ENOENT.
if (!common.isWindows) {
const nonExecFile = path.join(tmpdir.path, 'non-executable');
fs.writeFileSync(nonExecFile, 'echo "should not run"');
fs.chmodSync(nonExecFile, '644');

const env2 = { ...process.env, PATH: tmpdir.path };
const child2 = cp.spawn('non-executable', { env: env2 });
child2.on('error', common.mustCall((err) => {
// It should stay EACCES because the file actually exists
assert.strictEqual(err.code, 'EACCES');
}));

// Also test empty PATH entry
const env3 = { ...process.env, PATH: `${path.delimiter}${env.PATH}` };
const child3 = cp.spawn(command, { env: env3 });
child3.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
}

// Case: No PATH in envPairs
const env4 = { ...process.env };
delete env4.PATH;
const child4 = cp.spawn(command, { env: env4 });
child4.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));

// Case: envPath ||= process.env.PATH (no env passed)
if (!common.isWindows) {
const oldPath = process.env.PATH;
process.env.PATH = `${noPermDir}${path.delimiter}${oldPath}`;
try {
const child5 = cp.spawn(command);
child5.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
} finally {
process.env.PATH = oldPath;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions lib/internal/child_process.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ const {
const EventEmitter = require('events');
const net = require('net');
const dgram = require('dgram');
const fs = require('fs');
const path = require('path');
const inspect = require('internal/util/inspect').inspect;
const assert = require('internal/assert');

Expand DownExpand Up@@ -73,6 +75,32 @@ const {
UV_ESRCH,
} = internalBinding('uv');

function verifyENOENT(file, envPairs) {
if (file === '.' || file.includes(path.sep)) return false;
let envPath;
if (envPairs) {
for (let i = 0; i < envPairs.length; i++) {
const pair = envPairs[i];
if (pair.startsWith('PATH=')) {
envPath = pair.slice(5);
break;
}
}
}
envPath ||= process.env.PATH;
if (!envPath) return false;
const paths = envPath.split(path.delimiter);
for (let i = 0; i < paths.length; i++) {
const p = paths[i];
if (!p) continue;
const fullPath = path.resolve(p, file);
if (fs.existsSync(fullPath)) {
return false;
}
}
return true;
}

const { SocketListSend, SocketListReceive } = SocketList;

// Lazy loaded for startup performance and to allow monkey patching of
Expand DownExpand Up@@ -394,8 +422,9 @@ ChildProcess.prototype.spawn = function spawn(options) {

const err = this._handle.spawn(options);

// Run-time errors should emit an error, not throw an exception.
if (err === UV_EACCES ||
if (err === UV_EACCES && verifyENOENT(this.spawnfile, options.envPairs)) {
process.nextTick(onErrorNT, this, UV_ENOENT);
} else if (err === UV_EACCES ||
err === UV_EAGAIN ||
err === UV_EMFILE ||
err === UV_ENFILE ||
Expand DownExpand Up@@ -1088,6 +1117,10 @@ function maybeClose(subprocess) {
function spawnSync(options) {
const result = spawn_sync.spawn(options);

if (result.error === UV_EACCES && verifyENOENT(options.file, options.envPairs)) {
result.error = UV_ENOENT;
}

if (result.output && options.encoding && options.encoding !== 'buffer') {
for (let i = 0; i < result.output.length; i++) {
if (!result.output[i])
Expand Down
105 changes: 105 additions & 0 deletions test/parallel/test-child-process-spawn-path-access.js
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const fs = require('fs');
const path = require('path');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

// Scenario: PATH contains directories that are inaccessible or are actually files.
// The system spawn (execvp) might return EACCES in these cases on some platforms.
// We want to ensure Node.js consistently reports ENOENT if the command is truly missing.

const noPermDir = path.join(tmpdir.path, 'no-perm-dir');
fs.mkdirSync(noPermDir);

const fileInPath = path.join(tmpdir.path, 'file-in-path');
fs.writeFileSync(fileInPath, '');

if (!common.isWindows) {
try {
fs.chmodSync(noPermDir, '000');
} catch (e) {
// If we can't chmod (e.g. root or weird fs), skip the permission part of the test
// but keep the structure.
console.log('# Skipped chmod 000 on no-perm-dir due to error:', e.message);
}
}

// Ensure cleanup restores permissions so tmpdir can be removed
process.prependListener('exit', () => {
if (!common.isWindows && fs.existsSync(noPermDir)) {
try {
fs.chmodSync(noPermDir, '777');
} catch {
// Ignore cleanup errors during exit
}
}
});

const env = { ...process.env };
const sep = path.delimiter;

// Prepend the problematic entries to PATH
env.PATH = `${noPermDir}${sep}${fileInPath}${sep}${env.PATH}`;

const command = 'command-that-does-not-exist-at-all-' + Date.now();

const child = cp.spawn(command, { env });

child.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
assert.strictEqual(err.syscall, `spawn ${command}`);
}));

// Also test sync
try {
cp.spawnSync(command, { env });
} catch (err) {
assert.strictEqual(err.code, 'ENOENT');
}

// Case: File exists but is not executable. Should NOT be normalized to ENOENT.
if (!common.isWindows) {
const nonExecFile = path.join(tmpdir.path, 'non-executable');
fs.writeFileSync(nonExecFile, 'echo "should not run"');
fs.chmodSync(nonExecFile, '644');

const env2 = { ...process.env, PATH: tmpdir.path };
const child2 = cp.spawn('non-executable', { env: env2 });
child2.on('error', common.mustCall((err) => {
// It should stay EACCES because the file actually exists
assert.strictEqual(err.code, 'EACCES');
}));

// Also test empty PATH entry
const env3 = { ...process.env, PATH: `${path.delimiter}${env.PATH}` };
const child3 = cp.spawn(command, { env: env3 });
child3.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
}

// Case: No PATH in envPairs
const env4 = { ...process.env };
delete env4.PATH;
const child4 = cp.spawn(command, { env: env4 });
child4.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));

// Case: envPath ||= process.env.PATH (no env passed)
if (!common.isWindows) {
const oldPath = process.env.PATH;
process.env.PATH = `${noPermDir}${path.delimiter}${oldPath}`;
try {
const child5 = cp.spawn(command);
child5.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOENT');
}));
} finally {
process.env.PATH = oldPath;
}
}
Loading