Uh oh!
There was an error while loading. Please reload this page.
path: add escapeGlob and unescapeGlob - #61269
Conversation
nodejs-github-bot
commented
Jan 4, 2026
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #61269 +/- ##
==========================================
+ Coverage 90.12% 90.15% +0.02%
==========================================
Files 743 743 Lines 242324 242368 +44 Branches 45629 45635 +6 ==========================================
+ Hits 218396 218501 +105 + Misses 15440 15359 -81 - Partials 8488 8508 +20
🚀 New features to boost your workflow:
|
The
notable-change Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Xstoudi
commented
Feb 24, 2026
Hey, no interest? @nodejs/path |
targos
commented
Feb 25, 2026
@nodejs/path @nodejs/fs |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
TheOneTheOnlyJJ
commented
Mar 31, 2026
I am wondering, why not just expose |
Xstoudi
commented
Apr 1, 2026
Vendoring is an implem detail, not a commitment and I'd prefer to not couple the Node's API to a third-party dependency. Goal here is to provide stable, cross-platform glob semantic in Node rather than exposing raw |
nodejs-github-bot
commented
Apr 2, 2026
Xstoudi
commented
May 18, 2026
Hey, is there something blocking this PR? |
valler
commented
Jul 23, 2026
The test cases don't include patterns containing parentheses |
Xstoudi
commented
Jul 23, 2026
No, I'll add some |
avivkeller
commented
Jul 23, 2026
@Xstoudi Please rebase |
Expose minimatch escaping and unescaping capabilities on path module. Fixes: nodejs#61258 Signed-off-by: Xavier Stouder <xavier@stouder.io>
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/72403/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/30165172379 |
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/72403/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/30182123250 |
path: add escapeGlob and unescapeGlob
Expose minimatch escaping and unescaping capabilities on path module.
Fixes: #61258
This is an implem proposal fix#61258 using
minimatchthat is already-vendored. Also feel free to -1 the change if you think it doesn't have its place there.