Uh oh!
There was an error while loading. Please reload this page.
docs: added documentation for socket.destroyed - #6128
Conversation
tusharmath
commented
Apr 9, 2016
My apologies if some guidelines haven't been met. This is my first contribution. |
| ### socket.destroyed | ||
| A `boolean` value that depicts if the connection is destroyed or not. |
There was a problem hiding this comment.
Can we add a bit more detail about what "destroyed" means?
There was a problem hiding this comment.
Look into the source to find out, I think something along the lines of "does not send or receive any more data, cannot be re-established", but I'm no expert on this topic :).
There was a problem hiding this comment.
I think "indicates" might be a better choice of word than "depicts". Maybe something like this:
A
Booleanvalue that indicates whether the connection has been destroyed or not.
silverwind
commented
Apr 9, 2016
The subsystem should be |
stevemao
commented
Apr 21, 2016
@nodejs/documentation |
benjamingr
commented
Apr 24, 2016
Hey, thanks, please wrap lines at 80 chars :) |
7da4fd4 to
c7066fbComparecjihrig
commented
Jun 16, 2016
@tusharmath ping. Are you still planning to work on this? |
tusharmath
commented
Jun 16, 2016
@cjihrig Made the updates. |
silverwind
commented
Jun 16, 2016
Might be me, but I think this sounds better:
Not strictly necessary for this PR, but I think some information whether a half-closed socket can be in a |
cjihrig
commented
Jun 17, 2016
LGTM |
cjihrig
commented
Jun 17, 2016
Sorry, I do have one nit:
should be
|
tusharmath
commented
Jun 20, 2016
@cjihrig update the changes |
cjihrig
commented
Jun 20, 2016
Sorry, I just realized this - can you maintain the alphabetical order of the docs. |
tusharmath
commented
Jun 20, 2016
@cjihrig Thanks for pointing it out :) |
cjihrig
commented
Jun 21, 2016
Thanks! Landed in 193afef. |
Checklist
Affected core subsystem(s)
doc
Description of change
fixes: #5898