Uh oh!
There was an error while loading. Please reload this page.
test_runner: print coverage and diagnostic info with dot reporter - #61423
Open
mag123c wants to merge 3 commits into
Open
test_runner: print coverage and diagnostic info with dot reporter#61423mag123c wants to merge 3 commits into
mag123c wants to merge 3 commits into
Conversation
nodejs-github-bot
commented
Jan 18, 2026
Collaborator
Review requested:
|
mag123cforce-pushed
the
fix-dot-reporter-coverage
branch
from
January 18, 2026 06:34
83840c7 to
313a274CompareCodecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #61423 +/- ##
==========================================
- Coverage 90.14% 90.13% -0.02%
==========================================
Files 743 743 Lines 242415 242438 +23 Branches 45651 45655 +4 ==========================================
- Hits 218531 218517 -14 - Misses 15386 15424 +38 + Partials 8498 8497 -1
🚀 New features to boost your workflow:
|
pmarchini
commented
Jan 20, 2026
Member
Hey @mag123c, could you please add some tests? |
atlowChemi
approved these changes
Jan 20, 2026
| @@ -170,4 +170,25 @@ for (const coverage of coverages) { | |||
| assert.strictEqual(result.status, 1); | |||
| assert(!findCoverageFileForPid(result.pid)); | |||
| }); | |||
| test(`test failing ${coverage.flag} with dot reporter`, () => { | |||
Member
There was a problem hiding this comment.
NIT: I would suggest adding a snapshot test too, like as we have done in test/test-runner/test-output-coverage-width-100-uncovered-lines.mjs 👀
meixg
approved these changes
Mar 4, 2026
nodejs-github-bot
commented
Mar 4, 2026
Collaborator
This was referenced Mar 10, 2026
When using the dot reporter with coverage enabled, coverage threshold failures and coverage reports were not printed, only an exit code was returned. This made it impossible to know why the test run failed. This change adds handling for test:diagnostic and test:coverage events to the dot reporter, matching the behavior of the spec reporter. Fixes: nodejs#60884 Signed-off-by: mag123c <diehreo@gmail.com>
Signed-off-by: mag123c <diehreo@gmail.com>
Signed-off-by: mag123c <diehreo@gmail.com>
mag123cforce-pushed
the
fix-dot-reporter-coverage
branch
from
July 26, 2026 06:28
1f59f26 to
f27934eCompareContributorAuthor
One thing worth flagging for whoever picks this up: several newer PRs now touch the same handler in |
avivkeller
approved these changes
Jul 26, 2026
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/71552/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/30192660637 |
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/71552/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/30195826270 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds coverage and diagnostic output to the dot reporter in test_runner.
Currently, when using the dot reporter with coverage enabled, if a coverage threshold fails the program exits with code 1 but prints nothing about why. Users have no way to know what went wrong. The spec reporter already handles this correctly.
Changes:
dot.js: handletest:diagnosticevents aterrorlevel (coverage threshold failure messages)dot.js: handletest:coverageevents (coverage report table)The dot reporter now behaves consistently with the spec reporter for coverage output.
Fixes: #60884