Skip to content

lib: recycle queues - #61461

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ronag:fixed-queue-pool
Jan 30, 2026
Merged

lib: recycle queues#61461
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ronag:fixed-queue-pool

Conversation

@ronag

@ronagronag commented Jan 21, 2026

Copy link
Copy Markdown
Member

Avoid creating unnecessary garbage in the old space.

@ronag
ronag requested a review from mcollinaJanuary 21, 2026 13:12
@ronagronag changed the title internal: recycle queueslib: recycle queuesJan 21, 2026
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 21, 2026
@ronag
lib: recycle queues
2e5412f
Avoid creating unnecessary garbage in the old space.
@codecov

codecovBot commented Jan 21, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (bcdf2e0) to head (2e5412f).
⚠️ Report is 184 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #61461 +/- ##
==========================================
- Coverage 88.53% 88.52% -0.01% 
==========================================
Files 704 704 Lines 208759 208984 +225 Branches 40281 40348 +67 ==========================================
+ Hits 184816 185006 +190 - Misses 15947 15962 +15 - Partials 7996 8016 +20
Files with missing linesCoverage Δ
lib/internal/fixed_queue.js100.00% <100.00%> (ø)

... and 83 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ronag
ronag requested a review from anonrigJanuary 21, 2026 14:48
@ronag
ronag requested a review from RafaelGSSJanuary 21, 2026 16:35
mcollina
mcollina approved these changes Jan 21, 2026
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70953/

@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70970/

@ronagronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 24, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70999/

gurgunday
gurgunday reviewed Jan 26, 2026
View reviewed changes

@gurgundaygurgunday left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we use primordials in new code?

To not have Primordials I made the same PR but with just one spare in #60031 a few months ago, but this is better if methods are fine

Comment threadlib/internal/fixed_queue.js
constructor() {
this.head = this.tail = new FixedCircularBuffer();
this.head = this.tail = FixedQueue.#pool.pop() ?? new FixedCircularBuffer();

@gurgundaygurgundayJan 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No primordial?

gurgunday
gurgunday approved these changes Jan 27, 2026
View reviewed changes

@gurgundaygurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71078/

@nodejs-github-bot

nodejs-github-bot commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71127/

@RafaelGSSRafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 30, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 30, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 7407164 into nodejs:mainJan 30, 2026
74 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

Landed in 7407164

aduh95 pushed a commit that referenced this pull request Feb 2, 2026
@ronag@aduh95
lib: recycle queues
d7e8819
Avoid creating unnecessary garbage in the old space.
PR-URL: #61461
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
@ronag@aduh95
lib: recycle queues
f05bad9
Avoid creating unnecessary garbage in the old space.
PR-URL: #61461
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit that referenced this pull request Feb 10, 2026
@ronag@aduh95
lib: recycle queues
5c26b57
Avoid creating unnecessary garbage in the old space.
PR-URL: #61461
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit that referenced this pull request Feb 14, 2026
@ronag@aduh95
lib: recycle queues
e6e829c
Avoid creating unnecessary garbage in the old space.
PR-URL: #61461
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot mentioned this pull request Feb 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 22, 2026
@ronag@aduh95
lib: recycle queues
830fff0
Avoid creating unnecessary garbage in the old space.
PR-URL: #61461
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026
@ronag@juanarbol
lib: recycle queues
6109708
Avoid creating unnecessary garbage in the old space.
PR-URL: nodejs#61461
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
juanarbol pushed a commit that referenced this pull request Jul 17, 2026
@ronag@juanarbol
lib: recycle queues
3ba0d2f
Avoid creating unnecessary garbage in the old space.
PR-URL: #61461
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
juanarbol pushed a commit that referenced this pull request Jul 19, 2026
@ronag@juanarbol
lib: recycle queues
53d6e6d
Avoid creating unnecessary garbage in the old space.
PR-URL: #61461
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
marco-ippolito pushed a commit that referenced this pull request Jul 29, 2026
@ronag@marco-ippolito
lib: recycle queues
33186e8
Avoid creating unnecessary garbage in the old space.
PR-URL: #61461
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@anonriganonriganonrig approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@gurgundaygurgundaygurgunday approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ronag@nodejs-github-bot@mcollina@anonrig@RafaelGSS@gurgunday