Skip to content

module: do not wrap module._load when tracing is not enabled - #61479

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:module-load-frame
Jan 26, 2026
Merged

module: do not wrap module._load when tracing is not enabled#61479
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:module-load-frame

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Jan 22, 2026

Copy link
Copy Markdown
Member

This prevents clobbering the stack traces with another internal frame and removes the unnecessary hoops from step-debugging.

@joyeecheung
module: do not wrap module._load when tracing is not enabled
e06bcd0
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jan 22, 2026
@codecov

codecovBot commented Jan 22, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.87%. Comparing base (e9b0849) to head (e06bcd0).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #61479 +/- ##
==========================================
- Coverage 91.93% 89.87% -2.06% 
==========================================
Files 343 665 +322 Lines 139636 203296 +63660 Branches 22026 39081 +17055 ==========================================
+ Hits 128369 182713 +54344 - Misses 11040 12929 +1889 - Partials 227 7654 +7427
Files with missing linesCoverage Δ
lib/internal/modules/cjs/loader.js98.16% <100.00%> (+18.70%)⬆️

... and 453 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina
mcollina approved these changes Jan 22, 2026
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70978/

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70980/

@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70985/

@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70988/

@nodejs-github-bot

nodejs-github-bot commented Jan 25, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71027/

@nodejs-github-bot

nodejs-github-bot commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71035/

@joyeecheungjoyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 26, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 26, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 644ba1f into nodejs:mainJan 26, 2026
79 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

Landed in 644ba1f

aduh95 pushed a commit that referenced this pull request Jan 28, 2026
@joyeecheung@aduh95
module: do not wrap module._load when tracing is not enabled
a28ddd4
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.
PR-URL: #61479
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@github-actionsgithub-actionsBot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 10, 2026
@joyeecheung@aduh95
module: do not wrap module._load when tracing is not enabled
3cbd36a
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.
PR-URL: #61479
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@github-actionsgithub-actionsBot mentioned this pull request Feb 22, 2026
Merged
@glenjaminglenjamin mentioned this pull request Feb 22, 2026
Closed
aduh95 pushed a commit that referenced this pull request Feb 22, 2026
@joyeecheung@aduh95
module: do not wrap module._load when tracing is not enabled
8d7190b
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.
PR-URL: #61479
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
joyeecheung added a commit to joyeecheung/node that referenced this pull request Feb 27, 2026
@joyeecheung
module: do not wrap module._load when tracing is not enabled
6df0cdf
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.
PR-URL: nodejs#61479
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@joyeecheungjoyeecheung mentioned this pull request Feb 27, 2026
Closed
marco-ippolito pushed a commit that referenced this pull request Apr 27, 2026
@joyeecheung@marco-ippolito
module: do not wrap module._load when tracing is not enabled
9a2e213
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.
PR-URL: #61479
Backport-PR-URL: #62029
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Fixes: #61801
@marco-ippolitomarco-ippolito mentioned this pull request May 11, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@QardQardQard approved these changes
@lpincalpincalpinca approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

moduleIssues and PRs related to the module subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyeecheung@nodejs-github-bot@mcollina@Qard@lpinca@marco-ippolito