Skip to content

build,win: fix vs2022 compilation - #61530

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:mefi-vs2022
Jan 28, 2026
Merged

build,win: fix vs2022 compilation#61530
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:mefi-vs2022

Conversation

@StefanStojanovic

@StefanStojanovicStefanStojanovic commented Jan 26, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

When we added VS2026 support, by accident we broke VS2022 compilation if you have both VS2026 and VS2022 installed (eg, you had to provide the vs2022 parameter). This PR fixes that bug.

@StefanStojanovicStefanStojanovic added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Jan 26, 2026
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 26, 2026
@MikeMcC399

MikeMcC399 commented Jan 26, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

I checked this out and confirm it was broken before and is now fixed. 👍🏻

I hadn't previously noticed because I hadn't used .\vcbuild with a vs* parameter, even though I had done quite a few related tests!

In a side-by-side installation:

VS Build Tools 2022
- "Desktop development with C++" workload
- MSBuild support for LLVM (clang-cl)
- C++ Clang Compiler for Windows (19.1.5)

VS Build Tools 2026
- "Desktop development with C++" workload
- MSBuild support for LLVM (clang-cl)
- C++ Clang Compiler for Windows (20.1.8)

CommandResult beforeResult after
.\vcbuildstarts using 2026starts using 2026
.\vcbuild vs2022fails to startstarts using 2022
.\vcbuild vs2026starts using 2026starts using 2026

Edit: fixed
@StefanStojanovicThere's a misplaced comma in your original post, as it sounds like VS2026 support was added by accident.

@StefanStojanovic

StefanStojanovic commented Jan 27, 2026

Copy link
Copy Markdown
ContributorAuthor

@StefanStojanovic There's a misplaced comma in your original post, as it sounds like VS2026 support was added by accident.

You are right, I haven't noticed that. It is changed now.

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71065/

@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71083/

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2026
@MikeMcC399MikeMcC399 mentioned this pull request Jan 28, 2026
Closed
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 5a8864d into nodejs:mainJan 28, 2026
67 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

Landed in 5a8864d

aduh95 pushed a commit that referenced this pull request Jan 28, 2026
@StefanStojanovic@aduh95
build,win: fix vs2022 compilation
fb7868b
PR-URL: #61530
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actionsgithub-actionsBot mentioned this pull request Feb 2, 2026
Merged
This was referenced Feb 5, 2026
Closed
Merged
This was referenced Feb 15, 2026
Closed
Merged
MikeMcC399 pushed a commit to MikeMcC399/node that referenced this pull request Feb 23, 2026
@StefanStojanovic@MikeMcC399
build,win: fix vs2022 compilation
800ab9b
PR-URL: nodejs#61530
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95 pushed a commit that referenced this pull request Feb 23, 2026
@StefanStojanovic@aduh95
build,win: fix vs2022 compilation
6a4511b
PR-URL: #61530
Backport-PR-URL: #61840
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95aduh95 mentioned this pull request Feb 24, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@StefanStojanovic@MikeMcC399@nodejs-github-bot@lpinca@targos@cjihrig@richardlau