Skip to content

build: add --shared-lief configure flag - #61536

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:shared-lief
Jan 28, 2026
Merged

build: add --shared-lief configure flag#61536
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:shared-lief

Conversation

@aduh95

@aduh95aduh95 commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-bot

nodejs-github-bot commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jan 26, 2026
aduh95
aduh95 commented Jan 26, 2026
View reviewed changes
Comment threadconfigure.py Outdated
@codecov

codecovBot commented Jan 26, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.91%. Comparing base (6cc2ed5) to head (ca3d4e0).
⚠️ Report is 451 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #61536 +/- ##
==========================================
- Coverage 89.77% 88.91% -0.87% 
==========================================
Files 673 673 Lines 203820 203820 Branches 39186 39102 -84 ==========================================
- Hits 182982 181224 -1758 - Misses 13155 14878 +1723 - Partials 7683 7718 +35

see 108 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71064/

@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71070/

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 27, 2026
@aduh95aduh95 added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jan 27, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 28, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/61536
✔ Done loading data for nodejs/node/pull/61536
----------------------------------- PR info ------------------------------------
Title build: add `--shared-lief` configure flag (#61536)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch aduh95:shared-lief -> nodejs:main
Labels build, meta, tools, author ready, needs-ci, commit-queue-squash, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x
Commits 2
- build: add `--shared-lief` configure flag
- Update configure.py
Committers 2
- Antoine du Hamel <duhamelantoine1995@gmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/61536
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61536
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Mon, 26 Jan 2026 20:19:05 GMT
✔ Approvals: 3
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/61536#pullrequestreview-3711758870
✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61536#pullrequestreview-3711915227
✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/61536#pullrequestreview-3713284258
⚠ This PR has conflicts that must be resolved
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-01-27T15:05:38Z: https://ci.nodejs.org/job/node-test-pull-request/71070/
- Querying data for job/node-test-pull-request/71070/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/21454260878

@aduh95
build: add --shared-lief configure flag
ca3d4e0
PR-URL: nodejs#61536
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@aduh95

aduh95 commented Jan 28, 2026

Copy link
Copy Markdown
ContributorAuthor

Landed in ca3d4e0

@aduh95
aduh95 merged commit ca3d4e0 into nodejs:mainJan 28, 2026
19 of 20 checks passed
@aduh95
aduh95 deleted the shared-lief branch January 28, 2026 23:50
aduh95 added a commit that referenced this pull request Feb 2, 2026
@aduh95
build: add --shared-lief configure flag
64194fd
PR-URL: #61536
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Feb 2, 2026
Merged
aduh95 added a commit that referenced this pull request Feb 2, 2026
@aduh95
build: add --shared-lief configure flag
b2fb829
PR-URL: #61536
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@aduh95aduh95 removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Mar 11, 2026
aduh95 added a commit to himself65/node that referenced this pull request Mar 11, 2026
@aduh95
build: add --shared-lief configure flag
99b98d7
PR-URL: nodejs#61536
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@aduh95aduh95 mentioned this pull request Apr 3, 2026
Draft
@aduh95aduh95 added the backport-open-v24.x Indicate that the PR has an open backport label Apr 3, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backport-open-v24.xIndicate that the PR has an open backportbuildIssues and PRs related to build files or the CI.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.metaIssues and PRs related to the general management of the project.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@nodejs-github-bot@cjihrig@joyeecheung@legendecas