Skip to content

test_runner: fix passing expectFailure - #61568

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-passing-expect-failure
Jan 30, 2026
Merged

test_runner: fix passing expectFailure#61568
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-passing-expect-failure

Conversation

@MoLow

@MoLowMoLow commented Jan 28, 2026

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jan 28, 2026
JakobJingleheimer
JakobJingleheimer approved these changes Jan 28, 2026
View reviewed changes

@JakobJingleheimerJakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, how did I miss this before 😵‍💫

🙌

@MoLow

MoLow commented Jan 28, 2026

Copy link
Copy Markdown
MemberAuthor

Oh wow, how did I miss this before 😵‍💫

All new experimental features evolve one way or another 🫶🏼

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 28, 2026
@MoLow
MoLowforce-pushed the fix-passing-expect-failure branch 2 times, most recently from d8d31da to 4c510a4CompareJanuary 28, 2026 17:57
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71107/

@MoLow
MoLowforce-pushed the fix-passing-expect-failure branch from 4c510a4 to 81d55bfCompareJanuary 28, 2026 18:04
@MoLow

MoLow commented Jan 28, 2026

Copy link
Copy Markdown
MemberAuthor

@aduh95 thanks for the fast approvals. I changed the behavior a bit to better play when both skip and expectFailure are set

@MoLow
MoLow requested a review from aduh95January 28, 2026 18:15
@codecov

codecovBot commented Jan 28, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (79ddd1b) to head (81d55bf).
⚠️ Report is 113 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #61568 +/- ##
==========================================
+ Coverage 88.53% 89.77% +1.23% 
==========================================
Files 704 673 -31 Lines 208876 203829 -5047 Branches 40330 39173 -1157 ==========================================
- Hits 184937 182980 -1957 + Misses 15922 13179 -2743 + Partials 8017 7670 -347
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js97.32% <100.00%> (+0.01%)⬆️

... and 138 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71112/

@nodejs-github-bot

nodejs-github-bot commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71114/

@nodejs-github-bot

nodejs-github-bot commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71117/

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2026
@atlowChemi

atlowChemi commented Jan 29, 2026

Copy link
Copy Markdown
Member

@MoLow should there also be a new test with both skip & expectFailure, or do such tests exist?

@ljharb

ljharb commented Jan 29, 2026

Copy link
Copy Markdown
Member

a test that confirms that skip takes precedence over expectFailure would be valuable, but could be done in another PR too imo

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 30, 2026
@nodejs-github-bot
nodejs-github-bot merged commit ea83d32 into nodejs:mainJan 30, 2026
66 of 67 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

Landed in ea83d32

@MoLow
MoLow deleted the fix-passing-expect-failure branch February 1, 2026 07:43
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
@MoLow@aduh95
test_runner: fix passing expectFailure
ac3f6a6
PR-URL: #61568
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
@MoLow@aduh95
test_runner: fix passing expectFailure
fd8be14
PR-URL: #61568
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 10, 2026
@MoLow@aduh95
test_runner: fix passing expectFailure
a315792
PR-URL: #61568
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 14, 2026
@MoLow@aduh95
test_runner: fix passing expectFailure
2f6b136
PR-URL: #61568
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Feb 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 22, 2026
@MoLow@aduh95
test_runner: fix passing expectFailure
6a4de69
PR-URL: #61568
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb approved these changes
@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes
@jakecastellijakecastellijakecastelli approved these changes
@pmarchinipmarchinipmarchini approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes
@aduh95aduh95Awaiting requested review from aduh95

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@MoLow@nodejs-github-bot@atlowChemi@ljharb@JakobJingleheimer@aduh95@jakecastelli@pmarchini