Skip to content

doc: reorganize platform list - #61569

Open
kleisauke wants to merge 5 commits into
nodejs:mainfrom
kleisauke:alpine-versions
Open

doc: reorganize platform list#61569
kleisauke wants to merge 5 commits into
nodejs:mainfrom
kleisauke:alpine-versions

Conversation

@kleisauke

@kleisaukekleisauke commented Jan 28, 2026•
edited
Loading

Copy link
Copy Markdown

See the individual commits for more details.

@nodejs-github-bot

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jan 28, 2026
@kleisaukekleisauke mentioned this pull request Jan 28, 2026
Closed
sxa
sxa reviewed Jan 30, 2026
View reviewed changes

@sxasxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a possible follow-up, we could also mention the musl-based Linux arm64 binaries

+1 to this since we're now building it so it's as experimental as some of the others in the table.

Commenting as opposed to approving/rejecting as I'd like to see the arm64 change in but I won't block if you want to do it separately :-)

@kleisaukekleisauke mentioned this pull request Jan 30, 2026
Draft
@kleisauke

kleisauke commented Jan 30, 2026

Copy link
Copy Markdown
Author

@sxa I just opened PR #61589 to include the musl-based Linux arm64 binaries into the platform list.

sxa
sxa approved these changes Jan 30, 2026
View reviewed changes
@legendecas

legendecas commented Jan 30, 2026

Copy link
Copy Markdown
Member

Is https://github.com/nodejs/unofficial-builds/blob/main/recipes/musl/Dockerfile used for every active release lines (v20.x, v22.x, v24.x, v25.x)?

@kleisauke

kleisauke commented Mar 2, 2026

Copy link
Copy Markdown
Author

Is https://github.com/nodejs/unofficial-builds/blob/main/recipes/musl/Dockerfile used for every active release lines (v20.x, v22.x, v24.x, v25.x)?

I believe so. Given that commit nodejs/unofficial-builds@d8eaee5 landed on May 6, 2024, the binaries built with Alpine 3.19 likely correspond to the version range: ^20.13.0 || ^22.2.0 || >=24.0.0.

@richardlau

richardlau commented Mar 2, 2026

Copy link
Copy Markdown
Member

This part of the doc doesn't refer to compatibility of the unofficial binaries -- it is supposed to indicate compatibility in general for that platform (e.g. building from source yourself). They are most likely best guesses because I don't think anyone has tried to extensively test Node.js against kernel versions.

The requirements to run the official binaries are in the "Official binary platforms and toolchains" section. There is no section for unofficial builds, and I would block any addition/mention of unofficial builds to BUILDING.md (as unofficial builds are unofficial).

@kleisaukekleisauke changed the title doc: update kernel and musl reqs for Alpinedoc: reorganize platform listMar 2, 2026
richardlau
richardlau requested changes Mar 2, 2026
View reviewed changes
Comment threadBUILDING.md Outdated
Comment on lines +165 to +167
[^5]: Older kernel or libc versions may work. The minimum versions listed here
correspond to the binaries provided by the
[unofficial-builds project](https://github.com/nodejs/unofficial-builds).

@richardlaurichardlauMar 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1 on mentioning unofficial-builds in this document. We do not want people relying on them.

@kleisaukekleisaukeMar 2, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. The mention has been removed.

@richardlaurichardlau added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Mar 2, 2026
@kleisauke

kleisauke commented Apr 13, 2026

Copy link
Copy Markdown
Author

Rebased to fix conflicts and added commit f42251143360e708251fad5c0a62d65f16694d85.

@kleisauke

kleisauke commented May 6, 2026

Copy link
Copy Markdown
Author

Rebased to fix conflicts and dropped commit 8952b79ec9a396d6bc2fcd4addd198a493aaacee (as armv6 has been removed with commit f4c50a8).

@kleisauke

kleisauke commented May 23, 2026

Copy link
Copy Markdown
Author

Rebased to fix conflicts.

@kleisauke

kleisauke commented Jun 26, 2026

Copy link
Copy Markdown
Author

Rebased again to fix conflicts. Please let me know if anything else is needed from my side.

aduh95
aduh95 reviewed Jun 26, 2026
View reviewed changes
Comment threadBUILDING.md Outdated
@@ -147,14 +161,16 @@ platforms. This is true regardless of entries in the table below.
[^4]: Our macOS Binaries are compiled with 13.5 as a target. Xcode 16 is
required to compile.

[^5]: Native riscv64 builds need GCC >= 14 or Clang >= 19 because V8
[^5]: Older kernel or libc versions may work.

@aduh95aduh95Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use 5 if it's already used, that creates needless friction in the form of conflicts

@kleisaukekleisaukeJun 26, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I thought it would be neater to renumber these, but that would indeed cause unnecessary churn.

@kleisaukekleisauke mentioned this pull request Jul 28, 2026
Open
mcollina
mcollina approved these changes Jul 29, 2026
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina

mcollina commented Jul 29, 2026

Copy link
Copy Markdown
Member

cc @nodejs/build

@kleisauke

kleisauke commented Aug 1, 2026

Copy link
Copy Markdown
Author

Amended commit b61ffda with f1b4491 since the Alpine base image was updated to 3.23 in commit nodejs/unofficial-builds@2069ad0.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 left review comments
@mcollinamcollinamcollina approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@sxasxasxa approved these changes
@legendecaslegendecaslegendecas approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@gurgundaygurgundaygurgunday approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@kleisauke@nodejs-github-bot@legendecas@richardlau@mcollina@lpinca@anonrig@sxa@aduh95@RafaelGSS@gurgunday@targos