Skip to content

tools: lint new WPTRunner() paths for no duplicates - #61618

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:wpt-lint-new-wpt-runner
Closed

tools: lint new WPTRunner() paths for no duplicates#61618
panva wants to merge 1 commit into
nodejs:mainfrom
panva:wpt-lint-new-wpt-runner

Conversation

@panva

@panvapanva commented Feb 1, 2026

Copy link
Copy Markdown
Member

A lint rule to prevent future issues of duplicate wpt tests

Refs: #61617
Refs: #61316 (comment)

Local result:

➜ node git:(main) ✗ make lint-js Running JS linter...
/node/test/wpt/test-webidl.js
6:30 error WPTRunner path 'webidl' overlaps with 'webidl/ecmascript-binding/es-exceptions' in /node/test/wpt/test-domexception.js. One path is a subset of the other, which would run the same tests multiple times node-core/no-duplicate-wpt-runner-paths
✖ 1 problem (1 error, 0 warnings)

@panva
panva requested a review from aduh95February 1, 2026 16:14
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Feb 1, 2026
@panva

This comment was marked as outdated.

@panva
panva marked this pull request as ready for review February 4, 2026 10:35
@panva
panvaforce-pushed the wpt-lint-new-wpt-runner branch from 0d1b013 to 48d2bfeCompareFebruary 4, 2026 10:37
@codecov

codecovBot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (7bd2fea) to head (48d2bfe).
⚠️ Report is 251 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #61618 +/- ##
==========================================
- Coverage 89.74% 89.74% -0.01% 
==========================================
Files 674 674 Lines 204360 204360 Branches 39270 39273 +3 ==========================================
- Hits 183409 183403 -6 + Misses 13260 13256 -4 - Partials 7691 7701 +10 

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panvapanva closed this Mar 11, 2026
@panva
panva deleted the wpt-lint-new-wpt-runner branch March 20, 2026 15:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@panva@nodejs-github-bot