Skip to content

http2: invoke pending write callback on stream destroy#61821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 1 commit into from
Closed

http2: invoke pending write callback on stream destroy #61821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/internal/http2/core.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -253,6 +253,7 @@ const kOptions = Symbol('options');
const kOwner = owner_symbol;
const kOrigin = Symbol('origin');
const kPendingRequestCalls = Symbol('kPendingRequestCalls');
const kPendingWriteCb = Symbol('kPendingWriteCb');
const kProceed = Symbol('proceed');
const kRemoteSettings = Symbol('remote-settings');
const kRequestAsyncResource = Symbol('requestAsyncResource');
Expand DownExpand Up@@ -2276,10 +2277,13 @@ class Http2Stream extends Duplex {
cb(err);
};
const writeCallback = (err) => {
if (!waitingForWriteCallback) return;
this[kPendingWriteCb] = null;
waitingForWriteCallback = false;
writeCallbackErr = err;
done();
};
this[kPendingWriteCb] = writeCallback;
const endCheckCallback = (err) => {
waitingForEndCheck = false;
endCheckCallbackErr = err;
Expand DownExpand Up@@ -2445,6 +2449,12 @@ class Http2Stream extends Duplex {
closeStream(this, code, hasHandle ? kForceRstStream : kNoRstStream);
this.push(null);

const pendingWriteCb = this[kPendingWriteCb];
if (pendingWriteCb) {
this[kPendingWriteCb] = null;
pendingWriteCb(err);
}

if (hasHandle) {
handle.destroy();
sessionState.streams.delete(id);
Expand Down
Loading