Skip to content

test: increase debugger waitFor timeout on macOS and Windows - #61902

Closed
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:fix-flaky-debugger-restart-message
Closed

test: increase debugger waitFor timeout on macOS and Windows#61902
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:fix-flaky-debugger-restart-message

Conversation

@mcollina

@mcollinamcollina commented Feb 20, 2026

Copy link
Copy Markdown
Member

Summary

  • Increase the macOS/Windows debugger test timeout from 15s to 30s

The test-debugger-restart-message test is flaky on macOS CI. The Debugger.on('paused') handler in the inspect REPL prints the "break in" message only after an async Debugger.getScriptSource CDP round-trip to V8 completes. On loaded macOS CI machines, this round-trip can exceed the 15s timeout.

The timeout has already been bumped twice (5s→10s in #56970, 10s→15s for macOS in #60367). platformTimeout() applies no multiplier for macOS, so the raw ms value is the actual timeout. Doubling to 30s provides adequate headroom.

Test plan

  • test-debugger-restart-message passes locally
  • CI passes on macOS

The test-debugger-restart-message test is flaky on macOS CI because the
Debugger.getScriptSource CDP round-trip in the initial break handler
can be slow under CI load, causing the 15s timeout to be exceeded.
Increase the macOS/Windows timeout from 15s to 30s to provide adequate
headroom.
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 20, 2026
@codecov

codecovBot commented Feb 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (ae2ffce) to head (bc6562f).
⚠️ Report is 293 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #61902 +/- ##
==========================================
+ Coverage 89.75% 89.77% +0.01% 
==========================================
Files 674 674 Lines 204416 204886 +470 Branches 39285 39377 +92 ==========================================
+ Hits 183472 183929 +457 
Misses 13227 13227 - Partials 7717 7730 +13 

see 78 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@mcollinamcollina added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 20, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@lpinca

Copy link
Copy Markdown
Member

I don't think increasing the timeout solves the underlying issue. IIRC we already did in the past. #61773 might be a proper fix. I haven't approved it yet because I haven't thoroughly reviewed it.

cc: @inoway46

@inoway46

inoway46 commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

Thanks for the mention.

If helpful, I'll run additional local verification on my PR side (A/B against main under unusual-path conditions) and share the results to confirm whether it addresses the issue.

CI for my PR is now running as well, so that may help confirm whether the flake still reproduces.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@mcollina@nodejs-github-bot@lpinca@inoway46@cjihrig@legendecas@StefanStojanovic