test,repl: use deepStrictEqual for false-y values

[Fishrock123]

Checklist

• tests and code linting passes
• the commit message follows commit guidelines

Affected core subsystem(s)

doc,repl

Description of change

Refs: 0b66b8f#commitcomment-17104918, #6192

... Should we just change this throughout all of our testes, except the assert ones themselves?

As a note, I'm not sure how much it matters for this test, but testing false-y values with deepEqual() can easily miss problems.

cc @nodejs/testing

[cjihrig]

LGTM. And yes, IMO we should make all of the assertions as strict as practical to avoid surprises.

[Fishrock123]

And yes, IMO we should make all of the assertions as strict as practical to avoid surprises.

We could make a lint rule that requires strict assertions for the tests, but I feel people may be opposed to that?

[addaleax]

Oh, yeah, sorry, I just copied from the already-present test. But this sounds good to me, too.

[Trott]

LGTM.

@Fishrock123 I have a lint rule written and will submit a PR soon. We'll find out if there's opposition or not...

[jasnell]

LGTM

[JungMinu]

LGTM

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/2300/

[jasnell]

Landed in 15d970d

[Fishrock123]

@jasnell Please avoid landing other collaborator's stuff. I don't think this PR/commit is worthwhile in light of the discussion, thanks.

[jasnell]

@Fishrock123 ... just following the same process I do for everything (and the same process I will continue to follow). There were multiple LGTM's, no obvious indication that it shouldn't land, and green CI. If this is something that you feel should be reverted, please feel free to open a PR reverting it.

Suggestion: we do have an in-progress label. If you feel that one of your PRs is not yet ready to land, attach the in-progress (or an appropriate don't land) label to it and I will skip over it when I'm going through and triaging issues.

[Fishrock123]

Historically, for a long time, we have mostly avoided merging other collaborators PRs unless they are npm upgrades, or critical fixes of some sort.

I see that is not stated in our resources and am going to make amends to those.

If this is something that you feel should be reverted, please feel free to open a PR reverting it.

In this case, it's just unnecessary git history. (And personally, as the author of this commit, slightly non-sensical in hindsight.)