Skip to content

buffer: remove unused param from copyActual - #62042

Closed
gurgunday wants to merge 1 commit into
nodejs:mainfrom
gurgunday:remove-unused
Closed

buffer: remove unused param from copyActual#62042
gurgunday wants to merge 1 commit into
nodejs:mainfrom
gurgunday:remove-unused

Conversation

@gurgunday

Copy link
Copy Markdown
Member

Follow up to #61721

We added this quirky parameter in #60399 when implementing an optimization to Buffer.concat and Buffer.copy with the intention of eventually removing it when .concat used TypedArrayPrototypeSet in all cases

The parameter was only used in one place until it was removed in #61721:

https://github.com/nodejs/node/pull/61721/changes#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630L635

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Feb 28, 2026
@richardlau

Copy link
Copy Markdown
Member

This change is being made as part of #62032.

@codecov

codecovBot commented Feb 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (6a3d358) to head (ce5f8c4).
⚠️ Report is 594 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #62042 +/- ##
==========================================
+ Coverage 89.58% 89.64% +0.06% 
==========================================
Files 674 676 +2 Lines 205159 206240 +1081 Branches 39352 39506 +154 ==========================================
+ Hits 183792 184894 +1102 + Misses 13583 13465 -118 - Partials 7784 7881 +97 
Files with missing linesCoverage Δ
lib/buffer.js99.16% <100.00%> (ø)

... and 129 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gurgunday

Copy link
Copy Markdown
MemberAuthor

@richardlau PTAL, that PR is closed for now

@gurgundaygurgunday added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2026
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor
Failed to start CI
 ⚠ No approving reviews found
✘ Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/22575987214

@gurgunday

Copy link
Copy Markdown
MemberAuthor

Cc @ChALkeR maybe for a review

@gurgundaygurgunday removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Mar 8, 2026
@gurgundaygurgunday added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 26, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@trivikrtrivikr removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 26, 2026
@trivikr

Copy link
Copy Markdown
Member

@gurgunday Can you please resolve conflicts and force push?

@gurgunday

Copy link
Copy Markdown
MemberAuthor

It's resolved

@gurgunday
gurgunday deleted the remove-unused branch July 27, 2026 18:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bufferIssues and PRs related to the buffer subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gurgunday@richardlau@nodejs-github-bot@trivikr@ChALkeR