Skip to content

src: remove redundant experimental_transform_types from node_options.h - #62058

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ShenHongFei:fix-redundant-transform-types
Mar 3, 2026
Merged

src: remove redundant experimental_transform_types from node_options.h#62058
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ShenHongFei:fix-redundant-transform-types

Conversation

@ShenHongFei

Copy link
Copy Markdown
Contributor

#61803 removed --experimental-transform-types

There is still one related attribute in node_options.h that has not been removed.

@marco-ippolito

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Mar 1, 2026
@codecov

codecovBot commented Mar 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (6a3d358) to head (340575f).
⚠️ Report is 106 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #62058 +/- ##
==========================================
+ Coverage 89.58% 89.65% +0.07% 
==========================================
Files 674 676 +2 Lines 205159 206239 +1080 Branches 39352 39496 +144 ==========================================
+ Hits 183792 184908 +1116 + Misses 13583 13460 -123 - Partials 7784 7871 +87 
Files with missing linesCoverage Δ
src/node_options.h97.93% <ø> (+0.03%)⬆️

... and 123 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334Renegade334 added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Mar 1, 2026
@Renegade334Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 1, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2026
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@Renegade334Renegade334 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2026
@addaleaxaddaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 3, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 2422ed8 into nodejs:mainMar 3, 2026
99 of 100 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 2422ed8

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.configIssues or PRs related to the config subsystemdont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@ShenHongFei@nodejs-github-bot@addaleax@cjihrig@Renegade334@marco-ippolito@atlowChemi