Skip to content

doc: Add addaleax to collaborators - #6224

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:add-addaleax-to-collaborators
Closed

doc: Add addaleax to collaborators#6224
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:add-addaleax-to-collaborators

Conversation

@addaleax

@addaleaxaddaleax commented Apr 15, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add myself :)

@jasnell

jasnell commented Apr 15, 2016

Copy link
Copy Markdown
Member

+1 LGTM! /cc @Fishrock123

@jasnelljasnell added the meta Issues and PRs related to the general management of the project. label Apr 15, 2016
@addaleax
addaleaxforce-pushed the add-addaleax-to-collaborators branch from e1205da to 15e3998CompareApril 15, 2016 17:34
@evanlucas

evanlucas commented Apr 15, 2016

Copy link
Copy Markdown
Contributor

LGTM

Trott
Trott reviewed Apr 15, 2016
View reviewed changes
Comment threadREADME.md Outdated

@TrottTrottApr 15, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize by username. Thanks!

@addaleaxaddaleaxApr 15, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… updated. 😄

@Trott

Trott commented Apr 15, 2016

Copy link
Copy Markdown
Member

LGTM with nit.

@addaleax
addaleaxforce-pushed the add-addaleax-to-collaborators branch from 15e3998 to 7009bfdCompareApril 15, 2016 17:35
@bnoordhuis

bnoordhuis commented Apr 15, 2016

Copy link
Copy Markdown
Member

LGTM and welcome aboard, Anna.

@Trott

Trott commented Apr 15, 2016

Copy link
Copy Markdown
Member

LGTM!

:shipit:

@MylesBorins

MylesBorins commented Apr 15, 2016

Copy link
Copy Markdown
Contributor

LGTM... well deserved

🎉

addaleax added a commit that referenced this pull request Apr 15, 2016
@addaleax
doc: add addaleax to collaborators
69040d6
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@addaleax

addaleax commented Apr 15, 2016

Copy link
Copy Markdown
MemberAuthor

Landed in 69040d6! 🎉

@addaleax
addaleax deleted the add-addaleax-to-collaborators branch April 15, 2016 17:44
@Fishrock123

Fishrock123 commented Apr 15, 2016

Copy link
Copy Markdown
Contributor

🎉 🎉 🎉

@santigimeno

santigimeno commented Apr 15, 2016

Copy link
Copy Markdown
Member

Welcome!

MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@addaleaxMyles Borins
doc: add addaleax to collaborators
5c40fc1
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@addaleaxMyles Borins
doc: add addaleax to collaborators
bbd990f
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@addaleaxMyles Borins
doc: add addaleax to collaborators
93ff5de
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@addaleaxMyles Borins
doc: add addaleax to collaborators
976e4bb
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
@addaleax@MylesBorins
doc: add addaleax to collaborators
1427a5b
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
@addaleax@MylesBorins
doc: add addaleax to collaborators
3364703
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
@addaleax@joelostrowski
doc: add addaleax to collaborators
41ab1f2
PR-URL: nodejs#6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@addaleax@jasnell
doc: add addaleax to collaborators
8b5acd5
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
@addaleaxMyles Borins
doc: add addaleax to collaborators
a856545
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@addaleaxMyles Borins
doc: add addaleax to collaborators
ae3eb24
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@addaleaxMyles Borins
doc: add addaleax to collaborators
7a3c608
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax@jasnell@evanlucas@Trott@bnoordhuis@MylesBorins@Fishrock123@santigimeno