Uh oh!
There was an error while loading. Please reload this page.
src: use simdutf for two-byte string utf8 conversion in utf8 value - #62248
Open
mertcanaltin wants to merge 2 commits into
Open
src: use simdutf for two-byte string utf8 conversion in utf8 value#62248mertcanaltin wants to merge 2 commits into
mertcanaltin wants to merge 2 commits into
Conversation
nodejs-github-bot
commented
Mar 14, 2026
Collaborator
Review requested:
|
mertcanaltinforce-pushed
the
mert/use-simdutf-for-two-byte-utf8
branch
from
March 14, 2026 08:31
f6d6f82 to
d459594CompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #62248 +/- ##
==========================================
+ Coverage 89.67% 89.68% +0.01%
==========================================
Files 676 676 Lines 206469 206700 +231 Branches 39537 39584 +47 ==========================================
+ Hits 185157 185388 +231 + Misses 13448 13441 -7 - Partials 7864 7871 +7
🚀 New features to boost your workflow:
|
lemire
reviewed
Mar 14, 2026
Uh oh!
There was an error while loading. Please reload this page.
mertcanaltinforce-pushed
the
mert/use-simdutf-for-two-byte-utf8
branch
4 times, most recently
from
March 14, 2026 17:12
b8cc5e8 to
dcbf493Comparemertcanaltinforce-pushed
the
mert/use-simdutf-for-two-byte-utf8
branch
from
March 14, 2026 17:12
dcbf493 to
fb16b2dComparelemire
reviewed
Mar 22, 2026
Uh oh!
There was an error while loading. Please reload this page.
gurgunday
approved these changes
Mar 22, 2026
nodejs-github-bot
commented
Apr 9, 2026
Collaborator
Contributor
This pull request has been marked as stale due to 90 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
latin-1 already used simdutf #61696,
I changed WriteUtf8V2 to simdutf for two-byte strings.