Uh oh!
There was an error while loading. Please reload this page.
test_runner: match coverage globs against cwd-relative paths - #62362
test_runner: match coverage globs against cwd-relative paths#62362ace-tk wants to merge 1 commit into
Conversation
Avoid applying coverage include/exclude glob checks to absolute paths so projects under directories named like test/ are not accidentally excluded. Add a regression test for cwd paths containing test. Made-with: Cursor
nodejs-github-bot
commented
Mar 21, 2026
Review requested:
|
avivkeller
commented
Mar 21, 2026
Ref on why this approach was chosen originally (by me): #53553 (comment) |
ace-tk
commented
Mar 21, 2026
My goal was to prevent unexpected exclusions caused by absolute parent paths containing |
avivkeller
commented
Mar 21, 2026
cc @nodejs/test_runner |
ace-tk
commented
Mar 21, 2026
@avivkeller Thanks for the context and for cc-ing @nodejs/test_runner. My intent was to avoid surprising exclusions when absolute parent paths contain |
This pull request has been marked as stale due to 90 days of inactivity. |
Summary
testcwdcontaining atestdirectory segmentTest plan
python3 tools/test.py test/parallel/test-runner-coverage-default-exclusion.mjsCloses: #58654