Uh oh!
There was an error while loading. Please reload this page.
deps: update nghttp2 to 1.68.1 - #62381
Conversation
nodejs-github-bot
commented
Mar 22, 2026
Review requested:
|
b92a238 to
0b14648Comparenodejs-github-bot
commented
Mar 30, 2026
nodejs-github-bot
commented
Mar 30, 2026
nodejs-github-bot
commented
Mar 30, 2026
326292c to
4a520cdComparetrivikr
commented
Apr 5, 2026
This requires reverting a change was causes CI failures Example revert in previous PR: 1ab2794 |
mcollina
commented
Apr 5, 2026
@trivikr I'm lost. |
trivikr
commented
Apr 5, 2026
The commit nghttp2/nghttp2@7784fa9 published in nghttp@1.67.0 have been breaking CI tests in Node.js Antoine documented it in #60661, and we've been reverting that commit when upgrading nghttp2. |
I'm going to look into the upstream nghttp2 issue here and see if I can find a proper solution, watch this space. EDIT: See nghttp2/nghttp2#2604 (comment) |
4a520cd to
125cac6Comparemcollina
commented
Apr 12, 2026
Unless those can be fixed/reverted upstream, we would have to update the test. |
125cac6 to
41c1b65CompareKangie
commented
Apr 19, 2026
This is unreasonable on downstreams using unbundled nghttp2. Please just fix the code here - your tests are failing for a reason. |
pimterry
commented
Apr 20, 2026
Hi @Kangie - I appreciate the input and challenges here, but that's not so simple. This is an actual incompatibility that creates breaking changes in Node.js http2 when using nghttp2 1.67 & 1.68. I'm not sure how you can best manage this in unbundled environments, but we can't include unexpected breaking changes like that in official releases. Fortunately, there's been more discussion in nghttp2/nghttp2#2604, and the key nghttp2 changes have now been reverted in 1.69. For some other remaining changes we'll still need updates here in Node.js to release, but more limited in scope. nghttp2 1.69.0 was just released yesterday with this, I'm aiming to test & integrate that today or tomorrow to resolve this and open a new PR. I'll update here once there's progress. |
pimterry
commented
Apr 21, 2026
I've opened a new PR with an update to 1.69.0 and the corresponding fixes required: #62867. I'll close this now since that replaces this bump. |
This is an automated update of nghttp2 to 1.68.1.