buffer: add end parameter

[ronag]

To limit how far into the buffer we search without allocating an unnecessary subarray.

[mcollina]

lgtm

[mcollina]

CI does not seem happy

[codecov]

Codecov Report

❌ Patch coverage is 86.13861% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (bf1aebc) to head (fd6b746).
⚠️ Report is 214 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_buffer.cc	70.83%	4 Missing and 10 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #62390 +/- ##
==========================================
+ Coverage 89.72% 89.80% +0.08% 
==========================================
Files 695 699 +4 Lines 214464 216422 +1958 Branches 41067 41384 +317 ==========================================
+ Hits 192420 194360 +1940 - Misses 14106 14146 +40 + Partials 7938 7916 -22 

Files with missing lines	Coverage Δ
lib/buffer.js	99.18% <100.00%> (+0.01%)	⬆️
src/node_buffer.cc	68.03% <70.83%> (-0.17%)	⬇️

... and 82 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jasnell]

When we start getting into new optional arguments in the middle like this I think we should consider an alternative signature with an options bag instead...

buf.includes(value,{byteOffset: 0,end: 10,encoding: 'utf8',});

[ronag]

follow up PR?

[github-actions]

Failed to start CI

 ⚠ Commits were pushed since the last approving review:
⚠ - buffer: add end parameter
✘ Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/23542726197

[aduh95]

There's a conflict to solve

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/62390
✔ Done loading data for nodejs/node/pull/62390
----------------------------------- PR info ------------------------------------
Title buffer: add end parameter (#62390)
Author Robert Nagy <ronagy@icloud.com> (@ronag)
Branch ronag:buffer-index-of-end -> nodejs:main
Labels buffer, c++, semver-minor, author ready, needs-ci, review wanted
Commits 1
- buffer: add end parameter
Committers 1
- Robert Nagy <ronagy@icloud.com>
PR-URL: https://github.com/nodejs/node/pull/62390
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62390
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 22 Mar 2026 09:53:58 GMT
✔ Approvals: 2
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/62390#pullrequestreview-4067847074
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/62390#pullrequestreview-4092335147
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-04-11T10:37:41Z: https://ci.nodejs.org/job/node-test-pull-request/72624/
⚠ Commits were pushed after the last Full PR CI run:
⚠ - buffer: add end parameter
- Querying data for job/node-test-pull-request/72624/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/24286987028

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/72639/

[nodejs-github-bot]

Landed in f2fda60

[ChALkeR]

Security: This should not land on a release without a fix for #62873

[ChALkeR]

Adding dont-land-on-* as a temporary precaution, can be removed once #62873 is fixed.

Upd: dont-land-on-* can be removed once this PR lands:

• buffer: fix end parameter bugs in indexOf/lastIndexOf #62711

[ronag]

Fixed by #62711