tools: alignment of variable assignments that span multiple lines

[Trott]

Checklist

• tests and code linting passes
• the commit message follows commit guidelines

Affected core subsystem(s)

tools, test, lib

Description of change

Since I always mess up the alignment in variable assignments, forcing
@bnoordhuis to provide nits for my pull requests, let's have a lint rule
so that I can be told by the linter instead.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/2287/

[Trott]

CI is green except for that pesky test-http-agent test.

[bnoordhuis]

You could make these const while you're here. Just a suggestion, though.

EDIT: OTOH, that's mixing disparate changes. Feel free to disregard.

[bnoordhuis]

Nice. LGTM.

[mscdex]

s/testDecleration/testDeclaration/

[jbergstroem]

LGTM

[jasnell]

LGTM

[jasnell]

Fixing the type @mscdex points out on landing...

[jasnell]

Landed in 3160073 and ca69833

[mscdex]

@Trott This change is causing linter issues due to the use of the default parameters. For example:

/usr/home/iojs/build/workspace/node-test-linter/tools/eslint-rules/align-multiline-assignment.js:10
function getBinaryExpressionStarts(binaryExpression, starts = []) {
^
SyntaxError: Unexpected token =
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:387:25)
at Object.Module._extensions..js (module.js:422:10)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)
at Module.require (module.js:367:17)
at require (internal/module.js:16:19)
at Object.get (/usr/home/iojs/build/workspace/node-test-linter/tools/eslint/lib/rules.js:70:16)
at getRuleOptionsSchema (/usr/home/iojs/build/workspace/node-test-linter/tools/eslint/lib/config/config-validator.js:33:22)
at validateRuleOptions (/usr/home/iojs/build/workspace/node-test-linter/tools/eslint/lib/config/config-validator.js:70:18)

[Trott]

That's weird. Default parameters are in the current node and presumably that CI is using current master with the current version of v8 that we have in master...

[Trott]

@mscdex Looks like the a problem might be in the lint-ci job. If I introduce a lint error into the code, make jslint runs fine, but make lint-ci returns no errors and exits with a successful code.

[silverwind]

@Trott I also see it locally, even when running eslint directly:

$ node tools/eslint/bin/eslint.js --rulesdir tools/eslint-rules test/doctool
Unexpected token =
SyntaxError: Unexpected token =
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:387:25)
at Object.Module._extensions..js (module.js:422:10)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)
at Module.require (module.js:367:17)
at require (internal/module.js:16:19)
at Object.get (/Users/silverwind/git/node/tools/eslint/lib/rules.js:70:16)
at getRuleOptionsSchema (/Users/silverwind/git/node/tools/eslint/lib/config/config-validator.js:33:22)
at validateRuleOptions (/Users/silverwind/git/node/tools/eslint/lib/config/config-validator.js:70:18)

Maybe it's an ESLint bug?

[silverwind]

Nevermind, my local node was not 6.0.0 yet, working now.

[Trott]

For the record, the issue is that the VM in CI that does linting uses the system Node.js rather than compiling it from source. It does this so that the linting will finish quickly. There's a PR in to back out the default parameter in our custom lint rule. When it lands, this will be a non-issue again.

[MylesBorins]

@Trott this will need to be manually backported

[Trott]

@thealphanerd Here you go: #6869