Skip to content

http: deprecate CRLF constant from _http_common - #62464

Closed
karan-lrn wants to merge 1 commit into
nodejs:mainfrom
karan-lrn:http-deprecate-crlf
Closed

http: deprecate CRLF constant from _http_common#62464
karan-lrn wants to merge 1 commit into
nodejs:mainfrom
karan-lrn:http-deprecate-crlf

Conversation

@karan-lrn

@karan-lrnkaran-lrn commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

The CRLF constant exported from '_http_common' is deprecated (DEP0206). Users should use the string '\r\n' directly instead.

This addresses the TODO comment added in #40101.

PR-URL: #62464

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net
  • @nodejs/userland-migrations

@nodejs-github-botnodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Mar 27, 2026
@karan-lrn
karan-lrnforce-pushed the http-deprecate-crlf branch 2 times, most recently from be7bf2a to 94c3e32CompareMarch 27, 2026 16:28
The CRLF constant exported from '_http_common' is deprecated (DEP0206).
Users should use the string '\r\n' directly instead.
This addresses the TODO comment added in nodejs#40101.
PR-URL: https://github.com/nodejs/node/pull/XXXXX
@codecov

codecovBot commented Mar 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (7d1f1b4) to head (ef880b8).

Additional details and impacted files
@@ Coverage Diff @@## main #62464 +/- ##
==========================================
+ Coverage 89.70% 89.71% +0.01% 
==========================================
Files 678 678 Lines 207260 207280 +20 Branches 39749 39749 ==========================================
+ Hits 185917 185963 +46 + Misses 13443 13427 -16 + Partials 7900 7890 -10 
Files with missing linesCoverage Δ
lib/_http_common.js100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't see what purpose this serves.

@karan-lrn

Copy link
Copy Markdown
ContributorAuthor

You're right - this doesn't provide much value. The CRLF constant is trivial and
_http_common is already an internal module. I'll close this PR.

Thanks for the review!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

httpIssues or PRs related to the http subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@karan-lrn@nodejs-github-bot@jasnell