Uh oh!
There was an error while loading. Please reload this page.
http: deprecate CRLF constant from _http_common - #62464
Closed
karan-lrn wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Mar 27, 2026
Collaborator
Review requested:
|
karan-lrnforce-pushed
the
http-deprecate-crlf
branch
2 times, most recently
from
March 27, 2026 16:28
be7bf2a to
94c3e32CompareThe CRLF constant exported from '_http_common' is deprecated (DEP0206). Users should use the string '\r\n' directly instead. This addresses the TODO comment added in nodejs#40101. PR-URL: https://github.com/nodejs/node/pull/XXXXX
karan-lrnforce-pushed
the
http-deprecate-crlf
branch
from
March 27, 2026 16:46
94c3e32 to
ef880b8CompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #62464 +/- ##
==========================================
+ Coverage 89.70% 89.71% +0.01%
==========================================
Files 678 678 Lines 207260 207280 +20 Branches 39749 39749 ==========================================
+ Hits 185917 185963 +46 + Misses 13443 13427 -16 + Partials 7900 7890 -10
🚀 New features to boost your workflow:
|
jasnell
requested changes
Mar 27, 2026
jasnell
left a comment
Member
There was a problem hiding this comment.
I really don't see what purpose this serves.
karan-lrn
commented
Mar 27, 2026
ContributorAuthor
You're right - this doesn't provide much value. The CRLF constant is trivial and Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CRLF constant exported from '_http_common' is deprecated (DEP0206). Users should use the string '\r\n' directly instead.
This addresses the TODO comment added in #40101.
PR-URL: #62464