Skip to content

test: wait for reattach before initial break on run - #62488

Closed
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:fix-run-flaky-test
Closed

test: wait for reattach before initial break on run#62488
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:fix-run-flaky-test

Conversation

@inoway46

@inoway46inoway46 commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #62471.

run and restart share the same implementation, so apply the same fix.

CI failed log: https://github.com/nodejs/node/actions/runs/23696220126

Refs: #61762

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 29, 2026
@inoway46
inoway46 marked this pull request as ready for review March 29, 2026 04:27
@codecov

codecovBot commented Mar 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (cc96741) to head (c05d7ae).
⚠️ Report is 180 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #62488 +/- ##
==========================================
- Coverage 91.55% 89.71% -1.85% 
==========================================
Files 351 692 +341 Lines 147653 213986 +66333 Branches 23224 41051 +17827 ==========================================
+ Hits 135179 191968 +56789 - Misses 12217 14090 +1873 - Partials 257 7928 +7671 

see 463 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@inoway46

Copy link
Copy Markdown
ContributorAuthor

Superseded by #62807
The previous Debugger attached./prompt sync point turned out to be too weak. Follow-up uses ok as the reconnect completion marker.

@inoway46
inoway46 deleted the fix-run-flaky-test branch April 19, 2026 04:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@inoway46@nodejs-github-bot@lpinca