crypto: allow password protected private keys with publicEncrypt

[calvinmetcalf]

Private keys may be used along with publicEncrypt since the private key includes
the public one. This adds the ability to use encrypted private keys which
previously threw an error.

[vkurchatkin]

it requires some documentation, doesn't it?

[calvinmetcalf]

#625 conflicts with this one as it rewrites these methods

[calvinmetcalf]

though this is allowing something slightly different

[calvinmetcalf]

rebased with updates to the docs and I make sure that the functions that get exposed to the user aren't anonymous.

[calvinmetcalf]

and I'm geting a jshint failure one sec

[bnoordhuis]

The rename makes the diff noisier than it needs to be.

[bnoordhuis]

Can you add a test that tests decryption with a bad password? What if password is a buffer, an array, etc.?

[calvinmetcalf]

yup can do

[indutny]

cc @iojs/crypto

[bnoordhuis]

Tiny style nit: space after comma.

[bnoordhuis]

LGTM assuming tests pass. I'm still not quite clear on why you renamed the methods.

[calvinmetcalf]

Oh sorry, I renamed them because I gave a name to the inner function and it
made sense to give it the name the outer function used.

On Sat, Jan 31, 2015, 5:12 AM Ben Noordhuis notifications@github.com
wrote:

LGTM assuming tests pass. I'm still not quite clear on why you renamed the
methods.

—
Reply to this email directly or view it on GitHub
#626 (comment).

[bnoordhuis]

Thanks Calvin, landed in 6561274 with minor changes (reworded/reformatted the commit log and backed out the function renaming, it made the functions show up as [Function: rsaPublic] or [Function: rsaPrivate] in the REPL.)