dgram: don't swallow bind errors when callback is provided by armanmikoyan · Pull Request #62602 · nodejs/node

armanmikoyan · 2026-04-05T16:25:32Z

dgram: don't swallow bind errors when callback is provided

When Socket.prototype.bind() is called with a callback, the internal
cleanup listener is registered on 'error', which counts as an error
handler and silently swallows bind errors (e.g. EADDRINUSE) when no
user error handler is attached.

This switches to EventEmitter.errorMonitor for the cleanup listener,
matching the pattern already used in the enqueue() function
(lib/dgram.js:571). This ensures bind errors properly propagate as
unhandled errors while still performing listener cleanup.

Setup — a socket already bound to port 5000

importdgramfrom'dgram';constreceiver=dgram.createSocket('udp4');receiver.bind({port: 5000,address: '127.0.0.1'});

No callback, no `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.on('listening',()=>{console.log('bound');});socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using callback — error silently swallowed (bug)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'},()=>{console.log('bound');},);// No error, no output — process hangs

All three examples do the same thing — bind to a port already in use.
The first two properly throw, but the third silently swallows the error
just because a callback was passed to bind().

After this fix, all three cases properly surface the error.

nodejs-github-bot · 2026-04-05T16:25:38Z

Review requested:

@nodejs/net

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com>

Ethan-Arrowood

This seems appropriate to me. Even if a fix, this is a notable change in behavior. I believe notable-change is warranted at least. I'm not sure about semver. I don't want to tag all of the TSC, but I'll see if http/net folks have any input as the dgram subsystem is relatively close to those.

Ethan-Arrowood · 2026-07-14T14:41:00Z

cc @nodejs/net @nodejs/http

mcollina

lgtm

mcollina · 2026-07-15T10:10:09Z

No, I think this is just a bug fix

nodejs-github-bot · 2026-07-15T10:31:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74830/

armanmikoyan · 2026-07-15T14:53:05Z

@mcollina I can't access the CI logs. Could someone let me know if the failures are related to my changes or just flaky? Happy to fix them if needed, or a re-run would be appreciated if they're unrelated.

Ethan-Arrowood · 2026-07-23T22:24:38Z

CI failure looks unrelated to me; its a sqlite-backup flake and some rebase infra issue.

nodejs-github-bot · 2026-08-22T22:31:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76251/

nodejs-github-bot · 2026-08-23T02:39:17Z

Landed in 97c7e32

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com> PR-URL: #62602 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

armanmikoyan · 2026-04-05T16:25:32Z

dgram: don't swallow bind errors when callback is provided

When Socket.prototype.bind() is called with a callback, the internal
cleanup listener is registered on 'error', which counts as an error
handler and silently swallows bind errors (e.g. EADDRINUSE) when no
user error handler is attached.

This switches to EventEmitter.errorMonitor for the cleanup listener,
matching the pattern already used in the enqueue() function
(lib/dgram.js:571). This ensures bind errors properly propagate as
unhandled errors while still performing listener cleanup.

Setup — a socket already bound to port 5000

importdgramfrom'dgram';constreceiver=dgram.createSocket('udp4');receiver.bind({port: 5000,address: '127.0.0.1'});

No callback, no `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.on('listening',()=>{console.log('bound');});socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using callback — error silently swallowed (bug)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'},()=>{console.log('bound');},);// No error, no output — process hangs

All three examples do the same thing — bind to a port already in use.
The first two properly throw, but the third silently swallows the error
just because a callback was passed to bind().

After this fix, all three cases properly surface the error.

nodejs-github-bot · 2026-04-05T16:25:38Z

Review requested:

@nodejs/net

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com>

Ethan-Arrowood

This seems appropriate to me. Even if a fix, this is a notable change in behavior. I believe notable-change is warranted at least. I'm not sure about semver. I don't want to tag all of the TSC, but I'll see if http/net folks have any input as the dgram subsystem is relatively close to those.

Ethan-Arrowood · 2026-07-14T14:41:00Z

cc @nodejs/net @nodejs/http

mcollina

lgtm

mcollina · 2026-07-15T10:10:09Z

No, I think this is just a bug fix

nodejs-github-bot · 2026-07-15T10:31:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74830/

armanmikoyan · 2026-07-15T14:53:05Z

@mcollina I can't access the CI logs. Could someone let me know if the failures are related to my changes or just flaky? Happy to fix them if needed, or a re-run would be appreciated if they're unrelated.

Ethan-Arrowood · 2026-07-23T22:24:38Z

CI failure looks unrelated to me; its a sqlite-backup flake and some rebase infra issue.

nodejs-github-bot · 2026-08-22T22:31:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76251/

nodejs-github-bot · 2026-08-23T02:39:17Z

Landed in 97c7e32

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com> PR-URL: #62602 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

armanmikoyan · 2026-04-05T16:25:32Z

dgram: don't swallow bind errors when callback is provided

When Socket.prototype.bind() is called with a callback, the internal
cleanup listener is registered on 'error', which counts as an error
handler and silently swallows bind errors (e.g. EADDRINUSE) when no
user error handler is attached.

This switches to EventEmitter.errorMonitor for the cleanup listener,
matching the pattern already used in the enqueue() function
(lib/dgram.js:571). This ensures bind errors properly propagate as
unhandled errors while still performing listener cleanup.

Setup — a socket already bound to port 5000

importdgramfrom'dgram';constreceiver=dgram.createSocket('udp4');receiver.bind({port: 5000,address: '127.0.0.1'});

No callback, no `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.on('listening',()=>{console.log('bound');});socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using callback — error silently swallowed (bug)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'},()=>{console.log('bound');},);// No error, no output — process hangs

All three examples do the same thing — bind to a port already in use.
The first two properly throw, but the third silently swallows the error
just because a callback was passed to bind().

After this fix, all three cases properly surface the error.

nodejs-github-bot · 2026-04-05T16:25:38Z

Review requested:

@nodejs/net

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com>

Ethan-Arrowood

This seems appropriate to me. Even if a fix, this is a notable change in behavior. I believe notable-change is warranted at least. I'm not sure about semver. I don't want to tag all of the TSC, but I'll see if http/net folks have any input as the dgram subsystem is relatively close to those.

Ethan-Arrowood · 2026-07-14T14:41:00Z

cc @nodejs/net @nodejs/http

mcollina

lgtm

mcollina · 2026-07-15T10:10:09Z

No, I think this is just a bug fix

nodejs-github-bot · 2026-07-15T10:31:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74830/

armanmikoyan · 2026-07-15T14:53:05Z

@mcollina I can't access the CI logs. Could someone let me know if the failures are related to my changes or just flaky? Happy to fix them if needed, or a re-run would be appreciated if they're unrelated.

Ethan-Arrowood · 2026-07-23T22:24:38Z

CI failure looks unrelated to me; its a sqlite-backup flake and some rebase infra issue.

nodejs-github-bot · 2026-08-22T22:31:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76251/

nodejs-github-bot · 2026-08-23T02:39:17Z

Landed in 97c7e32

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com> PR-URL: #62602 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

armanmikoyan · 2026-04-05T16:25:32Z

dgram: don't swallow bind errors when callback is provided

When Socket.prototype.bind() is called with a callback, the internal
cleanup listener is registered on 'error', which counts as an error
handler and silently swallows bind errors (e.g. EADDRINUSE) when no
user error handler is attached.

This switches to EventEmitter.errorMonitor for the cleanup listener,
matching the pattern already used in the enqueue() function
(lib/dgram.js:571). This ensures bind errors properly propagate as
unhandled errors while still performing listener cleanup.

Setup — a socket already bound to port 5000

importdgramfrom'dgram';constreceiver=dgram.createSocket('udp4');receiver.bind({port: 5000,address: '127.0.0.1'});

No callback, no `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.on('listening',()=>{console.log('bound');});socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using callback — error silently swallowed (bug)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'},()=>{console.log('bound');},);// No error, no output — process hangs

All three examples do the same thing — bind to a port already in use.
The first two properly throw, but the third silently swallows the error
just because a callback was passed to bind().

After this fix, all three cases properly surface the error.

nodejs-github-bot · 2026-04-05T16:25:38Z

Review requested:

@nodejs/net

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com>

Ethan-Arrowood

This seems appropriate to me. Even if a fix, this is a notable change in behavior. I believe notable-change is warranted at least. I'm not sure about semver. I don't want to tag all of the TSC, but I'll see if http/net folks have any input as the dgram subsystem is relatively close to those.

Ethan-Arrowood · 2026-07-14T14:41:00Z

cc @nodejs/net @nodejs/http

mcollina

lgtm

mcollina · 2026-07-15T10:10:09Z

No, I think this is just a bug fix

nodejs-github-bot · 2026-07-15T10:31:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74830/

armanmikoyan · 2026-07-15T14:53:05Z

@mcollina I can't access the CI logs. Could someone let me know if the failures are related to my changes or just flaky? Happy to fix them if needed, or a re-run would be appreciated if they're unrelated.

Ethan-Arrowood · 2026-07-23T22:24:38Z

CI failure looks unrelated to me; its a sqlite-backup flake and some rebase infra issue.

nodejs-github-bot · 2026-08-22T22:31:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76251/

nodejs-github-bot · 2026-08-23T02:39:17Z

Landed in 97c7e32

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com> PR-URL: #62602 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

armanmikoyan · 2026-04-05T16:25:32Z

dgram: don't swallow bind errors when callback is provided

When Socket.prototype.bind() is called with a callback, the internal
cleanup listener is registered on 'error', which counts as an error
handler and silently swallows bind errors (e.g. EADDRINUSE) when no
user error handler is attached.

This switches to EventEmitter.errorMonitor for the cleanup listener,
matching the pattern already used in the enqueue() function
(lib/dgram.js:571). This ensures bind errors properly propagate as
unhandled errors while still performing listener cleanup.

Setup — a socket already bound to port 5000

importdgramfrom'dgram';constreceiver=dgram.createSocket('udp4');receiver.bind({port: 5000,address: '127.0.0.1'});

No callback, no `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.on('listening',()=>{console.log('bound');});socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using callback — error silently swallowed (bug)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'},()=>{console.log('bound');},);// No error, no output — process hangs

All three examples do the same thing — bind to a port already in use.
The first two properly throw, but the third silently swallows the error
just because a callback was passed to bind().

After this fix, all three cases properly surface the error.

nodejs-github-bot · 2026-04-05T16:25:38Z

Review requested:

@nodejs/net

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com>

Ethan-Arrowood

This seems appropriate to me. Even if a fix, this is a notable change in behavior. I believe notable-change is warranted at least. I'm not sure about semver. I don't want to tag all of the TSC, but I'll see if http/net folks have any input as the dgram subsystem is relatively close to those.

Ethan-Arrowood · 2026-07-14T14:41:00Z

cc @nodejs/net @nodejs/http

mcollina

lgtm

mcollina · 2026-07-15T10:10:09Z

No, I think this is just a bug fix

nodejs-github-bot · 2026-07-15T10:31:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74830/

armanmikoyan · 2026-07-15T14:53:05Z

@mcollina I can't access the CI logs. Could someone let me know if the failures are related to my changes or just flaky? Happy to fix them if needed, or a re-run would be appreciated if they're unrelated.

Ethan-Arrowood · 2026-07-23T22:24:38Z

CI failure looks unrelated to me; its a sqlite-backup flake and some rebase infra issue.

nodejs-github-bot · 2026-08-22T22:31:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76251/

nodejs-github-bot · 2026-08-23T02:39:17Z

Landed in 97c7e32

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com> PR-URL: #62602 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

armanmikoyan · 2026-04-05T16:25:32Z

dgram: don't swallow bind errors when callback is provided

When Socket.prototype.bind() is called with a callback, the internal
cleanup listener is registered on 'error', which counts as an error
handler and silently swallows bind errors (e.g. EADDRINUSE) when no
user error handler is attached.

This switches to EventEmitter.errorMonitor for the cleanup listener,
matching the pattern already used in the enqueue() function
(lib/dgram.js:571). This ensures bind errors properly propagate as
unhandled errors while still performing listener cleanup.

Setup — a socket already bound to port 5000

importdgramfrom'dgram';constreceiver=dgram.createSocket('udp4');receiver.bind({port: 5000,address: '127.0.0.1'});

No callback, no `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.on('listening',()=>{console.log('bound');});socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using callback — error silently swallowed (bug)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'},()=>{console.log('bound');},);// No error, no output — process hangs

All three examples do the same thing — bind to a port already in use.
The first two properly throw, but the third silently swallows the error
just because a callback was passed to bind().

After this fix, all three cases properly surface the error.

nodejs-github-bot · 2026-04-05T16:25:38Z

Review requested:

@nodejs/net

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com>

Ethan-Arrowood

This seems appropriate to me. Even if a fix, this is a notable change in behavior. I believe notable-change is warranted at least. I'm not sure about semver. I don't want to tag all of the TSC, but I'll see if http/net folks have any input as the dgram subsystem is relatively close to those.

Ethan-Arrowood · 2026-07-14T14:41:00Z

cc @nodejs/net @nodejs/http

mcollina

lgtm

mcollina · 2026-07-15T10:10:09Z

No, I think this is just a bug fix

nodejs-github-bot · 2026-07-15T10:31:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74830/

armanmikoyan · 2026-07-15T14:53:05Z

@mcollina I can't access the CI logs. Could someone let me know if the failures are related to my changes or just flaky? Happy to fix them if needed, or a re-run would be appreciated if they're unrelated.

Ethan-Arrowood · 2026-07-23T22:24:38Z

CI failure looks unrelated to me; its a sqlite-backup flake and some rebase infra issue.

nodejs-github-bot · 2026-08-22T22:31:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76251/

nodejs-github-bot · 2026-08-23T02:39:17Z

Landed in 97c7e32

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com> PR-URL: #62602 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

armanmikoyan · 2026-04-05T16:25:32Z

dgram: don't swallow bind errors when callback is provided

When Socket.prototype.bind() is called with a callback, the internal
cleanup listener is registered on 'error', which counts as an error
handler and silently swallows bind errors (e.g. EADDRINUSE) when no
user error handler is attached.

This switches to EventEmitter.errorMonitor for the cleanup listener,
matching the pattern already used in the enqueue() function
(lib/dgram.js:571). This ensures bind errors properly propagate as
unhandled errors while still performing listener cleanup.

Setup — a socket already bound to port 5000

importdgramfrom'dgram';constreceiver=dgram.createSocket('udp4');receiver.bind({port: 5000,address: '127.0.0.1'});

No callback, no `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.on('listening',()=>{console.log('bound');});socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using callback — error silently swallowed (bug)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'},()=>{console.log('bound');},);// No error, no output — process hangs

All three examples do the same thing — bind to a port already in use.
The first two properly throw, but the third silently swallows the error
just because a callback was passed to bind().

After this fix, all three cases properly surface the error.

nodejs-github-bot · 2026-04-05T16:25:38Z

Review requested:

@nodejs/net

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com>

Ethan-Arrowood

This seems appropriate to me. Even if a fix, this is a notable change in behavior. I believe notable-change is warranted at least. I'm not sure about semver. I don't want to tag all of the TSC, but I'll see if http/net folks have any input as the dgram subsystem is relatively close to those.

Ethan-Arrowood · 2026-07-14T14:41:00Z

cc @nodejs/net @nodejs/http

mcollina

lgtm

mcollina · 2026-07-15T10:10:09Z

No, I think this is just a bug fix

nodejs-github-bot · 2026-07-15T10:31:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74830/

armanmikoyan · 2026-07-15T14:53:05Z

@mcollina I can't access the CI logs. Could someone let me know if the failures are related to my changes or just flaky? Happy to fix them if needed, or a re-run would be appreciated if they're unrelated.

Ethan-Arrowood · 2026-07-23T22:24:38Z

CI failure looks unrelated to me; its a sqlite-backup flake and some rebase infra issue.

nodejs-github-bot · 2026-08-22T22:31:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76251/

nodejs-github-bot · 2026-08-23T02:39:17Z

Landed in 97c7e32

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com> PR-URL: #62602 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

armanmikoyan · 2026-04-05T16:25:32Z

dgram: don't swallow bind errors when callback is provided

When Socket.prototype.bind() is called with a callback, the internal
cleanup listener is registered on 'error', which counts as an error
handler and silently swallows bind errors (e.g. EADDRINUSE) when no
user error handler is attached.

This switches to EventEmitter.errorMonitor for the cleanup listener,
matching the pattern already used in the enqueue() function
(lib/dgram.js:571). This ensures bind errors properly propagate as
unhandled errors while still performing listener cleanup.

Setup — a socket already bound to port 5000

importdgramfrom'dgram';constreceiver=dgram.createSocket('udp4');receiver.bind({port: 5000,address: '127.0.0.1'});

No callback, no `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using `listening` event — error surfaces (correct)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.on('listening',()=>{console.log('bound');});socket.bind({port: 5000,address: '127.0.0.1'});// Throws: Error: bind EADDRINUSE 127.0.0.1:5000

Using callback — error silently swallowed (bug)

importdgramfrom'dgram';constsocket=dgram.createSocket('udp4');socket.bind({port: 5000,address: '127.0.0.1'},()=>{console.log('bound');},);// No error, no output — process hangs

All three examples do the same thing — bind to a port already in use.
The first two properly throw, but the third silently swallows the error
just because a callback was passed to bind().

After this fix, all three cases properly surface the error.

nodejs-github-bot · 2026-04-05T16:25:38Z

Review requested:

@nodejs/net

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com>

Ethan-Arrowood

This seems appropriate to me. Even if a fix, this is a notable change in behavior. I believe notable-change is warranted at least. I'm not sure about semver. I don't want to tag all of the TSC, but I'll see if http/net folks have any input as the dgram subsystem is relatively close to those.

Ethan-Arrowood · 2026-07-14T14:41:00Z

cc @nodejs/net @nodejs/http

mcollina

lgtm

mcollina · 2026-07-15T10:10:09Z

No, I think this is just a bug fix

nodejs-github-bot · 2026-07-15T10:31:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74830/

armanmikoyan · 2026-07-15T14:53:05Z

@mcollina I can't access the CI logs. Could someone let me know if the failures are related to my changes or just flaky? Happy to fix them if needed, or a re-run would be appreciated if they're unrelated.

Ethan-Arrowood · 2026-07-23T22:24:38Z

CI failure looks unrelated to me; its a sqlite-backup flake and some rebase infra issue.

nodejs-github-bot · 2026-08-22T22:31:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76251/

nodejs-github-bot · 2026-08-23T02:39:17Z

Landed in 97c7e32

Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com> PR-URL: #62602 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

nodejs-github-bot added dgram Issues and PRs related to UDP and the dgram module. needs-ci PRs that need a full CI run. labels Apr 5, 2026

armanmikoyan force-pushed the fix/dgram-bind-silent-error branch 2 times, most recently from 60c4c3a to 6624c6fCompare April 5, 2026 17:12

dgram: don't swallow bind errors when callback is provided
4b5f804
Signed-off-by: armanmikoyan <arman.mikoyan1@gmail.com>

armanmikoyan force-pushed the fix/dgram-bind-silent-error branch from 6624c6f to 4b5f804Compare April 5, 2026 17:15

Ethan-Arrowood approved these changes Jul 14, 2026
View reviewed changes

mcollina approved these changes Jul 15, 2026
View reviewed changes

mcollina added semver-major PRs that contain breaking changes and should be released in the next major version. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Jul 15, 2026

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2026

gurgunday approved these changes Jul 15, 2026
View reviewed changes

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2026

This comment was marked as outdated.
Sign in to view

bjohansebas approved these changes Jul 24, 2026
View reviewed changes

This comment was marked as outdated.
Sign in to view

coderabbitaiBot mentioned this pull request Jul 27, 2026
test(dgram): expand Node 26.5.0 parity coverage PerryTS/perry#6894
Merged
14 tasks

trivikr added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 22, 2026

trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2026

nodejs-github-bot merged commit 97c7e32 into nodejs:mainAug 23, 2026
53 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2026

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged