tools: fix redundant conditions in v8.gyp for riscv64 and loong64 - #62608

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JamieMagee:fix-redundant-gyp-conditions
Jul 6, 2026
Merged

tools: fix redundant conditions in v8.gyp for riscv64 and loong64#62608
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JamieMagee:fix-redundant-gyp-conditions

Conversation

@JamieMagee

@JamieMageeJamieMagee commented Apr 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The builtins conditions for riscv64 and loong64 both read v8_target_arch=="X" or v8_target_arch=="X". The same value on both sides of the or. This was copied from the mips64 or mips64el pattern when riscv64 (#37980) and loong64 support were first added, but those are two different architectures and riscv64/loong64 each only have one.

Simplify both to plain v8_target_arch=="riscv64" / v8_target_arch=="loong64", matching ppc64, s390x, and the other single-variant architectures.

@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Apr 5, 2026
@JamieMageeJamieMagee mentioned this pull request Apr 5, 2026
Open
10 tasks
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2026
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72545/

@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7108/

@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7108/

@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7108/

@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7109/

@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7109/

@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7109/

@JamieMagee
JamieMageeforce-pushed the fix-redundant-gyp-conditions branch from e1471ad to 234df85CompareApril 8, 2026 06:14
@JamieMagee

JamieMagee commented Apr 8, 2026

Copy link
Copy Markdown
ContributorAuthor

Rebased on top of current main to see if that helps with the test flakiness.

@JamieMagee
JamieMageeforce-pushed the fix-redundant-gyp-conditions branch from 234df85 to 92cb82eCompareApril 21, 2026 06:13
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2026
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7136/

@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72847/

@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7136/

@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7136/

@JamieMagee

JamieMagee commented May 15, 2026

Copy link
Copy Markdown
ContributorAuthor

Should I rebase this? What else is missing?

@JamieMagee
JamieMageeforce-pushed the fix-redundant-gyp-conditions branch from 92cb82e to b4acdbbCompareJune 30, 2026 04:02
@JamieMagee

JamieMagee commented Jun 30, 2026

Copy link
Copy Markdown
ContributorAuthor

Rebased onto latest main.

@JamieMagee
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
00d3b18
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
@JamieMagee
JamieMageeforce-pushed the fix-redundant-gyp-conditions branch from b4acdbb to 00d3b18CompareJuly 2, 2026 17:58
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 6, 2026
@github-actionsgithub-actionsBot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 6, 2026
@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28796352494

@richardlaurichardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Jul 6, 2026
@github-actionsgithub-actionsBot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 6, 2026
@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28800821962

@nodejs-github-bot

nodejs-github-bot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74599/

@richardlaurichardlau added commit-queue PRs queued for automated landing through the Commit Queue. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Jul 6, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 6, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 3ee185d into nodejs:mainJul 6, 2026
74 of 76 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Landed in 3ee185d

@JamieMagee
JamieMagee deleted the fix-redundant-gyp-conditions branch July 6, 2026 22:48
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
0f6f5cc
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
@JamieMagee@RafaelGSS
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
86193ef
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
8a909f4
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95aduh95 mentioned this pull request Aug 22, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JamieMagee@nodejs-github-bot@lpinca@cjihrig@richardlau
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
tools: fix redundant conditions in v8.gyp for riscv64 and loong64 - #62608
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Jul 6, 2026
Merged
tools: fix redundant conditions in v8.gyp for riscv64 and loong64#62608
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Conversation
@JamieMagee
@JamieMageeJamieMagee
commented
Apr 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The builtins conditions for riscv64 and loong64 both read v8_target_arch=="X" or v8_target_arch=="X". The same value on both sides of the or. This was copied from the mips64 or mips64el pattern when riscv64 (#37980) and loong64 support were first added, but those are two different architectures and riscv64/loong64 each only have one.
Simplify both to plain v8_target_arch=="riscv64" / v8_target_arch=="loong64", matching ppc64, s390x, and the other single-variant architectures.
@nodejs-github-bot
nodejs-github-bot
commented
Apr 5, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
  •  @nodejs/v8-update
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Apr 5, 2026
@JamieMageeJamieMagee
mentioned this pull request
Apr 5, 2026

Open

10 tasks
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72545/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7109/
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
e1471ad to
234df85CompareApril 8, 2026 06:14
@JamieMagee
JamieMagee
commented
Apr 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased on top of current main to see if that helps with the test flakiness.
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
234df85 to
92cb82eCompareApril 21, 2026 06:13
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72847/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7136/
@JamieMagee
JamieMagee
commented
May 15, 2026

Copy link


Copy Markdown

ContributorAuthor
Should I rebase this? What else is missing?
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
92cb82e to
b4acdbbCompareJune 30, 2026 04:02
@JamieMagee
JamieMagee
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto latest main.
@JamieMagee
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
00d3b18
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
b4acdbb to
00d3b18CompareJuly 2, 2026 17:58
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28796352494
@richardlaurichardlau
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28800821962
@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74599/
@richardlaurichardlau
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 6, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 3ee185d
into
nodejs:mainJul 6, 2026

74 of 76 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
Landed in 3ee185d
@JamieMagee
JamieMagee
deleted the

fix-redundant-gyp-conditions

branch
July 6, 2026 22:48
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
0f6f5cc
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@JamieMagee@RafaelGSS
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
86193ef
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
8a909f4
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95aduh95
mentioned this pull request
Aug 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees


No one assigned


Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@JamieMagee@nodejs-github-bot@lpinca@cjihrig@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
tools: fix redundant conditions in v8.gyp for riscv64 and loong64 - #62608
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Jul 6, 2026
Merged
tools: fix redundant conditions in v8.gyp for riscv64 and loong64#62608
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Conversation
@JamieMagee
@JamieMageeJamieMagee
commented
Apr 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The builtins conditions for riscv64 and loong64 both read v8_target_arch=="X" or v8_target_arch=="X". The same value on both sides of the or. This was copied from the mips64 or mips64el pattern when riscv64 (#37980) and loong64 support were first added, but those are two different architectures and riscv64/loong64 each only have one.
Simplify both to plain v8_target_arch=="riscv64" / v8_target_arch=="loong64", matching ppc64, s390x, and the other single-variant architectures.
@nodejs-github-bot
nodejs-github-bot
commented
Apr 5, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
  •  @nodejs/v8-update
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Apr 5, 2026
@JamieMageeJamieMagee
mentioned this pull request
Apr 5, 2026

Open

10 tasks
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72545/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7109/
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
e1471ad to
234df85CompareApril 8, 2026 06:14
@JamieMagee
JamieMagee
commented
Apr 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased on top of current main to see if that helps with the test flakiness.
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
234df85 to
92cb82eCompareApril 21, 2026 06:13
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72847/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7136/
@JamieMagee
JamieMagee
commented
May 15, 2026

Copy link


Copy Markdown

ContributorAuthor
Should I rebase this? What else is missing?
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
92cb82e to
b4acdbbCompareJune 30, 2026 04:02
@JamieMagee
JamieMagee
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto latest main.
@JamieMagee
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
00d3b18
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
b4acdbb to
00d3b18CompareJuly 2, 2026 17:58
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28796352494
@richardlaurichardlau
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28800821962
@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74599/
@richardlaurichardlau
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 6, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 3ee185d
into
nodejs:mainJul 6, 2026

74 of 76 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
Landed in 3ee185d
@JamieMagee
JamieMagee
deleted the

fix-redundant-gyp-conditions

branch
July 6, 2026 22:48
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
0f6f5cc
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@JamieMagee@RafaelGSS
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
86193ef
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
8a909f4
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95aduh95
mentioned this pull request
Aug 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees


No one assigned


Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@JamieMagee@nodejs-github-bot@lpinca@cjihrig@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
tools: fix redundant conditions in v8.gyp for riscv64 and loong64 - #62608
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Jul 6, 2026
Merged
tools: fix redundant conditions in v8.gyp for riscv64 and loong64#62608
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Conversation
@JamieMagee
@JamieMageeJamieMagee
commented
Apr 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The builtins conditions for riscv64 and loong64 both read v8_target_arch=="X" or v8_target_arch=="X". The same value on both sides of the or. This was copied from the mips64 or mips64el pattern when riscv64 (#37980) and loong64 support were first added, but those are two different architectures and riscv64/loong64 each only have one.
Simplify both to plain v8_target_arch=="riscv64" / v8_target_arch=="loong64", matching ppc64, s390x, and the other single-variant architectures.
@nodejs-github-bot
nodejs-github-bot
commented
Apr 5, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
  •  @nodejs/v8-update
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Apr 5, 2026
@JamieMageeJamieMagee
mentioned this pull request
Apr 5, 2026

Open

10 tasks
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72545/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7109/
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
e1471ad to
234df85CompareApril 8, 2026 06:14
@JamieMagee
JamieMagee
commented
Apr 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased on top of current main to see if that helps with the test flakiness.
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
234df85 to
92cb82eCompareApril 21, 2026 06:13
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72847/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7136/
@JamieMagee
JamieMagee
commented
May 15, 2026

Copy link


Copy Markdown

ContributorAuthor
Should I rebase this? What else is missing?
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
92cb82e to
b4acdbbCompareJune 30, 2026 04:02
@JamieMagee
JamieMagee
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto latest main.
@JamieMagee
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
00d3b18
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
b4acdbb to
00d3b18CompareJuly 2, 2026 17:58
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28796352494
@richardlaurichardlau
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28800821962
@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74599/
@richardlaurichardlau
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 6, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 3ee185d
into
nodejs:mainJul 6, 2026

74 of 76 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
Landed in 3ee185d
@JamieMagee
JamieMagee
deleted the

fix-redundant-gyp-conditions

branch
July 6, 2026 22:48
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
0f6f5cc
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@JamieMagee@RafaelGSS
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
86193ef
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
8a909f4
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95aduh95
mentioned this pull request
Aug 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees


No one assigned


Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@JamieMagee@nodejs-github-bot@lpinca@cjihrig@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
tools: fix redundant conditions in v8.gyp for riscv64 and loong64 - #62608
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Jul 6, 2026
Merged
tools: fix redundant conditions in v8.gyp for riscv64 and loong64#62608
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Conversation
@JamieMagee
@JamieMageeJamieMagee
commented
Apr 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The builtins conditions for riscv64 and loong64 both read v8_target_arch=="X" or v8_target_arch=="X". The same value on both sides of the or. This was copied from the mips64 or mips64el pattern when riscv64 (#37980) and loong64 support were first added, but those are two different architectures and riscv64/loong64 each only have one.
Simplify both to plain v8_target_arch=="riscv64" / v8_target_arch=="loong64", matching ppc64, s390x, and the other single-variant architectures.
@nodejs-github-bot
nodejs-github-bot
commented
Apr 5, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
  •  @nodejs/v8-update
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Apr 5, 2026
@JamieMageeJamieMagee
mentioned this pull request
Apr 5, 2026

Open

10 tasks
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72545/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7109/
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
e1471ad to
234df85CompareApril 8, 2026 06:14
@JamieMagee
JamieMagee
commented
Apr 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased on top of current main to see if that helps with the test flakiness.
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
234df85 to
92cb82eCompareApril 21, 2026 06:13
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72847/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7136/
@JamieMagee
JamieMagee
commented
May 15, 2026

Copy link


Copy Markdown

ContributorAuthor
Should I rebase this? What else is missing?
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
92cb82e to
b4acdbbCompareJune 30, 2026 04:02
@JamieMagee
JamieMagee
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto latest main.
@JamieMagee
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
00d3b18
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
b4acdbb to
00d3b18CompareJuly 2, 2026 17:58
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28796352494
@richardlaurichardlau
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28800821962
@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74599/
@richardlaurichardlau
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 6, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 3ee185d
into
nodejs:mainJul 6, 2026

74 of 76 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
Landed in 3ee185d
@JamieMagee
JamieMagee
deleted the

fix-redundant-gyp-conditions

branch
July 6, 2026 22:48
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
0f6f5cc
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@JamieMagee@RafaelGSS
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
86193ef
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
8a909f4
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95aduh95
mentioned this pull request
Aug 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees


No one assigned


Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@JamieMagee@nodejs-github-bot@lpinca@cjihrig@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
tools: fix redundant conditions in v8.gyp for riscv64 and loong64 - #62608
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Jul 6, 2026
Merged
tools: fix redundant conditions in v8.gyp for riscv64 and loong64#62608
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Conversation
@JamieMagee
@JamieMageeJamieMagee
commented
Apr 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The builtins conditions for riscv64 and loong64 both read v8_target_arch=="X" or v8_target_arch=="X". The same value on both sides of the or. This was copied from the mips64 or mips64el pattern when riscv64 (#37980) and loong64 support were first added, but those are two different architectures and riscv64/loong64 each only have one.
Simplify both to plain v8_target_arch=="riscv64" / v8_target_arch=="loong64", matching ppc64, s390x, and the other single-variant architectures.
@nodejs-github-bot
nodejs-github-bot
commented
Apr 5, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
  •  @nodejs/v8-update
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Apr 5, 2026
@JamieMageeJamieMagee
mentioned this pull request
Apr 5, 2026

Open

10 tasks
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72545/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7109/
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
e1471ad to
234df85CompareApril 8, 2026 06:14
@JamieMagee
JamieMagee
commented
Apr 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased on top of current main to see if that helps with the test flakiness.
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
234df85 to
92cb82eCompareApril 21, 2026 06:13
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72847/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7136/
@JamieMagee
JamieMagee
commented
May 15, 2026

Copy link


Copy Markdown

ContributorAuthor
Should I rebase this? What else is missing?
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
92cb82e to
b4acdbbCompareJune 30, 2026 04:02
@JamieMagee
JamieMagee
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto latest main.
@JamieMagee
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
00d3b18
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
b4acdbb to
00d3b18CompareJuly 2, 2026 17:58
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28796352494
@richardlaurichardlau
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28800821962
@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74599/
@richardlaurichardlau
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 6, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 3ee185d
into
nodejs:mainJul 6, 2026

74 of 76 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
Landed in 3ee185d
@JamieMagee
JamieMagee
deleted the

fix-redundant-gyp-conditions

branch
July 6, 2026 22:48
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
0f6f5cc
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@JamieMagee@RafaelGSS
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
86193ef
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
8a909f4
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95aduh95
mentioned this pull request
Aug 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees


No one assigned


Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@JamieMagee@nodejs-github-bot@lpinca@cjihrig@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
tools: fix redundant conditions in v8.gyp for riscv64 and loong64 - #62608
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Jul 6, 2026
Merged
tools: fix redundant conditions in v8.gyp for riscv64 and loong64#62608
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Conversation
@JamieMagee
@JamieMageeJamieMagee
commented
Apr 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The builtins conditions for riscv64 and loong64 both read v8_target_arch=="X" or v8_target_arch=="X". The same value on both sides of the or. This was copied from the mips64 or mips64el pattern when riscv64 (#37980) and loong64 support were first added, but those are two different architectures and riscv64/loong64 each only have one.
Simplify both to plain v8_target_arch=="riscv64" / v8_target_arch=="loong64", matching ppc64, s390x, and the other single-variant architectures.
@nodejs-github-bot
nodejs-github-bot
commented
Apr 5, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
  •  @nodejs/v8-update
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Apr 5, 2026
@JamieMageeJamieMagee
mentioned this pull request
Apr 5, 2026

Open

10 tasks
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72545/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7109/
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
e1471ad to
234df85CompareApril 8, 2026 06:14
@JamieMagee
JamieMagee
commented
Apr 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased on top of current main to see if that helps with the test flakiness.
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
234df85 to
92cb82eCompareApril 21, 2026 06:13
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72847/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7136/
@JamieMagee
JamieMagee
commented
May 15, 2026

Copy link


Copy Markdown

ContributorAuthor
Should I rebase this? What else is missing?
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
92cb82e to
b4acdbbCompareJune 30, 2026 04:02
@JamieMagee
JamieMagee
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto latest main.
@JamieMagee
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
00d3b18
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
b4acdbb to
00d3b18CompareJuly 2, 2026 17:58
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28796352494
@richardlaurichardlau
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28800821962
@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74599/
@richardlaurichardlau
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 6, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 3ee185d
into
nodejs:mainJul 6, 2026

74 of 76 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
Landed in 3ee185d
@JamieMagee
JamieMagee
deleted the

fix-redundant-gyp-conditions

branch
July 6, 2026 22:48
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
0f6f5cc
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@JamieMagee@RafaelGSS
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
86193ef
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
8a909f4
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95aduh95
mentioned this pull request
Aug 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees


No one assigned


Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@JamieMagee@nodejs-github-bot@lpinca@cjihrig@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
tools: fix redundant conditions in v8.gyp for riscv64 and loong64 - #62608
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Jul 6, 2026
Merged
tools: fix redundant conditions in v8.gyp for riscv64 and loong64#62608
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
JamieMagee:fix-redundant-gyp-conditions
Conversation
@JamieMagee
@JamieMageeJamieMagee
commented
Apr 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The builtins conditions for riscv64 and loong64 both read v8_target_arch=="X" or v8_target_arch=="X". The same value on both sides of the or. This was copied from the mips64 or mips64el pattern when riscv64 (#37980) and loong64 support were first added, but those are two different architectures and riscv64/loong64 each only have one.
Simplify both to plain v8_target_arch=="riscv64" / v8_target_arch=="loong64", matching ppc64, s390x, and the other single-variant architectures.
@nodejs-github-bot
nodejs-github-bot
commented
Apr 5, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
  •  @nodejs/v8-update
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Apr 5, 2026
@JamieMageeJamieMagee
mentioned this pull request
Apr 5, 2026

Open

10 tasks
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 7, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72545/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7108/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7109/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 7, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7109/
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
e1471ad to
234df85CompareApril 8, 2026 06:14
@JamieMagee
JamieMagee
commented
Apr 8, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased on top of current main to see if that helps with the test flakiness.
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
234df85 to
92cb82eCompareApril 21, 2026 06:13
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 22, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/72847/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7136/
@nodejs-github-bot
nodejs-github-bot
commented
Apr 22, 2026

Copy link


Copy Markdown

Collaborator
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7136/
@JamieMagee
JamieMagee
commented
May 15, 2026

Copy link


Copy Markdown

ContributorAuthor
Should I rebase this? What else is missing?
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
92cb82e to
b4acdbbCompareJune 30, 2026 04:02
@JamieMagee
JamieMagee
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
Rebased onto latest main.
@JamieMagee
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
00d3b18
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
@JamieMagee
JamieMageeforce-pushed
the
fix-redundant-gyp-conditions
branch
from
b4acdbb to
00d3b18CompareJuly 2, 2026 17:58
@richardlaurichardlau
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28796352494
@richardlaurichardlau
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@github-actionsgithub-actionsBot
added

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 6, 2026
@github-actions
github-actionsBot
commented
Jul 6, 2026

Copy link


Copy Markdown

Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/72847/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/28800821962
@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74599/
@richardlaurichardlau
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci-failed
Starting CI with the request-ci label failed and requires manual intervention.
labels
Jul 6, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 6, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 3ee185d
into
nodejs:mainJul 6, 2026

74 of 76 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 6, 2026

Copy link


Copy Markdown

Collaborator
Landed in 3ee185d
@JamieMagee
JamieMagee
deleted the

fix-redundant-gyp-conditions

branch
July 6, 2026 22:48
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
0f6f5cc
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@JamieMagee@RafaelGSS
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
86193ef
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@JamieMagee@aduh95
tools: fix redundant conditions in v8.gyp for riscv64 and loong64
8a909f4
The builtins conditions for riscv64 and loong64 both have the form
'v8_target_arch=="X" or v8_target_arch=="X"' which is redundant.
This was copied from the mips64/mips64el pattern (where the 'or' is
correct since those are two different architectures) when riscv64
and loong64 support were first added.
Simplify both to match the pattern used by ppc64, s390x, and other
single-variant architectures.
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
PR-URL: #62608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95aduh95
mentioned this pull request
Aug 22, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees


No one assigned


Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@JamieMagee@nodejs-github-bot@lpinca@cjihrig@richardlau