Uh oh!
There was an error while loading. Please reload this page.
fs: pass symlink type in cp when filter is provided - #62654
Merged
nodejs-github-bot merged 1 commit intoAug 22, 2026
Merged
Conversation
shulaoda
marked this pull request as ready for review
April 9, 2026 16:25
avivkeller
approved these changes
Apr 9, 2026
juanarbol
approved these changes
Apr 9, 2026
StefanStojanovic
approved these changes
Apr 14, 2026
shulaodaforce-pushed
the
04-10-fs_pass_symlink_type_in_cp_when_filter_is_provided
branch
2 times, most recently
from
May 22, 2026 09:09
979dcbe to
386c58eComparenodejs-github-bot
commented
May 22, 2026
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #62654 +/- ##
==========================================
- Coverage 92.01% 90.33% -1.69%
==========================================
Files 379 760 +381 Lines 166972 248526 +81554 Branches 25554 46903 +21349 ==========================================
+ Hits 153639 224496 +70857 - Misses 13041 15452 +2411 - Partials 292 8578 +8286
🚀 New features to boost your workflow:
|
shulaodaforce-pushed
the
04-10-fs_pass_symlink_type_in_cp_when_filter_is_provided
branch
from
May 22, 2026 13:49
386c58e to
73d40d1Compareshulaoda
commented
May 22, 2026
ContributorAuthor
@mcollina Sorry, I had to amend the commit to get lint-commit-message CI to pass. Mind re-approving? Thanks! 🙏 |
nodejs-github-bot
commented
May 22, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62654 ✔ Done loading data for nodejs/node/pull/62654 ----------------------------------- PR info ------------------------------------ Title fs: pass symlink type in cp when filter is provided (#62654) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch shulaoda:04-10-fs_pass_symlink_type_in_cp_when_filter_is_provided -> nodejs:main Labels fs, needs-ci Commits 1 - fs: pass symlink type in cp when filter is provided Committers 1 - shulaoda <165626830+shulaoda@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/62654 Fixes: https://github.com/nodejs/node/issues/62653 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62654 Fixes: https://github.com/nodejs/node/issues/62653 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 09 Apr 2026 16:25:30 GMT ✔ Approvals: 4 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/62654#pullrequestreview-4084591716 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/62654#pullrequestreview-4084831882 ✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/62654#pullrequestreview-4103501656 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/62654#pullrequestreview-4345294374 ✘ 10 GitHub CI job(s) failed: ✘ - github-actions: ACTION_REQUIRED ✘ - github-actions: ACTION_REQUIRED ✘ - github-actions: ACTION_REQUIRED ✘ - github-actions: ACTION_REQUIRED ✘ - github-actions: ACTION_REQUIRED ✘ - github-actions: ACTION_REQUIRED ✘ - github-actions: ACTION_REQUIRED ✘ - github-actions: ACTION_REQUIRED ✘ - github-actions: ACTION_REQUIRED ✘ - github-actions: ACTION_REQUIRED ℹ Last Full PR CI on 2026-05-22T13:09:00Z: https://ci.nodejs.org/job/node-test-pull-request/73616/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - fs: pass symlink type in cp when filter is provided - Querying data for job/node-test-pull-request/73616/ ✔ Build data downloaded ✘ Last Jenkins CI still running -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/26292186844 |
When `fs.cp`/`fs.cpSync` is called with both `verbatimSymlinks: true` and a `filter` function, directory symlinks were incorrectly created as file symlinks on Windows. Without a `filter`, cp takes the C++ fast path (`cpSyncCopyDir`) which uses `std::filesystem::copy_symlink()` and preserves the symlink type automatically. With a `filter`, the JS fallback calls `symlinkSync`/ `symlink` without a `type` argument. On Windows, that causes the type to be auto-detected by stat-ing the resolved target at the destination, but during a recursive copy the target directory may not exist yet at the destination (e.g. `linked/` is copied before `packages/` in alphabetical order). The stat fails and `type` falls back to `'file'`, producing a file symlink in place of a directory symlink. Detect the symlink type from the source (which always exists) via `internalModuleStat(src)` and pass it explicitly to the `symlinkSync`/ `symlink` call sites. `onLink` already computed `srcIsDir` for subdirectory validation; hoist that computation above the early-return paths and thread the derived `symlinkType` through `copyLink` as well. Both the sync (`cp-sync.js`) and async (`cp.js`) implementations are fixed. Add two regression tests that copy a tree containing a relative directory symlink with `verbatimSymlinks: true` and a `filter` function, then assert the destination link still resolves as a directory. Fixes: nodejs#62653 Signed-off-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
shulaodaforce-pushed
the
04-10-fs_pass_symlink_type_in_cp_when_filter_is_provided
branch
from
June 25, 2026 23:19
73d40d1 to
793de42Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Aug 22, 2026
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Aug 22, 2026
Collaborator
Landed in 7d69ed1 |
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
When `fs.cp`/`fs.cpSync` is called with both `verbatimSymlinks: true` and a `filter` function, directory symlinks were incorrectly created as file symlinks on Windows. Without a `filter`, cp takes the C++ fast path (`cpSyncCopyDir`) which uses `std::filesystem::copy_symlink()` and preserves the symlink type automatically. With a `filter`, the JS fallback calls `symlinkSync`/ `symlink` without a `type` argument. On Windows, that causes the type to be auto-detected by stat-ing the resolved target at the destination, but during a recursive copy the target directory may not exist yet at the destination (e.g. `linked/` is copied before `packages/` in alphabetical order). The stat fails and `type` falls back to `'file'`, producing a file symlink in place of a directory symlink. Detect the symlink type from the source (which always exists) via `internalModuleStat(src)` and pass it explicitly to the `symlinkSync`/ `symlink` call sites. `onLink` already computed `srcIsDir` for subdirectory validation; hoist that computation above the early-return paths and thread the derived `symlinkType` through `copyLink` as well. Both the sync (`cp-sync.js`) and async (`cp.js`) implementations are fixed. Add two regression tests that copy a tree containing a relative directory symlink with `verbatimSymlinks: true` and a `filter` function, then assert the destination link still resolves as a directory. Fixes: #62653 Signed-off-by: shulaoda <165626830+shulaoda@users.noreply.github.com> PR-URL: #62654 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
When `fs.cp`/`fs.cpSync` is called with both `verbatimSymlinks: true` and a `filter` function, directory symlinks were incorrectly created as file symlinks on Windows. Without a `filter`, cp takes the C++ fast path (`cpSyncCopyDir`) which uses `std::filesystem::copy_symlink()` and preserves the symlink type automatically. With a `filter`, the JS fallback calls `symlinkSync`/ `symlink` without a `type` argument. On Windows, that causes the type to be auto-detected by stat-ing the resolved target at the destination, but during a recursive copy the target directory may not exist yet at the destination (e.g. `linked/` is copied before `packages/` in alphabetical order). The stat fails and `type` falls back to `'file'`, producing a file symlink in place of a directory symlink. Detect the symlink type from the source (which always exists) via `internalModuleStat(src)` and pass it explicitly to the `symlinkSync`/ `symlink` call sites. `onLink` already computed `srcIsDir` for subdirectory validation; hoist that computation above the early-return paths and thread the derived `symlinkType` through `copyLink` as well. Both the sync (`cp-sync.js`) and async (`cp.js`) implementations are fixed. Add two regression tests that copy a tree containing a relative directory symlink with `verbatimSymlinks: true` and a `filter` function, then assert the destination link still resolves as a directory. Fixes: #62653 Signed-off-by: shulaoda <165626830+shulaoda@users.noreply.github.com> PR-URL: #62654 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
When `fs.cp`/`fs.cpSync` is called with both `verbatimSymlinks: true` and a `filter` function, directory symlinks were incorrectly created as file symlinks on Windows. Without a `filter`, cp takes the C++ fast path (`cpSyncCopyDir`) which uses `std::filesystem::copy_symlink()` and preserves the symlink type automatically. With a `filter`, the JS fallback calls `symlinkSync`/ `symlink` without a `type` argument. On Windows, that causes the type to be auto-detected by stat-ing the resolved target at the destination, but during a recursive copy the target directory may not exist yet at the destination (e.g. `linked/` is copied before `packages/` in alphabetical order). The stat fails and `type` falls back to `'file'`, producing a file symlink in place of a directory symlink. Detect the symlink type from the source (which always exists) via `internalModuleStat(src)` and pass it explicitly to the `symlinkSync`/ `symlink` call sites. `onLink` already computed `srcIsDir` for subdirectory validation; hoist that computation above the early-return paths and thread the derived `symlinkType` through `copyLink` as well. Both the sync (`cp-sync.js`) and async (`cp.js`) implementations are fixed. Add two regression tests that copy a tree containing a relative directory symlink with `verbatimSymlinks: true` and a `filter` function, then assert the destination link still resolves as a directory. Fixes: #62653 Signed-off-by: shulaoda <165626830+shulaoda@users.noreply.github.com> PR-URL: #62654 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
fs.cp/fs.cpSyncis called with bothverbatimSymlinks: trueand afilterfunction, directory symlinks are incorrectly created as file symlinks on Windows.Root cause
fs.cptakes two code paths:filter: the C++ fast path (cpSyncCopyDir) usesstd::filesystem::copy_symlink()which preserves the symlink type automatically.filter: the JS fallback path callssymlinkSync(resolvedSrc, dest)without atypeparameter. On Windows,symlinkSynctries to auto-detect the type by stat-ing the resolved target at the destination. During a recursive copy, the target directory may not yet exist at the destination (e.g.linked/is copied beforepackages/in alphabetical order), so stat fails andtypedefaults to'file'creating a file symlink instead of a directory symlink.Test
Added two test files that verify directory symlinks are preserved when copying with
verbatimSymlinks: trueand afilterfunction:test-fs-cp-sync-verbatim-dir-symlinks-with-filter.mjstest-fs-cp-async-verbatim-dir-symlinks-with-filter.mjsFixes: #62653