sqlite: add stmt persistent flag by araujogui · Pull Request #62757 · nodejs/node

araujogui · 2026-04-15T13:02:49Z

Add statement's persistent argument flag

Reference:
https://sqlite.org/c3ref/c_prepare_dont_log.html#sqlitepreparepersistent

nodejs-github-bot · 2026-04-15T13:02:55Z

Review requested:

@nodejs/sqlite

Copilot

Pull request overview

Adds a new persistent option to DatabaseSync#prepare() in node:sqlite, exposing SQLite’s SQLITE_PREPARE_PERSISTENT hint to influence statement memory-allocation strategy for frequently reused prepared statements.

Changes:

Add options.persistent parsing/validation to DatabaseSync::Prepare() and pass SQLITE_PREPARE_PERSISTENT via sqlite3_prepare_v3().
Add parallel tests covering persistent: true/false, type validation, and interoperability with other options.
Document the new option and update the implementation reference from sqlite3_prepare_v2() to sqlite3_prepare_v3().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`src/node_sqlite.cc`	Parses `options.persistent` and uses `sqlite3_prepare_v3(..., SQLITE_PREPARE_PERSISTENT)` when enabled.
`test/parallel/test-sqlite-statement-sync.js`	Adds coverage for correct execution and argument validation for `persistent`.
`doc/api/sqlite.md`	Documents `persistent` and updates the underlying SQLite API reference/link definitions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

araujogui · 2026-04-15T14:26:48Z

Interesting thing: SQLITE_PREPARE_PERSISTENT is enabled by default on better-sqlite3

codecov · 2026-04-15T14:51:41Z

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (1662b69) to head (2e519da).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.90%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #62757 +/- ##
==========================================
+ Coverage 90.31% 90.32% +0.01% 
==========================================
Files 751 751 Lines 249776 250019 +243 Branches 47173 47227 +54 ==========================================
+ Hits 225587 225833 +246 + Misses 15585 15559 -26 - Partials 8604 8627 +23

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.68% <90.90%> (+0.05%)`	⬆️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

louwers · 2026-04-15T15:12:21Z

At least makes sense to enable it by default for SQLTagStore statements I'd say.

araujogui · 2026-05-27T16:54:03Z

@nodejs/sqlite Friendly bump

trivikr · 2026-08-12T04:26:46Z

@araujogui Can you please rebase from main?

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

araujogui · 2026-08-13T17:46:38Z

@araujogui Can you please rebase from main?

Rebased

nodejs-github-bot · 2026-08-14T20:29:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75850/

nodejs-github-bot · 2026-08-14T21:57:34Z

Landed in c8996ea

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: #62757 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

araujogui · 2026-04-15T13:02:49Z

Add statement's persistent argument flag

Reference:
https://sqlite.org/c3ref/c_prepare_dont_log.html#sqlitepreparepersistent

nodejs-github-bot · 2026-04-15T13:02:55Z

Review requested:

@nodejs/sqlite

Copilot

Pull request overview

Adds a new persistent option to DatabaseSync#prepare() in node:sqlite, exposing SQLite’s SQLITE_PREPARE_PERSISTENT hint to influence statement memory-allocation strategy for frequently reused prepared statements.

Changes:

Add options.persistent parsing/validation to DatabaseSync::Prepare() and pass SQLITE_PREPARE_PERSISTENT via sqlite3_prepare_v3().
Add parallel tests covering persistent: true/false, type validation, and interoperability with other options.
Document the new option and update the implementation reference from sqlite3_prepare_v2() to sqlite3_prepare_v3().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`src/node_sqlite.cc`	Parses `options.persistent` and uses `sqlite3_prepare_v3(..., SQLITE_PREPARE_PERSISTENT)` when enabled.
`test/parallel/test-sqlite-statement-sync.js`	Adds coverage for correct execution and argument validation for `persistent`.
`doc/api/sqlite.md`	Documents `persistent` and updates the underlying SQLite API reference/link definitions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

araujogui · 2026-04-15T14:26:48Z

Interesting thing: SQLITE_PREPARE_PERSISTENT is enabled by default on better-sqlite3

codecov · 2026-04-15T14:51:41Z

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (1662b69) to head (2e519da).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.90%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #62757 +/- ##
==========================================
+ Coverage 90.31% 90.32% +0.01% 
==========================================
Files 751 751 Lines 249776 250019 +243 Branches 47173 47227 +54 ==========================================
+ Hits 225587 225833 +246 + Misses 15585 15559 -26 - Partials 8604 8627 +23

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.68% <90.90%> (+0.05%)`	⬆️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

louwers · 2026-04-15T15:12:21Z

At least makes sense to enable it by default for SQLTagStore statements I'd say.

araujogui · 2026-05-27T16:54:03Z

@nodejs/sqlite Friendly bump

trivikr · 2026-08-12T04:26:46Z

@araujogui Can you please rebase from main?

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

araujogui · 2026-08-13T17:46:38Z

@araujogui Can you please rebase from main?

Rebased

nodejs-github-bot · 2026-08-14T20:29:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75850/

nodejs-github-bot · 2026-08-14T21:57:34Z

Landed in c8996ea

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: #62757 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

araujogui · 2026-04-15T13:02:49Z

Add statement's persistent argument flag

Reference:
https://sqlite.org/c3ref/c_prepare_dont_log.html#sqlitepreparepersistent

nodejs-github-bot · 2026-04-15T13:02:55Z

Review requested:

@nodejs/sqlite

Copilot

Pull request overview

Adds a new persistent option to DatabaseSync#prepare() in node:sqlite, exposing SQLite’s SQLITE_PREPARE_PERSISTENT hint to influence statement memory-allocation strategy for frequently reused prepared statements.

Changes:

Add options.persistent parsing/validation to DatabaseSync::Prepare() and pass SQLITE_PREPARE_PERSISTENT via sqlite3_prepare_v3().
Add parallel tests covering persistent: true/false, type validation, and interoperability with other options.
Document the new option and update the implementation reference from sqlite3_prepare_v2() to sqlite3_prepare_v3().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`src/node_sqlite.cc`	Parses `options.persistent` and uses `sqlite3_prepare_v3(..., SQLITE_PREPARE_PERSISTENT)` when enabled.
`test/parallel/test-sqlite-statement-sync.js`	Adds coverage for correct execution and argument validation for `persistent`.
`doc/api/sqlite.md`	Documents `persistent` and updates the underlying SQLite API reference/link definitions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

araujogui · 2026-04-15T14:26:48Z

Interesting thing: SQLITE_PREPARE_PERSISTENT is enabled by default on better-sqlite3

codecov · 2026-04-15T14:51:41Z

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (1662b69) to head (2e519da).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.90%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #62757 +/- ##
==========================================
+ Coverage 90.31% 90.32% +0.01% 
==========================================
Files 751 751 Lines 249776 250019 +243 Branches 47173 47227 +54 ==========================================
+ Hits 225587 225833 +246 + Misses 15585 15559 -26 - Partials 8604 8627 +23

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.68% <90.90%> (+0.05%)`	⬆️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

louwers · 2026-04-15T15:12:21Z

At least makes sense to enable it by default for SQLTagStore statements I'd say.

araujogui · 2026-05-27T16:54:03Z

@nodejs/sqlite Friendly bump

trivikr · 2026-08-12T04:26:46Z

@araujogui Can you please rebase from main?

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

araujogui · 2026-08-13T17:46:38Z

@araujogui Can you please rebase from main?

Rebased

nodejs-github-bot · 2026-08-14T20:29:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75850/

nodejs-github-bot · 2026-08-14T21:57:34Z

Landed in c8996ea

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: #62757 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

araujogui · 2026-04-15T13:02:49Z

Add statement's persistent argument flag

Reference:
https://sqlite.org/c3ref/c_prepare_dont_log.html#sqlitepreparepersistent

nodejs-github-bot · 2026-04-15T13:02:55Z

Review requested:

@nodejs/sqlite

Copilot

Pull request overview

Adds a new persistent option to DatabaseSync#prepare() in node:sqlite, exposing SQLite’s SQLITE_PREPARE_PERSISTENT hint to influence statement memory-allocation strategy for frequently reused prepared statements.

Changes:

Add options.persistent parsing/validation to DatabaseSync::Prepare() and pass SQLITE_PREPARE_PERSISTENT via sqlite3_prepare_v3().
Add parallel tests covering persistent: true/false, type validation, and interoperability with other options.
Document the new option and update the implementation reference from sqlite3_prepare_v2() to sqlite3_prepare_v3().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`src/node_sqlite.cc`	Parses `options.persistent` and uses `sqlite3_prepare_v3(..., SQLITE_PREPARE_PERSISTENT)` when enabled.
`test/parallel/test-sqlite-statement-sync.js`	Adds coverage for correct execution and argument validation for `persistent`.
`doc/api/sqlite.md`	Documents `persistent` and updates the underlying SQLite API reference/link definitions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

araujogui · 2026-04-15T14:26:48Z

Interesting thing: SQLITE_PREPARE_PERSISTENT is enabled by default on better-sqlite3

codecov · 2026-04-15T14:51:41Z

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (1662b69) to head (2e519da).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.90%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #62757 +/- ##
==========================================
+ Coverage 90.31% 90.32% +0.01% 
==========================================
Files 751 751 Lines 249776 250019 +243 Branches 47173 47227 +54 ==========================================
+ Hits 225587 225833 +246 + Misses 15585 15559 -26 - Partials 8604 8627 +23

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.68% <90.90%> (+0.05%)`	⬆️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

louwers · 2026-04-15T15:12:21Z

At least makes sense to enable it by default for SQLTagStore statements I'd say.

araujogui · 2026-05-27T16:54:03Z

@nodejs/sqlite Friendly bump

trivikr · 2026-08-12T04:26:46Z

@araujogui Can you please rebase from main?

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

araujogui · 2026-08-13T17:46:38Z

@araujogui Can you please rebase from main?

Rebased

nodejs-github-bot · 2026-08-14T20:29:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75850/

nodejs-github-bot · 2026-08-14T21:57:34Z

Landed in c8996ea

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: #62757 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

araujogui · 2026-04-15T13:02:49Z

Add statement's persistent argument flag

Reference:
https://sqlite.org/c3ref/c_prepare_dont_log.html#sqlitepreparepersistent

nodejs-github-bot · 2026-04-15T13:02:55Z

Review requested:

@nodejs/sqlite

Copilot

Pull request overview

Adds a new persistent option to DatabaseSync#prepare() in node:sqlite, exposing SQLite’s SQLITE_PREPARE_PERSISTENT hint to influence statement memory-allocation strategy for frequently reused prepared statements.

Changes:

Add options.persistent parsing/validation to DatabaseSync::Prepare() and pass SQLITE_PREPARE_PERSISTENT via sqlite3_prepare_v3().
Add parallel tests covering persistent: true/false, type validation, and interoperability with other options.
Document the new option and update the implementation reference from sqlite3_prepare_v2() to sqlite3_prepare_v3().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`src/node_sqlite.cc`	Parses `options.persistent` and uses `sqlite3_prepare_v3(..., SQLITE_PREPARE_PERSISTENT)` when enabled.
`test/parallel/test-sqlite-statement-sync.js`	Adds coverage for correct execution and argument validation for `persistent`.
`doc/api/sqlite.md`	Documents `persistent` and updates the underlying SQLite API reference/link definitions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

araujogui · 2026-04-15T14:26:48Z

Interesting thing: SQLITE_PREPARE_PERSISTENT is enabled by default on better-sqlite3

codecov · 2026-04-15T14:51:41Z

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (1662b69) to head (2e519da).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.90%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #62757 +/- ##
==========================================
+ Coverage 90.31% 90.32% +0.01% 
==========================================
Files 751 751 Lines 249776 250019 +243 Branches 47173 47227 +54 ==========================================
+ Hits 225587 225833 +246 + Misses 15585 15559 -26 - Partials 8604 8627 +23

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.68% <90.90%> (+0.05%)`	⬆️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

louwers · 2026-04-15T15:12:21Z

At least makes sense to enable it by default for SQLTagStore statements I'd say.

araujogui · 2026-05-27T16:54:03Z

@nodejs/sqlite Friendly bump

trivikr · 2026-08-12T04:26:46Z

@araujogui Can you please rebase from main?

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

araujogui · 2026-08-13T17:46:38Z

@araujogui Can you please rebase from main?

Rebased

nodejs-github-bot · 2026-08-14T20:29:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75850/

nodejs-github-bot · 2026-08-14T21:57:34Z

Landed in c8996ea

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: #62757 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

araujogui · 2026-04-15T13:02:49Z

Add statement's persistent argument flag

Reference:
https://sqlite.org/c3ref/c_prepare_dont_log.html#sqlitepreparepersistent

nodejs-github-bot · 2026-04-15T13:02:55Z

Review requested:

@nodejs/sqlite

Copilot

Pull request overview

Adds a new persistent option to DatabaseSync#prepare() in node:sqlite, exposing SQLite’s SQLITE_PREPARE_PERSISTENT hint to influence statement memory-allocation strategy for frequently reused prepared statements.

Changes:

Add options.persistent parsing/validation to DatabaseSync::Prepare() and pass SQLITE_PREPARE_PERSISTENT via sqlite3_prepare_v3().
Add parallel tests covering persistent: true/false, type validation, and interoperability with other options.
Document the new option and update the implementation reference from sqlite3_prepare_v2() to sqlite3_prepare_v3().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`src/node_sqlite.cc`	Parses `options.persistent` and uses `sqlite3_prepare_v3(..., SQLITE_PREPARE_PERSISTENT)` when enabled.
`test/parallel/test-sqlite-statement-sync.js`	Adds coverage for correct execution and argument validation for `persistent`.
`doc/api/sqlite.md`	Documents `persistent` and updates the underlying SQLite API reference/link definitions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

araujogui · 2026-04-15T14:26:48Z

Interesting thing: SQLITE_PREPARE_PERSISTENT is enabled by default on better-sqlite3

codecov · 2026-04-15T14:51:41Z

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (1662b69) to head (2e519da).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.90%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #62757 +/- ##
==========================================
+ Coverage 90.31% 90.32% +0.01% 
==========================================
Files 751 751 Lines 249776 250019 +243 Branches 47173 47227 +54 ==========================================
+ Hits 225587 225833 +246 + Misses 15585 15559 -26 - Partials 8604 8627 +23

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.68% <90.90%> (+0.05%)`	⬆️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

louwers · 2026-04-15T15:12:21Z

At least makes sense to enable it by default for SQLTagStore statements I'd say.

araujogui · 2026-05-27T16:54:03Z

@nodejs/sqlite Friendly bump

trivikr · 2026-08-12T04:26:46Z

@araujogui Can you please rebase from main?

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

araujogui · 2026-08-13T17:46:38Z

@araujogui Can you please rebase from main?

Rebased

nodejs-github-bot · 2026-08-14T20:29:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75850/

nodejs-github-bot · 2026-08-14T21:57:34Z

Landed in c8996ea

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: #62757 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

araujogui · 2026-04-15T13:02:49Z

Add statement's persistent argument flag

Reference:
https://sqlite.org/c3ref/c_prepare_dont_log.html#sqlitepreparepersistent

nodejs-github-bot · 2026-04-15T13:02:55Z

Review requested:

@nodejs/sqlite

Copilot

Pull request overview

Adds a new persistent option to DatabaseSync#prepare() in node:sqlite, exposing SQLite’s SQLITE_PREPARE_PERSISTENT hint to influence statement memory-allocation strategy for frequently reused prepared statements.

Changes:

Add options.persistent parsing/validation to DatabaseSync::Prepare() and pass SQLITE_PREPARE_PERSISTENT via sqlite3_prepare_v3().
Add parallel tests covering persistent: true/false, type validation, and interoperability with other options.
Document the new option and update the implementation reference from sqlite3_prepare_v2() to sqlite3_prepare_v3().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`src/node_sqlite.cc`	Parses `options.persistent` and uses `sqlite3_prepare_v3(..., SQLITE_PREPARE_PERSISTENT)` when enabled.
`test/parallel/test-sqlite-statement-sync.js`	Adds coverage for correct execution and argument validation for `persistent`.
`doc/api/sqlite.md`	Documents `persistent` and updates the underlying SQLite API reference/link definitions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

araujogui · 2026-04-15T14:26:48Z

Interesting thing: SQLITE_PREPARE_PERSISTENT is enabled by default on better-sqlite3

codecov · 2026-04-15T14:51:41Z

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (1662b69) to head (2e519da).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.90%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #62757 +/- ##
==========================================
+ Coverage 90.31% 90.32% +0.01% 
==========================================
Files 751 751 Lines 249776 250019 +243 Branches 47173 47227 +54 ==========================================
+ Hits 225587 225833 +246 + Misses 15585 15559 -26 - Partials 8604 8627 +23

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.68% <90.90%> (+0.05%)`	⬆️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

louwers · 2026-04-15T15:12:21Z

At least makes sense to enable it by default for SQLTagStore statements I'd say.

araujogui · 2026-05-27T16:54:03Z

@nodejs/sqlite Friendly bump

trivikr · 2026-08-12T04:26:46Z

@araujogui Can you please rebase from main?

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

araujogui · 2026-08-13T17:46:38Z

@araujogui Can you please rebase from main?

Rebased

nodejs-github-bot · 2026-08-14T20:29:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75850/

nodejs-github-bot · 2026-08-14T21:57:34Z

Landed in c8996ea

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: #62757 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

araujogui · 2026-04-15T13:02:49Z

Add statement's persistent argument flag

Reference:
https://sqlite.org/c3ref/c_prepare_dont_log.html#sqlitepreparepersistent

nodejs-github-bot · 2026-04-15T13:02:55Z

Review requested:

@nodejs/sqlite

Copilot

Pull request overview

Adds a new persistent option to DatabaseSync#prepare() in node:sqlite, exposing SQLite’s SQLITE_PREPARE_PERSISTENT hint to influence statement memory-allocation strategy for frequently reused prepared statements.

Changes:

Add options.persistent parsing/validation to DatabaseSync::Prepare() and pass SQLITE_PREPARE_PERSISTENT via sqlite3_prepare_v3().
Add parallel tests covering persistent: true/false, type validation, and interoperability with other options.
Document the new option and update the implementation reference from sqlite3_prepare_v2() to sqlite3_prepare_v3().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`src/node_sqlite.cc`	Parses `options.persistent` and uses `sqlite3_prepare_v3(..., SQLITE_PREPARE_PERSISTENT)` when enabled.
`test/parallel/test-sqlite-statement-sync.js`	Adds coverage for correct execution and argument validation for `persistent`.
`doc/api/sqlite.md`	Documents `persistent` and updates the underlying SQLite API reference/link definitions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

araujogui · 2026-04-15T14:26:48Z

Interesting thing: SQLITE_PREPARE_PERSISTENT is enabled by default on better-sqlite3

codecov · 2026-04-15T14:51:41Z

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (1662b69) to head (2e519da).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.90%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #62757 +/- ##
==========================================
+ Coverage 90.31% 90.32% +0.01% 
==========================================
Files 751 751 Lines 249776 250019 +243 Branches 47173 47227 +54 ==========================================
+ Hits 225587 225833 +246 + Misses 15585 15559 -26 - Partials 8604 8627 +23

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`81.68% <90.90%> (+0.05%)`	⬆️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

louwers · 2026-04-15T15:12:21Z

At least makes sense to enable it by default for SQLTagStore statements I'd say.

araujogui · 2026-05-27T16:54:03Z

@nodejs/sqlite Friendly bump

trivikr · 2026-08-12T04:26:46Z

@araujogui Can you please rebase from main?

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

araujogui · 2026-08-13T17:46:38Z

@araujogui Can you please rebase from main?

Rebased

nodejs-github-bot · 2026-08-14T20:29:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75850/

nodejs-github-bot · 2026-08-14T21:57:34Z

Landed in c8996ea

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: #62757 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

CopilotAI review requested due to automatic review settings April 15, 2026 13:02

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Apr 15, 2026

Copilotstarted reviewing on behalf of araujogui April 15, 2026 13:03 View session

CopilotAI reviewed Apr 15, 2026
View reviewed changes

Comment threadsrc/node_sqlite.cc Outdated

araujogui force-pushed the sqlite-prepare-persistent branch from 504bd95 to 4f2ef78Compare April 15, 2026 13:26

meixg approved these changes Apr 16, 2026
View reviewed changes

geeksilva97 reviewed May 27, 2026
View reviewed changes

Comment threadtest/parallel/test-sqlite-statement-sync.js Outdated

araujogui force-pushed the sqlite-prepare-persistent branch 2 times, most recently from 125d667 to 69fc714Compare May 27, 2026 18:25

meixg added the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2026

araujogui added 4 commits August 13, 2026 14:39

sqlite: add stmt persistent flag
f24dfaa
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

sqlite: use persistent statements on tag store
82b4348

sqlite: use mern
5a188f7

sqlite: fix missing erm
d32e5e6

araujogui force-pushed the sqlite-prepare-persistent branch from 69fc714 to d32e5e6Compare August 13, 2026 17:44

trivikr requested changes Aug 14, 2026
View reviewed changes

Comment threaddoc/api/sqlite.md
Comment threaddoc/api/sqlite.md

sqlite: fix persistent prepare doc
2e519da

araujogui mentioned this pull request Aug 14, 2026
sqlite: reuse cached column names in all() and get() #65276
Merged

trivikr approved these changes Aug 14, 2026
View reviewed changes

geeksilva97 approved these changes Aug 14, 2026
View reviewed changes

This comment was marked as outdated.
Sign in to view

trivikr added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 14, 2026

nodejs-github-bot merged commit c8996ea into nodejs:mainAug 14, 2026
71 of 73 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 14, 2026

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

araujogui deleted the sqlite-prepare-persistent branch August 27, 2026 13:03