Uh oh!
There was an error while loading. Please reload this page.
tools: add non-default OpenSSL versions to the test-shared workflow - #62862
Conversation
nodejs-github-bot
commented
Apr 21, 2026
Review requested:
|
aduh95
commented
Apr 21, 2026
Adding extra GHA workflows comes at the expense of spending more minutes to prepare security releases. We can skip the test-shared workflow on the private repo, but idk if it's worth it given that there are some path that we only run on that workflow. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
panva
commented
Apr 21, 2026
The OpenSSL versions are a big gap. Since we don't/can't keep up with the versions in CI. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
8bab015 to
1311e12CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aduh95
commented
Apr 25, 2026
I did another pass at this PR, and tested aduh95@a01a6ef. Could you have a look, and feel free to pull it and/or adapt from it |
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
bc5e7eb to
85900e8Compare@aduh95 looks great, i pulled it in and lint-fixed it |
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Apr 26, 2026
Landed in 0f68423 |
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #62862 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Renegade334
commented
May 12, 2026
So where are we with OpenSSL 1.x support? The conversation in #56733 was approaching whether to withdraw this for v24.x, whereas we appear to be upping our integration a year later? |
Adds an additional OpenSSL shared-libraries matrix to
test-shared.ymlso PRs run against additional supported OpenSSL releases. No more waiting for a full CI to find out a crypto/TLS change is broken on another version 🙏.build-opensslnow uses a committed matrix intest-shared.yml, regenerated by the existing weeklynixpkgs-unstableupdater so the pin bump and tested OpenSSL variants stay in sync in a single PR.1.1.1.SUPPORTED_OPENSSL_VERSIONremains a manually maintained value intools/nix/collect-openssl-matrix.sh, and drives per-entrycontinue-on-errorin the autogenerated matrix so releases newer than what we explicitly support do not fail GHA.