lib: narrow ReadableStreamBYOBRequest.view return type to Uint8Array

[Jah-yee]

Description

Follow WHATWG streams spec update: whatwg/streams#1367

ReadableStreamBYOBRequest.view is always constructed as a Uint8Array, and the specification will be updated to enforce this. This changes the documented return type from ArrayBufferView to Uint8Array.

Fix

Changed the JSDoc type annotation for view getter from @type {ArrayBufferView} to @type {Uint8Array} in lib/internal/webstreams/readablestream.js.

Fixes#62952

[Jah-yee]

👋 Checking in — PR is a clean 1-line JSDoc type fix per WHATWG streams spec update. Happy to address any feedback or add tests. Thanks! 🙏

[Jah-yee]

PR still active and ready for review. 🙏

[gurgunday]

Hi, thanks for the PR

Please stop spamming, the maintainers will review it when they are free

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (42a154b) to head (fb1859c).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #62958 +/- ##
==========================================
+ Coverage 89.64% 89.66% +0.01% 
==========================================
Files 706 706 Lines 219394 219394 Branches 42066 42066 ==========================================
+ Hits 196674 196710 +36 + Misses 14629 14584 -45 - Partials 8091 8100 +9 

Files with missing lines	Coverage Δ
lib/internal/webstreams/readablestream.js	98.54% <100.00%> (ø)

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73001/

[Jah-yee]

Hi @MattiasBuelens, thank you for the approval! I noticed there are 2 failing CI checks:

1. lint-commit-message - FAILURE
2. test-macOS - FAILURE

The lint failure may be blocking the merge. Please let me know if you'd like me to address anything. I'm happy to help rebase if needed.

[MattiasBuelens]

Indeed, the linter flagged this problem with the commit message:

not ok 4 line-length: Line should be <= 72 columns.

It looks like you'll need to slightly tweak the wording and/or word wrapping in the message. You'll want to use git commit --amend to do that. Have a look at our commit message guidelines for more details.

[Jah-yee]

Replaced by updated PR with corrected commit message (lint commit message fix per maintainer feedback). New PR: #63017