Uh oh!
There was an error while loading. Please reload this page.
src: fast path empty native immediate drain - #62969
Merged
nodejs-github-bot merged 2 commits intoJun 14, 2026
Merged
Conversation
gurgundayforce-pushed
the
perf/env-skip-native-immediate
branch
from
April 26, 2026 11:55
dc6cba4 to
0bed081CompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #62969 +/- ##
==========================================
- Coverage 89.66% 89.65% -0.02%
==========================================
Files 706 706 Lines 219416 219424 +8 Branches 42073 42077 +4 ==========================================
- Hits 196738 196718 -20 - Misses 14576 14591 +15 - Partials 8102 8115 +13
🚀 New features to boost your workflow:
|
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
gurgundayforce-pushed
the
perf/env-skip-native-immediate
branch
from
April 26, 2026 13:38
0bed081 to
1584afcCompareaddaleax
approved these changes
Apr 27, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
May 11, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
May 17, 2026
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Jun 9, 2026
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jun 14, 2026
Collaborator
Landed in 4fb667e |
aduh95 pushed a commit
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> PR-URL: #62969 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
maksimyaromin added a commit
to maksimyaromin/isolated-vm
that referenced
this pull request
Jul 22, 2026
TransferablePromiseHolder::ResolveTask settles the receiving side's promise without running a microtask checkpoint, so under the nodejs isolate's explicit microtasks policy the awaiting continuations stay queued until unrelated JS activity runs one. Node used to mask this with an accidental per-iteration checkpoint; nodejs/node#62969 (26.4.0) removed it.
laverdet pushed a commit
to laverdet/isolated-vm
that referenced
this pull request
Aug 1, 2026
TransferablePromiseHolder::ResolveTask settles the receiving side's promise without running a microtask checkpoint, so under the nodejs isolate's explicit microtasks policy the awaiting continuations stay queued until unrelated JS activity runs one. Node used to mask this with an accidental per-iteration checkpoint; nodejs/node#62969 (26.4.0) removed it.
skvelymake pushed a commit
to integromat/isolated-vm
that referenced
this pull request
Aug 5, 2026
TransferablePromiseHolder::ResolveTask settles the receiving side's promise without running a microtask checkpoint, so under the nodejs isolate's explicit microtasks policy the awaiting continuations stay queued until unrelated JS activity runs one. Node used to mask this with an accidental per-iteration checkpoint; nodejs/node#62969 (26.4.0) removed it.
aduh95
commented
Aug 6, 2026
Contributor
This doesn't land cleanly on v24.x-staging, it would require a manual backport PR if we want it on Node.js 24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunAndClearNativeImmediates is called from CheckImmediate on every event loop tick, but most calls have no native immediates queued
Before:
After: