Skip to content

lib: simplify codedTypeError signature - #62998

Closed
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:codedTypeError
Closed

lib: simplify codedTypeError signature#62998
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:codedTypeError

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

Given its name and its usage, it makes little sense to have the function take an optional bag of option when we expect exactly one.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95 requested a review from panvaApril 27, 2026 22:18
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 27, 2026
@panva

Copy link
Copy Markdown
Member

@aduh95 thank you, could you make that request in #62979? I'm happy to fold it there.

@codecov

codecovBot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (b6b6e96) to head (14d7210).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #62998 +/- ##
==========================================
+ Coverage 89.64% 89.65% +0.01% 
==========================================
Files 707 707 Lines 219509 219508 -1 Branches 42095 42085 -10 ==========================================
+ Hits 196775 196806 +31 + Misses 14628 14591 -37 - Partials 8106 8111 +5 
Files with missing linesCoverage Δ
lib/internal/webidl.js96.72% <100.00%> (-0.01%)⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95

Copy link
Copy Markdown
ContributorAuthor

@panva should I cherry-pick it and push to your branch?

@panva

Copy link
Copy Markdown
Member

@aduh95 already did 6199f7f (#62979)

@aduh95

Copy link
Copy Markdown
ContributorAuthor

Superseded by 6199f7f

@aduh95aduh95 closed this Apr 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95@panva@nodejs-github-bot