Uh oh!
There was an error while loading. Please reload this page.
deps: fix libffi macos build - #63006
Conversation
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
nodejs-github-bot
commented
Apr 28, 2026
Review requested:
|
Fast-track has been requested by @ShogunPanda. Please 👍 to approve. |
targos
commented
Apr 28, 2026
Should we make a release test build? |
ShogunPanda
commented
Apr 28, 2026
@targos Totally open to it. How? |
targos
commented
Apr 28, 2026
I can do it. |
ShogunPanda
commented
Apr 28, 2026
Ok. Let me know how it works and if it succeeds. Thanks! |
ShogunPanda
commented
Apr 28, 2026
@targos I don't have access to that CI. Let me know how it goes. Thanks a lot buddy! |
nodejs-github-bot
commented
Apr 28, 2026
nodejs-github-bot
commented
Apr 28, 2026
ShogunPanda
commented
Apr 28, 2026
@targos Did the test release succeeded? |
targos
commented
Apr 28, 2026
release-pkg build failed :( |
targos
commented
Apr 28, 2026
Link: https://ci-release.nodejs.org/job/iojs+release/11719/nodes=macos15-release-pkg/console End of logs with error: |
targos
commented
Apr 28, 2026
But it's about Temporal, so I guess unrelated to this fix |
ShogunPanda
commented
Apr 28, 2026
Ok, can I merge this then? |
targos
commented
Apr 28, 2026
@richardlau Is there proof in the logs that the libffi issue is fixed? |
richardlau
commented
Apr 28, 2026
I think from the logs and no sign of the errors (#62787) are encouraging. Plus I think the libffi issue was masking the Temporal issue under Rosetta 2 as the build was previously failing before it attempted linking to the Temporal library😞. As an aside, since we've had these two issues in succession that occur under Rosetta 2 it would help if we had something to catch these earlier than the release CI (GitHub actions?). |
ShogunPanda
commented
Apr 28, 2026
@richardlau@targos Do you want me to fast-track and merge or what for few days? |
richardlau
commented
Apr 28, 2026
Let's try fast-tracking. We can't be in a worse state and might help us look at the Temporal issue that was masked by the one attempted to be fixed here. |
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Apr 28, 2026
Landed in 186995e |
Signed-off-by: Paolo Insogna <paolo@cowtech.it> PR-URL: #63006 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Fixes#62787.